Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct index construction #6500

Merged
merged 12 commits into from
Jul 15, 2024
Merged

Correct index construction #6500

merged 12 commits into from
Jul 15, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 07:38:13 UTC Pre-commit check for 131e8c3 has started.
⚪ 2024-07-10 07:40:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 08:08:13 UTC Build successful.
⚪ 2024-07-10 08:08:30 UTC Tests are running...
🔴 2024-07-10 10:05:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9915 9332 0 81 322 180

🟢 2024-07-10 10:06:22 UTC ydbd size 5.2 GiB changed* by +28.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ca2f330 merge: 131e8c3 diff diff %
ydbd size 5 611 351 408 Bytes 5 611 380 168 Bytes +28.1 KiB +0.001%
ydbd stripped size 1 206 692 792 Bytes 1 206 697 016 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 07:43:21 UTC Pre-commit check for 131e8c3 has started.
⚪ 2024-07-10 07:45:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 08:27:03 UTC Build successful.
⚪ 2024-07-10 08:27:19 UTC Tests are running...
🔴 2024-07-10 10:09:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38424 33178 0 3 5221 22

🟢 2024-07-10 10:10:17 UTC ydbd size 8.1 GiB changed* by +33.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ca2f330 merge: 131e8c3 diff diff %
ydbd size 8 721 394 048 Bytes 8 721 428 168 Bytes +33.3 KiB +0.000%
ydbd stripped size 475 016 608 Bytes 475 016 544 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 07:44:19 UTC Pre-commit check for 131e8c3 has started.
⚪ 2024-07-10 07:46:55 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 07:58:11 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

⚪ 2024-07-12 15:30:57 UTC Pre-commit check for 9b2b0ce has started.
⚪ 2024-07-12 15:34:06 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-12 16:14:54 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

⚪ 2024-07-12 15:35:54 UTC Pre-commit check for 9b2b0ce has started.
⚪ 2024-07-12 15:39:18 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-12 17:52:14 UTC Build successful.
🔴 2024-07-12 17:59:39 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39530 34227 0 64 5222 17

🟢 2024-07-12 18:00:22 UTC ydbd size 8.1 GiB changed* by -7.5 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f74adc0 merge: 9b2b0ce diff diff %
ydbd size 8 718 795 112 Bytes 8 710 956 016 Bytes -7.5 MiB -0.090%
ydbd stripped size 475 668 336 Bytes 475 270 576 Bytes -388.4 KiB -0.084%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

⚪ 2024-07-12 15:38:37 UTC Pre-commit check for 9b2b0ce has started.
⚪ 2024-07-12 15:42:05 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-12 18:07:28 UTC Build successful.
🔴 2024-07-12 18:09:36 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11012 10363 0 148 323 178

🟢 2024-07-12 18:10:22 UTC ydbd size 5.2 GiB changed* by -5.2 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d0aff76 merge: 9b2b0ce diff diff %
ydbd size 5 608 995 032 Bytes 5 603 539 056 Bytes -5.2 MiB -0.097%
ydbd stripped size 1 207 400 496 Bytes 1 206 160 144 Bytes -1.2 MiB -0.103%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

⚪ 2024-07-13 05:32:19 UTC Pre-commit check for 3b4c34b has started.
⚪ 2024-07-13 05:35:28 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-13 06:13:22 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

⚪ 2024-07-13 05:32:20 UTC Pre-commit check for 3b4c34b has started.
⚪ 2024-07-13 05:35:28 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-13 08:08:24 UTC Build successful.
🔴 2024-07-13 08:11:05 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10975 10390 0 82 325 178

🟢 2024-07-13 08:11:51 UTC ydbd size 5.2 GiB changed* by -5.9 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1a6514b merge: 3b4c34b diff diff %
ydbd size 5 574 427 896 Bytes 5 568 290 616 Bytes -5.9 MiB -0.110%
ydbd stripped size 1 201 350 736 Bytes 1 200 015 120 Bytes -1.3 MiB -0.111%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

⚪ 2024-07-13 05:34:17 UTC Pre-commit check for 3b4c34b has started.
⚪ 2024-07-13 05:37:23 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-13 07:57:14 UTC Build successful.
🔴 2024-07-13 08:03:25 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39495 34253 0 3 5221 18

🟢 2024-07-13 08:04:03 UTC ydbd size 8.1 GiB changed* by -8.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1a6514b merge: 3b4c34b diff diff %
ydbd size 8 691 591 912 Bytes 8 683 108 872 Bytes -8.1 MiB -0.098%
ydbd stripped size 473 712 304 Bytes 473 289 840 Bytes -412.6 KiB -0.089%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

⚪ 2024-07-13 10:02:31 UTC Pre-commit check for d172997 has started.
⚪ 2024-07-13 10:05:33 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-13 12:07:53 UTC Build successful.
🔴 2024-07-13 12:10:05 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10969 10386 0 84 321 178

🟢 2024-07-13 12:10:43 UTC ydbd size 5.2 GiB changed* by -5.9 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1daaf66 merge: d172997 diff diff %
ydbd size 5 574 427 896 Bytes 5 568 293 496 Bytes -5.9 MiB -0.110%
ydbd stripped size 1 201 350 736 Bytes 1 200 015 888 Bytes -1.3 MiB -0.111%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

⚪ 2024-07-13 10:03:44 UTC Pre-commit check for d172997 has started.
⚪ 2024-07-13 10:06:49 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-13 10:14:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 13, 2024 •
edited
Loading

⚪ 2024-07-13 10:04:28 UTC Pre-commit check for d172997 has started.
⚪ 2024-07-13 10:07:31 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-13 12:02:38 UTC Build successful.
🔴 2024-07-13 12:10:10 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39494 34251 0 1 5222 20

🟢 2024-07-13 12:11:02 UTC ydbd size 8.1 GiB changed* by -8.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6ee94d0 merge: d172997 diff diff %
ydbd size 8 691 591 640 Bytes 8 683 110 216 Bytes -8.1 MiB -0.098%
ydbd stripped size 473 712 304 Bytes 473 290 096 Bytes -412.3 KiB -0.089%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:25:19 UTC Pre-commit check for 52add8e has started.
⚪ 2024-07-14 05:28:27 UTC Build+Tests linux-x86_64-release-clang14 is running...
⚫ 2024-07-14 05:32:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:25:25 UTC Pre-commit check for 52add8e has started.
⚪ 2024-07-14 05:28:27 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🔴 2024-07-14 05:32:28 UTC Test run completed, no test results found for commit 0cc3390.
⚫ 2024-07-14 05:33:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:25:26 UTC Pre-commit check for 52add8e has started.
⚪ 2024-07-14 05:28:49 UTC Build+Tests linux-x86_64-release-asan is running...
🔴 2024-07-14 05:32:28 UTC Test run completed, no test results found for commit 0cc3390.
⚫ 2024-07-14 05:33:25 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 force-pushed the correct_index_construction branch from 0cc3390 to e417a4f Compare July 14, 2024 05:32
@github-actions GitHub Actions
Copy link

⚪ 2024-07-14 05:35:01 UTC Pre-commit check for fb15664 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:36:08 UTC Pre-commit check for fb15664 has started.
🔴 2024-07-14 05:39:17 UTC Test run completed, no test results found for commit e417a4f.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:36:08 UTC Pre-commit check for fb15664 has started.
🔴 2024-07-14 05:39:18 UTC Test run completed, no test results found for commit e417a4f.

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jul 14, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:56:22 UTC Pre-commit check for fb15664 has started.
⚪ 2024-07-14 05:59:21 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-14 06:04:10 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:56:46 UTC Pre-commit check for fb15664 has started.
⚪ 2024-07-14 05:59:51 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-14 08:07:43 UTC Build successful.
🔴 2024-07-14 08:10:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10973 10378 0 87 328 180

🟢 2024-07-14 08:11:45 UTC ydbd size 5.2 GiB changed* by -5.8 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4f93432 merge: fb15664 diff diff %
ydbd size 5 574 561 088 Bytes 5 568 430 584 Bytes -5.8 MiB -0.110%
ydbd stripped size 1 201 375 696 Bytes 1 200 044 816 Bytes -1.3 MiB -0.111%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 05:58:22 UTC Pre-commit check for fb15664 has started.
⚪ 2024-07-14 06:01:32 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-14 07:57:19 UTC Build successful.
🔴 2024-07-14 08:04:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39493 34248 0 3 5222 20

🟢 2024-07-14 08:05:32 UTC ydbd size 8.1 GiB changed* by -8.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4f93432 merge: fb15664 diff diff %
ydbd size 8 691 698 104 Bytes 8 683 216 624 Bytes -8.1 MiB -0.098%
ydbd stripped size 473 719 408 Bytes 473 297 136 Bytes -412.4 KiB -0.089%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 force-pushed the correct_index_construction branch from e417a4f to df9001f Compare July 14, 2024 09:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 09:18:58 UTC Pre-commit check for 6dc0ff9 has started.
⚪ 2024-07-14 09:22:02 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-14 11:48:02 UTC Build successful.
🔴 2024-07-14 11:50:59 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10972 10390 0 85 319 178

🟢 2024-07-14 11:51:42 UTC ydbd size 5.2 GiB changed* by -5.9 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38a7ef2 merge: 6dc0ff9 diff diff %
ydbd size 5 574 615 648 Bytes 5 568 478 424 Bytes -5.9 MiB -0.110%
ydbd stripped size 1 201 391 056 Bytes 1 200 055 504 Bytes -1.3 MiB -0.111%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 09:19:12 UTC Pre-commit check for 6dc0ff9 has started.
⚪ 2024-07-14 09:22:19 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-14 11:41:20 UTC Build successful.
🔴 2024-07-14 11:48:20 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39496 34252 0 3 5222 19

🟢 2024-07-14 11:49:01 UTC ydbd size 8.1 GiB changed* by -8.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38a7ef2 merge: 6dc0ff9 diff diff %
ydbd size 8 691 727 952 Bytes 8 683 244 920 Bytes -8.1 MiB -0.098%
ydbd stripped size 473 720 880 Bytes 473 298 416 Bytes -412.6 KiB -0.089%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 09:20:38 UTC Pre-commit check for 6dc0ff9 has started.
⚪ 2024-07-14 09:23:36 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-14 09:53:21 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 15:24:22 UTC Pre-commit check for 3ad325d has started.
⚪ 2024-07-14 15:27:23 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-14 15:38:46 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 15:24:36 UTC Pre-commit check for 3ad325d has started.
⚪ 2024-07-14 15:27:37 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-14 17:25:01 UTC Build successful.
🔴 2024-07-14 17:32:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39496 34251 0 5 5222 18

🟢 2024-07-14 17:32:46 UTC ydbd size 8.1 GiB changed* by -7.8 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38a7ef2 merge: 3ad325d diff diff %
ydbd size 8 691 727 952 Bytes 8 683 523 072 Bytes -7.8 MiB -0.094%
ydbd stripped size 473 720 880 Bytes 473 304 304 Bytes -406.8 KiB -0.088%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

⚪ 2024-07-14 15:24:41 UTC Pre-commit check for 3ad325d has started.
⚪ 2024-07-14 15:27:41 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-14 17:38:37 UTC Build successful.
🔴 2024-07-14 17:41:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10975 10388 0 83 324 180

🟢 2024-07-14 17:42:16 UTC ydbd size 5.2 GiB changed* by -5.8 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 38a7ef2 merge: 3ad325d diff diff %
ydbd size 5 574 615 648 Bytes 5 568 583 616 Bytes -5.8 MiB -0.108%
ydbd stripped size 1 201 391 056 Bytes 1 200 066 992 Bytes -1.3 MiB -0.110%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit ab051d7 into ydb-platform:main Jul 15, 2024
8 of 12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the correct_index_construction branch July 15, 2024 13:35
marsaly79 pushed a commit to marsaly79/ydb that referenced this pull request Jul 15, 2024
@ivanmorozov333 @marsaly79
Correct index construction (ydb-platform#6500)
a90fd4e
This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jul 23, 2024
@ivanmorozov333 @zverevgeny
Correct index construction (ydb-platform#6500)
f2e678c
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildar-khisambeev ildar-khisambeev ildar-khisambeev approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @ildar-khisambeev