Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add records to change queue at Execute() stage #6497

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Add records to change queue at Execute() stage #6497

merged 8 commits into from
Jul 11, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jul 9, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL linked an issue Jul 9, 2024 that may be closed by this pull request
Lost schema snapshot in CDC #6102
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 19:44:10 UTC Pre-commit check for cce5244 has started.
⚪ 2024-07-09 19:46:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 20:27:11 UTC Build successful.
⚪ 2024-07-09 20:27:25 UTC Tests are running...
🔴 2024-07-09 22:28:18 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9810 9217 0 93 322 178

🟡 2024-07-09 22:29:22 UTC ydbd size 5.2 GiB changed* by +296.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1b692c6 merge: cce5244 diff diff %
ydbd size 5 611 091 952 Bytes 5 611 395 976 Bytes +296.9 KiB +0.005%
ydbd stripped size 1 206 645 016 Bytes 1 206 703 320 Bytes +56.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 19:44:16 UTC Pre-commit check for cce5244 has started.
⚪ 2024-07-09 19:46:50 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 20:20:58 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚪ 2024-07-09 19:44:31 UTC Pre-commit check for cce5244 has started.
⚪ 2024-07-09 19:47:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 20:29:23 UTC Build successful.
⚪ 2024-07-09 20:29:39 UTC Tests are running...
🔴 2024-07-09 21:52:15 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14084 12749 0 14 1306 15

🟡 2024-07-09 21:53:10 UTC ydbd size 8.1 GiB changed* by +711.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1c388ef merge: cce5244 diff diff %
ydbd size 8 720 743 872 Bytes 8 721 472 736 Bytes +711.8 KiB +0.008%
ydbd stripped size 474 989 728 Bytes 475 019 424 Bytes +29.0 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL requested a review from snaury July 10, 2024 10:43
@CyberROFL CyberROFL marked this pull request as ready for review July 10, 2024 10:43
@CyberROFL CyberROFL marked this pull request as draft July 10, 2024 10:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 10:47:10 UTC Pre-commit check for 8bab37e has started.
⚪ 2024-07-10 10:49:45 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-07-10 10:50:19 UTC Check cancelled

@CyberROFL CyberROFL force-pushed the issue-6102 branch 2 times, most recently from 8d190b7 to 2e9f972 Compare July 10, 2024 10:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 11:01:39 UTC Pre-commit check for d3d5236 has started.
⚪ 2024-07-10 11:04:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 11:13:33 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 11:01:51 UTC Pre-commit check for d3d5236 has started.
⚪ 2024-07-10 11:04:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 11:45:44 UTC Build successful.
⚪ 2024-07-10 11:46:00 UTC Tests are running...
🔴 2024-07-10 13:33:08 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39588 34344 0 5 5219 20

🟡 2024-07-10 13:33:51 UTC ydbd size 8.1 GiB changed* by +520.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 483e9ee merge: d3d5236 diff diff %
ydbd size 8 721 407 872 Bytes 8 721 940 768 Bytes +520.4 KiB +0.006%
ydbd stripped size 475 018 016 Bytes 475 029 984 Bytes +11.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 11:09:37 UTC Pre-commit check for d3d5236 has started.
⚪ 2024-07-10 11:12:34 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 11:38:13 UTC Build successful.
⚪ 2024-07-10 11:38:23 UTC Tests are running...
🔴 2024-07-10 13:40:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11062 10476 0 83 324 179

🟡 2024-07-10 13:41:04 UTC ydbd size 5.2 GiB changed* by +218.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 483e9ee merge: d3d5236 diff diff %
ydbd size 5 611 370 560 Bytes 5 611 594 088 Bytes +218.3 KiB +0.004%
ydbd stripped size 1 206 696 760 Bytes 1 206 727 480 Bytes +30.0 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL mentioned this pull request Jul 10, 2024
Open
@CyberROFL CyberROFL marked this pull request as ready for review July 10, 2024 18:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 18:27:00 UTC Pre-commit check for 40f6eea has started.
⚪ 2024-07-10 18:29:34 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 18:38:45 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 18:27:04 UTC Pre-commit check for 40f6eea has started.
⚪ 2024-07-10 18:29:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 19:12:31 UTC Build successful.
⚪ 2024-07-10 19:12:45 UTC Tests are running...
🔴 2024-07-10 21:00:26 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39565 34326 0 1 5221 17

🟡 2024-07-10 21:01:06 UTC ydbd size 8.1 GiB changed* by +755.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 11ed7b0 merge: 40f6eea diff diff %
ydbd size 8 713 866 832 Bytes 8 714 640 480 Bytes +755.5 KiB +0.009%
ydbd stripped size 475 276 240 Bytes 475 296 656 Bytes +19.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 18:27:11 UTC Pre-commit check for 40f6eea has started.
⚪ 2024-07-10 18:29:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 18:54:58 UTC Build successful.
⚪ 2024-07-10 18:55:25 UTC Tests are running...
🔴 2024-07-10 20:51:34 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11039 10455 0 82 324 178

🟡 2024-07-10 20:52:11 UTC ydbd size 5.2 GiB changed* by +337.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 11ed7b0 merge: 40f6eea diff diff %
ydbd size 5 604 712 688 Bytes 5 605 057 984 Bytes +337.2 KiB +0.006%
ydbd stripped size 1 206 060 272 Bytes 1 206 117 456 Bytes +55.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL added the rebase-and-check Rebase PR with the current base branch and check label Jul 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 21:18:42 UTC Pre-commit check for b1ee554 has started.
⚪ 2024-07-10 21:21:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 21:38:53 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 21:18:58 UTC Pre-commit check for b1ee554 has started.
⚪ 2024-07-10 21:21:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 21:47:20 UTC Build successful.
⚪ 2024-07-10 21:47:32 UTC Tests are running...
🔴 2024-07-10 22:44:42 UTC Test run completed, no test results found for commit ea10ee3. Please check test log.
🟡 2024-07-10 22:45:13 UTC ydbd size 5.2 GiB changed* by +359.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0f81829 merge: b1ee554 diff diff %
ydbd size 5 604 714 336 Bytes 5 605 082 640 Bytes +359.7 KiB +0.007%
ydbd stripped size 1 206 060 464 Bytes 1 206 121 712 Bytes +59.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-07-10 22:45:15 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 21:18:59 UTC Pre-commit check for b1ee554 has started.
⚪ 2024-07-10 21:21:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 22:01:59 UTC Build successful.
⚪ 2024-07-10 22:02:16 UTC Tests are running...
🔴 2024-07-10 22:44:40 UTC Test run completed, no test results found for commit ea10ee3. Please check test log.
🟡 2024-07-10 22:45:18 UTC ydbd size 8.1 GiB changed* by +782.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0f81829 merge: b1ee554 diff diff %
ydbd size 8 713 867 240 Bytes 8 714 668 888 Bytes +782.9 KiB +0.009%
ydbd stripped size 475 276 304 Bytes 475 298 640 Bytes +21.8 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-07-10 22:45:19 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 22:47:12 UTC Pre-commit check for 9f9be14 has started.
⚪ 2024-07-10 22:50:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-10 23:15:03 UTC Build successful.
⚪ 2024-07-10 23:15:16 UTC Tests are running...
🔴 2024-07-11 01:22:14 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11038 10457 0 80 324 177

🟡 2024-07-11 01:22:56 UTC ydbd size 5.2 GiB changed* by +337.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63653ea merge: 9f9be14 diff diff %
ydbd size 5 604 737 408 Bytes 5 605 082 984 Bytes +337.5 KiB +0.006%
ydbd stripped size 1 206 064 592 Bytes 1 206 122 032 Bytes +56.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 22:48:43 UTC Pre-commit check for 9f9be14 has started.
⚪ 2024-07-10 22:51:17 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-10 22:58:45 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

⚪ 2024-07-10 22:48:51 UTC Pre-commit check for 9f9be14 has started.
⚪ 2024-07-10 22:51:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-10 23:31:08 UTC Build successful.
⚪ 2024-07-10 23:31:29 UTC Tests are running...
🔴 2024-07-11 01:15:23 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39570 34330 0 3 5220 17

🟡 2024-07-11 01:16:01 UTC ydbd size 8.1 GiB changed* by +755.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63653ea merge: 9f9be14 diff diff %
ydbd size 8 713 895 256 Bytes 8 714 669 000 Bytes +755.6 KiB +0.009%
ydbd stripped size 475 278 224 Bytes 475 298 576 Bytes +19.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

snaury
snaury reviewed Jul 11, 2024
View reviewed changes
ydb/core/tx/datashard/datashard.cpp Outdated Show resolved Hide resolved
ydb/core/tx/datashard/datashard.cpp Outdated Show resolved Hide resolved
ydb/core/tx/datashard/move_index_unit.cpp Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚪ 2024-07-11 10:12:21 UTC Pre-commit check for ef4c276 has started.
⚪ 2024-07-11 10:14:54 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 10:31:48 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚪ 2024-07-11 10:13:09 UTC Pre-commit check for ef4c276 has started.
⚪ 2024-07-11 10:15:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 10:55:03 UTC Build successful.
⚪ 2024-07-11 10:55:16 UTC Tests are running...
🔴 2024-07-11 12:38:20 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39571 34330 0 4 5220 17

🟡 2024-07-11 12:39:42 UTC ydbd size 8.1 GiB changed* by +650.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 526f29d merge: ef4c276 diff diff %
ydbd size 8 713 870 144 Bytes 8 714 536 056 Bytes +650.3 KiB +0.008%
ydbd stripped size 475 277 328 Bytes 475 294 288 Bytes +16.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

⚪ 2024-07-11 10:13:15 UTC Pre-commit check for ef4c276 has started.
⚪ 2024-07-11 10:15:50 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 10:40:54 UTC Build successful.
⚪ 2024-07-11 10:41:10 UTC Tests are running...
🔴 2024-07-11 12:41:58 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11041 10455 0 84 325 177

🟡 2024-07-11 12:42:40 UTC ydbd size 5.2 GiB changed* by +298.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 526f29d merge: ef4c276 diff diff %
ydbd size 5 604 720 408 Bytes 5 605 025 864 Bytes +298.3 KiB +0.005%
ydbd stripped size 1 206 063 696 Bytes 1 206 114 224 Bytes +49.3 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit cf0087d into ydb-platform:main Jul 11, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the issue-6102 branch July 11, 2024 13:44
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 12, 2024
@CyberROFL
Add records to change queue at Execute() stage (ydb-platform#6497)
30b2fa8
This was referenced Jul 12, 2024
Closed
Merged
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 12, 2024
@CyberROFL
Add records to change queue at Execute() stage (ydb-platform#6497)
8e800d6
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Merged
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jul 12, 2024
@CyberROFL
Add records to change queue at Execute() stage (ydb-platform#6497)
cc02834
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Merged
This was referenced Jul 12, 2024
Merged
Merged
Merged
This was referenced Jul 22, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaury snaury snaury approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lost schema snapshot in CDC
2 participants
@CyberROFL @snaury