Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove portions constructor hard freeing from tablet #6389

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 07:29:59 UTC Pre-commit check for 26df1ee has started.
2024-07-08 07:32:25 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 07:38:00 UTC Build successful.

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 07:30:10 UTC Pre-commit check for 26df1ee has started.
2024-07-08 07:32:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 07:56:30 UTC Build successful.
2024-07-08 07:56:45 UTC Tests are running...
🔴 2024-07-08 08:03:54 UTC Test run completed, no test results found for commit 635bf55. Please check test log.
🟡 2024-07-08 08:04:27 UTC ydbd size 5.2 GiB changed* by +294.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77685b3 merge: 26df1ee diff diff %
ydbd size 5 614 060 320 Bytes 5 614 361 352 Bytes +294.0 KiB +0.005%
ydbd stripped size 1 209 974 104 Bytes 1 210 009 048 Bytes +34.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-07-08 08:04:29 UTC Check cancelled

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 07:30:17 UTC Pre-commit check for 26df1ee has started.
2024-07-08 07:32:50 UTC Build linux-x86_64-relwithdebinfo is running...
2024-07-08 08:04:53 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 force-pushed the hard-freeing-for-portions-remove-from-tablet branch from 635bf55 to 38e9f7b Compare July 8, 2024 08:03
Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 08:07:53 UTC Pre-commit check for 0d480c6 has started.
2024-07-08 08:10:23 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 08:16:10 UTC Build successful.

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 08:08:05 UTC Pre-commit check for 0d480c6 has started.
2024-07-08 08:10:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 08:33:53 UTC Build successful.
2024-07-08 08:34:12 UTC Tests are running...
🔴 2024-07-08 10:31:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9755 9183 0 80 322 170

🟡 2024-07-08 10:32:40 UTC ydbd size 5.2 GiB changed* by +219.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1f88b11 merge: 0d480c6 diff diff %
ydbd size 5 614 135 680 Bytes 5 614 360 608 Bytes +219.7 KiB +0.004%
ydbd stripped size 1 209 991 064 Bytes 1 210 011 480 Bytes +19.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 08:08:41 UTC Pre-commit check for 0d480c6 has started.
2024-07-08 08:11:14 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 08:48:51 UTC Build successful.
2024-07-08 08:49:10 UTC Tests are running...
🟢 2024-07-08 10:10:31 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13870 12552 0 0 1307 11

🟡 2024-07-08 10:11:15 UTC ydbd size 8.1 GiB changed* by +400.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1f88b11 merge: 0d480c6 diff diff %
ydbd size 8 721 801 400 Bytes 8 722 211 912 Bytes +400.9 KiB +0.005%
ydbd stripped size 476 624 376 Bytes 476 635 832 Bytes +11.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny self-requested a review July 8, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants