Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize special keys in separated thread #6324

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 commented Jul 5, 2024

  • Performance improvement

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 09:59:16 UTC Pre-commit check for b3e994b has started.
2024-07-05 10:02:21 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-05 10:02:35 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:07:59 UTC Pre-commit check for b3e994b has started.
2024-07-05 10:11:07 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-05 10:11:21 UTC Build failed. see the build logs.
🔴 2024-07-05 10:11:22 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:12:26 UTC Pre-commit check for b3e994b has started.
2024-07-05 10:15:07 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-05 10:15:21 UTC Build failed. see the build logs.
🔴 2024-07-05 10:15:22 UTC Tests run skipped.

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jul 5, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:21:00 UTC Pre-commit check for 0ab9b81 has started.
2024-07-05 10:23:35 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-05 10:23:49 UTC Build failed. see the build logs.
🔴 2024-07-05 10:23:50 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:28:03 UTC Pre-commit check for 0ab9b81 has started.
2024-07-05 10:30:36 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-05 10:30:49 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 10:28:56 UTC Pre-commit check for 0ab9b81 has started.
2024-07-05 10:31:32 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-05 10:31:46 UTC Build failed. see the build logs.
🔴 2024-07-05 10:31:48 UTC Tests run skipped.

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jul 5, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 5, 2024
@ivanmorozov333 ivanmorozov333 changed the title prevent hard freeing serialize special keys in separated thread Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 11:57:03 UTC Pre-commit check for d2f4b75 has started.
2024-07-05 12:00:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-05 12:30:33 UTC Build successful.
2024-07-05 12:30:47 UTC Tests are running...
🔴 2024-07-05 14:38:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9980 9394 0 92 324 170

🟢 2024-07-05 14:39:00 UTC ydbd size 5.2 GiB changed* by +20.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5fc09ca merge: d2f4b75 diff diff %
ydbd size 5 615 862 464 Bytes 5 615 883 600 Bytes +20.6 KiB +0.000%
ydbd stripped size 1 211 107 272 Bytes 1 211 108 104 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 12:01:59 UTC Pre-commit check for d2f4b75 has started.
2024-07-05 12:04:58 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-05 12:21:12 UTC Build successful.

Copy link

github-actions bot commented Jul 5, 2024

2024-07-05 12:03:24 UTC Pre-commit check for d2f4b75 has started.
2024-07-05 12:06:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-05 12:50:11 UTC Build successful.
2024-07-05 12:50:24 UTC Tests are running...
🟢 2024-07-05 14:34:22 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38486 33256 0 0 5220 10

🟢 2024-07-05 14:34:58 UTC ydbd size 8.1 GiB changed* by +51.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5fc09ca merge: d2f4b75 diff diff %
ydbd size 8 726 129 816 Bytes 8 726 182 592 Bytes +51.5 KiB +0.001%
ydbd stripped size 477 144 232 Bytes 477 144 296 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants