Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM part of combiner with spilling. #6277

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Update LLVM part of combiner with spilling. #6277

merged 1 commit into from
Jul 4, 2024

Conversation

Tony-Romanov
Copy link
Collaborator

No description provided.

@Tony-Romanov Tony-Romanov added the area/yql YQL query language issues label Jul 4, 2024
@Tony-Romanov Tony-Romanov linked an issue Jul 4, 2024 that may be closed by this pull request
[[YQL]] Adapt WideLastCombinerWrapper to work with spilling in LLVM #5416
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 06:28:33 UTC Pre-commit check for 9d36d2c has started.
⚪ 2024-07-04 06:31:03 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-04 06:37:29 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 06:28:40 UTC Pre-commit check for 9d36d2c has started.
⚪ 2024-07-04 06:31:09 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-04 07:10:12 UTC Build successful.
⚪ 2024-07-04 07:10:26 UTC Tests are running...
🟢 2024-07-04 09:25:30 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73236 59796 0 0 13428 12

🟢 2024-07-04 09:26:18 UTC ydbd size 8.2 GiB changed* by -11.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1064ddc merge: 9d36d2c diff diff %
ydbd size 8 775 503 896 Bytes 8 775 491 752 Bytes -11.9 KiB -0.000%
ydbd stripped size 482 710 312 Bytes 482 710 056 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

⚪ 2024-07-04 06:28:51 UTC Pre-commit check for 9d36d2c has started.
⚪ 2024-07-04 06:31:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-04 06:55:41 UTC Build successful.
⚪ 2024-07-04 06:55:57 UTC Tests are running...
🔴 2024-07-04 08:57:40 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12212 11609 0 92 340 171

🟢 2024-07-04 08:58:28 UTC ydbd size 5.3 GiB changed* by -16.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1064ddc merge: 9d36d2c diff diff %
ydbd size 5 712 433 488 Bytes 5 712 416 984 Bytes -16.1 KiB -0.000%
ydbd stripped size 1 235 350 248 Bytes 1 235 349 672 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Tony-Romanov Tony-Romanov requested a review from Darych July 4, 2024 10:27
@Tony-Romanov Tony-Romanov marked this pull request as ready for review July 4, 2024 10:27
@Tony-Romanov Tony-Romanov requested a review from a team as a code owner July 4, 2024 10:27
@Tony-Romanov Tony-Romanov enabled auto-merge (squash) July 4, 2024 10:27
Darych
Darych approved these changes Jul 4, 2024
View reviewed changes
ydb/library/yql/minikql/comp_nodes/mkql_wide_combine.cpp
enum class ETasteResult: ui8 {
Init,
enum class ETasteResult: i8 {
Init = -1,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to init from -1?

@Tony-Romanov Tony-Romanov merged commit 29e1e45 into ydb-platform:main Jul 4, 2024
12 of 16 checks passed
@Tony-Romanov Tony-Romanov deleted the combiner_llvm branch July 5, 2024 06:45
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 5, 2024
Merged
This was referenced Jul 8, 2024
Merged
Merged
Merged
Merged
This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darych Darych Darych approved these changes

Assignees
No one assigned
Labels
area/yql YQL query language issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[[YQL]] Adapt WideLastCombinerWrapper to work with spilling in LLVM
2 participants
@Tony-Romanov @Darych