YQL-9517: RPC Arrow reader YT column converters #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrLolthe1st
force-pushed
the
rpc-yt-converter
branch
from
7574b64 to
65913fc
Compare
MrLolthe1st
force-pushed
the
rpc-yt-converter
branch
from
65913fc to
62c4d4c
Compare
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 821a825.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 821a825.
|
MrLolthe1st
force-pushed
the
rpc-yt-converter
branch
from
0583a09 to
648164a
Compare
MrLolthe1st
force-pushed
the
rpc-yt-converter
branch
from
648164a to
3682034
Compare
nepal
reviewed
Dec 22, 2023
| arrow::Datum StringConverterImpl(NUdf::IArrayBuilder* builder, std::shared_ptr<arrow::ArrayData> block) { | ||
| if constexpr (!IsDictionary) { | ||
| typename ::arrow::TypeTraits<T>::ArrayType val(block); // checking for compatibility | ||
| if (val.null_count()) { |
There was a problem hiding this comment.
почему тут нельзя просто написать return block;
зачем надо ребилдить?
vitstn
reviewed
Dec 25, 2023
| : State_(state) | ||
| , ArrowResolver_(MakeSimpleArrowResolver(functionRegistry)) |
There was a problem hiding this comment.
не надо создавать arrow resolver, он есть в TypeCtx (в State_)
vitstn
reviewed
Dec 25, 2023
| @@ -396,12 +396,12 @@ std::unique_ptr<typename TTraits::TResult> MakeFixedSizeBlockReaderImpl(bool isO | |||
| } | |||
| } | |||
|
|
|||
| template <typename TTraits, typename T> | |||
| template <typename TTraits, typename T, NKikimr::NUdf::EDataSlot OriginalT> | |||
vitstn
reviewed
Dec 25, 2023
| @@ -3,6 +3,7 @@ | |||
| #include "yql_yt_provider.h" | |||
|
|
|||
| #include <ydb/library/yql/dq/integration/yql_dq_integration.h> | |||
| #include <ydb/library/yql/minikql/mkql_function_registry.h> | |||
vitstn
reviewed
Dec 25, 2023
| @@ -12,6 +12,7 @@ | |||
| #include <ydb/library/yql/providers/common/dq/yql_dq_integration_impl.h> | |||
| #include <ydb/library/yql/providers/common/codec/yql_codec_type_flags.h> | |||
| #include <ydb/library/yql/providers/common/config/yql_dispatch.h> | |||
| #include <ydb/library/yql/providers/common/arrow_resolve/yql_simple_arrow_resolver.h> | |||
vitstn
reviewed
Dec 25, 2023
| @@ -73,6 +73,7 @@ PEERDIR( | |||
| ydb/library/yql/providers/common/mkql | |||
| ydb/library/yql/providers/common/proto | |||
| ydb/library/yql/providers/common/activation | |||
| ydb/library/yql/providers/common/arrow_resolve | |||
vitstn
reviewed
Dec 25, 2023
| subTypeAnn.emplace_back(type->GetItemType()); | ||
| } | ||
|
|
||
| if (State_->Types->ArrowResolver->AreTypesSupported(ctx.GetPosition(node.Pos()), subTypeAnn, ctx) != IArrowResolver::EStatus::OK) { |
There was a problem hiding this comment.
if (!State_->Types->ArrowResolver) {
return false;
}
MrLolthe1st
force-pushed
the
rpc-yt-converter
branch
from
e059534 to
821a825
Compare
vitstn
approved these changes
Dec 25, 2023
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.