Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hive sensors on node count #5729

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

vporyadke
Copy link
Collaborator

@vporyadke vporyadke commented Jun 19, 2024

Changelog entry

fix hive sensors on node count

Changelog category

  • Bugfix

Additional information

Nodes connected sensor was not decreased in some cases. Also try to avoid an unnecessary call to GetNode that might inflate nodes total sensor.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 13:46:50 UTC Pre-commit check for 2013488 has started.
2024-06-19 13:49:19 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 13:51:12 UTC Build successful.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 13:50:41 UTC Pre-commit check for 2013488 has started.
2024-06-19 13:53:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 13:55:51 UTC Build successful.
2024-06-19 13:56:02 UTC Tests are running...
🔴 2024-06-19 15:18:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13889 12606 0 2 1274 7

🟢 2024-06-19 15:19:12 UTC merge: 2013488 ydbd size 8.6 GiB +3.1 KiB +0.000% vs build main: 2dd3d22

Build size details

main: 2dd3d22 ydbd build size:

  • binary size 9 212 645 184 Bytes
  • stripped binary size 711 238 064 Bytes

merge: 2013488 ydbd build size:

  • binary size 9 212 648 384 Bytes
  • stripped binary size 711 238 384 Bytes

ydbd size dashboard

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 14:01:33 UTC Pre-commit check for 2013488 has started.
2024-06-19 14:04:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 14:06:11 UTC Build successful.
2024-06-19 14:06:23 UTC Tests are running...
🔴 2024-06-19 15:55:25 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9638 9592 0 16 20 10

🟢 2024-06-19 15:56:04 UTC merge: 2013488 ydbd size 5.7 GiB +2.7 KiB +0.000% vs build main: 2dd3d22

Build size details

main: 2dd3d22 ydbd build size:

  • binary size 6 148 763 296 Bytes
  • stripped binary size 1 527 412 928 Bytes

merge: 2013488 ydbd build size:

  • binary size 6 148 766 080 Bytes
  • stripped binary size 1 527 413 632 Bytes

ydbd size dashboard

@vporyadke vporyadke merged commit 6466c7e into ydb-platform:main Jun 20, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants