Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report & show replication lag #5578

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Report & show replication lag #5578

merged 1 commit into from
Jun 17, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jun 14, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@CyberROFL CyberROFL self-assigned this Jun 14, 2024
@CyberROFL CyberROFL requested a review from Enjection June 14, 2024 15:16
@CyberROFL CyberROFL removed their assignment Jun 14, 2024
@CyberROFL CyberROFL self-assigned this Jun 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 15:18:40 UTC Pre-commit check for d7226df has started.
⚪ 2024-06-14 15:21:24 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-14 15:55:50 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 15:27:23 UTC Pre-commit check for d7226df has started.
⚪ 2024-06-14 15:30:08 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-14 16:09:30 UTC Build failed. see the build logs.
🔴 2024-06-14 16:09:31 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 15:37:02 UTC Pre-commit check for d7226df has started.
⚪ 2024-06-14 15:40:03 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-14 16:23:03 UTC Build failed. see the build logs.
🔴 2024-06-14 16:23:04 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:38:29 UTC Pre-commit check for 1b0e0da has started.
⚪ 2024-06-14 16:41:15 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-06-14 16:42:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:39:31 UTC Pre-commit check for 1b0e0da has started.
⚫ 2024-06-14 16:42:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:43:36 UTC Pre-commit check for d3ae804 has started.
⚪ 2024-06-14 16:46:22 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-06-14 16:49:02 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:44:18 UTC Pre-commit check for d3ae804 has started.
⚪ 2024-06-14 16:47:19 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-06-14 16:49:02 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:45:46 UTC Pre-commit check for d3ae804 has started.
⚪ 2024-06-14 16:48:39 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-06-14 16:49:01 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:50:22 UTC Pre-commit check for 6a3da97 has started.
⚪ 2024-06-14 16:53:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-14 16:55:30 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:50:22 UTC Pre-commit check for 6a3da97 has started.
⚪ 2024-06-14 16:53:08 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-14 16:55:37 UTC Build successful.
⚪ 2024-06-14 16:55:48 UTC Tests are running...
🔴 2024-06-14 17:51:37 UTC Test run completed, no test results found for commit 6239e78. Please check test log.
⚫ 2024-06-14 17:51:42 UTC Check cancelled

@CyberROFL CyberROFL marked this pull request as ready for review June 14, 2024 16:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 16:52:33 UTC Pre-commit check for 6a3da97 has started.
⚪ 2024-06-14 16:55:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-14 16:58:30 UTC Build successful.
⚪ 2024-06-14 16:58:50 UTC Tests are running...
🔴 2024-06-14 17:51:37 UTC Test run completed, no test results found for commit 6239e78. Please check test log.
⚫ 2024-06-14 17:51:47 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 17:53:13 UTC Pre-commit check for 8fc5d79 has started.
⚪ 2024-06-14 17:56:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-14 17:59:40 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 17:55:32 UTC Pre-commit check for 8fc5d79 has started.
⚪ 2024-06-14 17:58:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-14 18:01:40 UTC Build successful.
⚪ 2024-06-14 18:01:55 UTC Tests are running...
🔴 2024-06-14 20:12:31 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75478 62635 0 1 12836 6

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 17:55:33 UTC Pre-commit check for 8fc5d79 has started.
⚪ 2024-06-14 17:58:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-14 18:01:10 UTC Build successful.
⚪ 2024-06-14 18:01:26 UTC Tests are running...
🔴 2024-06-14 19:54:01 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15404 15310 0 27 58 9

Enjection
Enjection approved these changes Jun 16, 2024
View reviewed changes
ydb/core/tx/replication/service/worker.cpp
sFunc(TEvents::TEvPoison, PassAway);
}
}

private:
static constexpr ui32 MaxAttempts = 3;
static constexpr TDuration LagReportInterval = TDuration::Seconds(7);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему 7? Может стоит хотя бы в отдельный config.h вынести?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чтобы в среднем было 10.

@CyberROFL CyberROFL merged commit 79ef89b into ydb-platform:main Jun 17, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the replication-lag branch June 17, 2024 09:13
This was referenced Jun 18, 2024
Merged
Merged
Merged
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jun 20, 2024
@CyberROFL
Report & show replication lag (ydb-platform#5578)
431159f
CyberROFL added a commit that referenced this pull request Jun 20, 2024
@CyberROFL
Report & show replication lag (#5578) (#5806)
a3bc9a0
This was referenced Jun 23, 2024
Merged
Merged
Merged
@CyberROFL CyberROFL mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enjection Enjection Enjection approved these changes

Assignees

@CyberROFL CyberROFL

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberROFL @Enjection