Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIKIMR-20321 viewer tests asan fix #525

Merged
merged 11 commits into from
Dec 21, 2023

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Dec 15, 2023

https://st.yandex-team.ru/KIKIMR-20321
Modifications have been made to the TServerSetting class: AppConfig has been updated to a shared_ptr type. Since AppConfig is incorporated into KikimrRunConfig, this change resolves the issue previously encountered during the copying of TServerSetting instances

Copy link

github-actions bot commented Dec 15, 2023

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: some tests FAILED for commit 824f76d.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15609 15452 0 25 102 30

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 824f76d.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59393 50208 0 13 9134 38

@StekPerepolnen StekPerepolnen changed the title KIKIMR-20231/asan-fix KIKIMR-20231 viewer tests asan fix Dec 19, 2023
@StekPerepolnen StekPerepolnen self-assigned this Dec 19, 2023
@StekPerepolnen StekPerepolnen marked this pull request as ready for review December 20, 2023 07:00
@StekPerepolnen
Copy link
Collaborator Author

switching method calls from . to ->, which led to some test failures

@StekPerepolnen
Copy link
Collaborator Author

rebase

@StekPerepolnen StekPerepolnen changed the title KIKIMR-20231 viewer tests asan fix KIKIMR-20321 viewer tests asan fix Dec 21, 2023
@StekPerepolnen StekPerepolnen merged commit 5167ea1 into ydb-platform:main Dec 21, 2023
@StekPerepolnen StekPerepolnen deleted the KIKIMR-20231/asan-fix branch December 21, 2023 16:03
marsaly79 pushed a commit to marsaly79/ydb that referenced this pull request Dec 22, 2023
This was referenced Dec 29, 2023
Closed
This was referenced Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants