Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup #5241

Merged
merged 1 commit into from
Jun 5, 2024
Merged

cleanup #5241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ydb/core/fq/libs/common/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,18 +81,18 @@ NYql::TIssues RemoveDatabaseFromIssues(const NYql::TIssues& issues, const TStrin

template<typename TExecutable>
TMaybe<NYql::TIssues> GetIssuesFromYdbStatus(const TExecutable& executable, const NYdb::TAsyncStatus& future) {
bool success = true;
NYql::TIssues issues;
try {
auto status = future.GetValue();
if (status.IsSuccess()) {
return {};
}
NYql::TIssues issues;
issues.AddIssues(executable->Issues);
issues.AddIssues(executable->InternalIssues);
success = status.IsSuccess();
return issues;
} catch (...) {
success = false;
issues.AddIssue(CurrentExceptionMessage());
return NYql::TIssues{NYql::TIssue{CurrentExceptionMessage()}};
}
return success ? TMaybe<NYql::TIssues>{} : issues;
}

} // namespace NFq
Loading