Implement CREATE/DROP EXTERNAL DATA SOURCE/EXTERNAL TABLE in QueryService. Without IF NOT EXISTS/IF EXISTS support yet #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit eedc64d.
🔴 linux-x86_64-release-asan: some tests FAILED for commit eedc64d.
|
UgnineSirdis
force-pushed
the
external-table-ddl
branch
from
6d5a6a3 to
fbe2369
Compare
UgnineSirdis
requested review from
gridnevvvit and
VPolka
and removed request for
gridnevvvit
VPolka
reviewed
Dec 18, 2023
UgnineSirdis
force-pushed
the
external-table-ddl
branch
2 times, most recently
from
974cf34 to
d9847d6
Compare
VPolka
reviewed
Dec 19, 2023
| ydb/core/kqp/gateway/behaviour/tablestore | ||
| ydb/core/kqp/gateway/behaviour/table | ||
| ydb/core/kqp/gateway/behaviour/external_data_source | ||
| ydb/core/kqp/gateway/utils |
VPolka
reviewed
Dec 19, 2023
| return MakeFuture(result); | ||
| } else { | ||
| return Gateway->DropExternalTable(cluster, settings); | ||
| } | ||
| FORWARD_ENSURE_NO_PREPARE(DropExternalTable, cluster, settings); |
VPolka
approved these changes
Dec 19, 2023
UgnineSirdis
force-pushed
the
external-table-ddl
branch
from
d9847d6 to
2bb1f9c
Compare
…vice. Without IF NOT EXISTS/IF EXISTS support yet
UgnineSirdis
force-pushed
the
external-table-ddl
branch
from
2bb1f9c to
eedc64d
Compare
This was referenced Dec 21, 2023
Merged
This was referenced Dec 28, 2023
This was referenced Dec 29, 2023
This was referenced Dec 29, 2023
Closed
Closed
Merged
This was referenced Jan 17, 2024
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CREATE/DROP EXTERNAL DATA SOURCE/EXTERNAL TABLE in QueryService. Without IF NOT EXISTS/IF EXISTS support yet.
Also a common mechanism for working with objects is implemented through
IClassBehaviour::TFactory. It can be used for all types of objects in SQL