Merge CostMetrics changes from main #5221

serbel324 · 2024-06-05T12:03:28Z

Add cost estimator for SSD (Add cost estimator for SSD #1480)
Reintroduce light indicator for bursts to BsCostModel, Сделать лампочку в VDisk'е, которая будет загораться на микроберстах #1336 (Reintroduce light indicator for bursts to BsCostModel, #1336 #1477)
Adjust cost bucket capacity dynamically (Adjust cost bucket capacity dynamically #1681)
Fix burst tests, adjust cost bucket inflow dynamically (Fix burst tests, adjust cost bucket inflow dynamically #1778)
Pass VDisk burst threshold in config, fix TBucketQuoter bug (Pass VDisk burst threshold in config, fix TBucketQuoter bug #2165)
Add DiskTimeAvailable scaling option to BlobStorage configuration, improve burst threshold configuration (Add DiskTimeAvailable scaling option to BlobStorage configuration, improve burst threshold configuration #2530)
Improve cost metrics configuration (Improve cost metrics configuration #5045)
Fix config.proto

(ydb-platform#1477) * Move TLight to core/util, add BurstDetector to TBsCostTracker * Add UT * Count PDisk responses, fix UT build * Update BurstDetector * Fix UT * Move TLight to core/util, add BurstDetector to TBsCostTracker * Add UT * Count PDisk responses, fix UT build * Update BurstDetector * Fix UT * Fix BurstDetection UT * Fix rounding in conversion from Ns to Us in PDisk mock device settings * Update sector map performance parameters * Fix UT (once again) * Revert removing patch CostModel tests * Convert seek time from Ns to Us correctly * Update muted_ya.txt

* Adjust cost bucket capacity dynamically * ui32 for BlobSize

…1778)

…form#2165)

…prove burst threshold configuration (ydb-platform#2530)

github-actions · 2024-06-06T09:20:22Z

⚪ 2024-06-06 09:20:22 UTC Pre-commit check for 21448f2 has started.
⚪ 2024-06-06 09:20:24 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-06 10:10:46 UTC Build failed. see the build logs.
⚪ 2024-06-06 10:11:03 UTC Tests are running...
🔴 2024-06-06 10:36:00 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
7224	6922	0	286	2	14

github-actions · 2024-06-06T09:20:32Z

⚪ 2024-06-06 09:20:32 UTC Pre-commit check for 21448f2 has started.
⚪ 2024-06-06 09:20:35 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-06 10:12:21 UTC Build failed. see the build logs.
⚪ 2024-06-06 10:12:37 UTC Tests are running...
🔴 2024-06-06 10:50:15 UTC Test run completed, no test results found for commit 22e9603. Please check build logs.
⚫ 2024-06-06 10:50:19 UTC Check cancelled

github-actions · 2024-06-06T10:51:35Z

⚫ 2024-06-06 10:51:35 UTC Check cancelled

github-actions · 2024-06-06T10:51:36Z

⚫ 2024-06-06 10:51:35 UTC Check cancelled

github-actions · 2024-06-06T10:52:40Z

⚪ 2024-06-06 10:52:39 UTC Pre-commit check for 10162d6 has started.
⚪ 2024-06-06 10:52:42 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-06-06 11:36:58 UTC Check cancelled

github-actions · 2024-06-06T10:52:55Z

⚪ 2024-06-06 10:52:55 UTC Pre-commit check for 10162d6 has started.
⚪ 2024-06-06 10:52:58 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-06 11:31:38 UTC Build failed. see the build logs.
⚪ 2024-06-06 11:31:54 UTC Tests are running...
🔴 2024-06-06 11:37:00 UTC Test run completed, no test results found for commit 33bdad7. Please check build logs.
⚫ 2024-06-06 11:37:03 UTC Check cancelled

github-actions · 2024-06-06T11:46:45Z

⚪ 2024-06-06 11:46:44 UTC Pre-commit check for a447963 has started.
⚪ 2024-06-06 11:46:47 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-06 12:31:36 UTC Build failed. see the build logs.
⚪ 2024-06-06 12:31:47 UTC Tests are running...
🔴 2024-06-06 12:56:48 UTC Test run completed, no test results found for commit fedec87. Please check build logs.
⚫ 2024-06-06 12:56:52 UTC Check cancelled

github-actions · 2024-06-06T11:47:38Z

⚪ 2024-06-06 11:47:38 UTC Pre-commit check for a447963 has started.
⚪ 2024-06-06 11:47:40 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-06 12:30:37 UTC Build failed. see the build logs.
⚪ 2024-06-06 12:30:47 UTC Tests are running...
🔴 2024-06-06 12:56:49 UTC Test run completed, no test results found for commit fedec87. Please check build logs.
⚫ 2024-06-06 12:56:53 UTC Check cancelled

github-actions · 2024-06-06T13:14:42Z

⚪ 2024-06-06 13:14:42 UTC Pre-commit check for b6708dd has started.
⚪ 2024-06-06 13:14:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-06 13:48:03 UTC Build successful.
⚪ 2024-06-06 13:48:13 UTC Tests are running...
🔴 2024-06-06 14:29:41 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
52020	42273	0	387	9314	46

github-actions · 2024-06-06T13:32:13Z

⚪ 2024-06-06 13:32:13 UTC Pre-commit check for b6708dd has started.
⚪ 2024-06-06 13:32:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-06 14:16:45 UTC Build successful.
⚪ 2024-06-06 14:16:57 UTC Tests are running...
🔴 2024-06-06 14:47:56 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
8030	7626	0	387	4	13

github-actions · 2024-06-07T12:26:21Z

⚪ 2024-06-07 12:26:21 UTC Pre-commit check for d406730 has started.
⚪ 2024-06-07 12:26:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-07 12:55:41 UTC Build successful.
⚪ 2024-06-07 12:55:58 UTC Tests are running...
🔴 2024-06-07 13:41:42 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
52020	42432	0	229	9314	45

github-actions · 2024-06-07T12:26:31Z

⚪ 2024-06-07 12:26:31 UTC Pre-commit check for d406730 has started.
⚪ 2024-06-07 12:26:33 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-07 13:04:18 UTC Build successful.
⚪ 2024-06-07 13:04:33 UTC Tests are running...
🔴 2024-06-07 13:32:50 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
8030	7783	0	229	7	11

github-actions · 2024-06-10T09:55:48Z

⚪ 2024-06-10 09:55:48 UTC Pre-commit check for 18c5823 has started.
⚪ 2024-06-10 09:55:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-10 10:37:29 UTC Build successful.
⚪ 2024-06-10 10:37:37 UTC Tests are running...
🔴 2024-06-10 12:05:46 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60443	48498	0	2333	9342	270

github-actions · 2024-06-10T09:57:13Z

⚪ 2024-06-10 09:57:12 UTC Pre-commit check for 18c5823 has started.
⚪ 2024-06-10 09:57:15 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-10 10:34:15 UTC Build successful.
⚪ 2024-06-10 10:34:26 UTC Tests are running...
🔴 2024-06-10 12:07:52 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16102	13320	0	2496	24	262

github-actions · 2024-06-10T22:19:45Z

⚪ 2024-06-10 22:19:44 UTC Pre-commit check for ea5dd5f has started.
⚪ 2024-06-10 22:19:47 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-10 23:10:15 UTC Build failed. see the build logs.
⚪ 2024-06-10 23:10:28 UTC Tests are running...
🔴 2024-06-11 01:01:02 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15942	15794	0	20	98	30

github-actions · 2024-06-10T22:19:46Z

⚪ 2024-06-10 22:19:45 UTC Pre-commit check for ea5dd5f has started.
⚪ 2024-06-10 22:19:48 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-10 23:05:23 UTC Build failed. see the build logs.
⚪ 2024-06-10 23:05:37 UTC Tests are running...
🔴 2024-06-11 00:42:42 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60276	50870	0	2	9345	59

github-actions · 2024-06-11T09:08:43Z

⚪ 2024-06-11 09:08:42 UTC Pre-commit check for 736d4f3 has started.
⚪ 2024-06-11 09:08:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-11 09:51:38 UTC Build successful.
⚪ 2024-06-11 09:51:54 UTC Tests are running...
🔴 2024-06-11 11:50:57 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
60447	51046	0	1	9342	58

github-actions · 2024-06-11T09:08:50Z

⚪ 2024-06-11 09:08:49 UTC Pre-commit check for 736d4f3 has started.
⚪ 2024-06-11 09:08:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-11 09:46:55 UTC Build successful.
⚪ 2024-06-11 09:47:10 UTC Tests are running...
🔴 2024-06-11 11:32:25 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
16107	16024	0	16	44	23

serbel324 added 8 commits June 5, 2024 11:01

Add cost estimator for SSD (ydb-platform#1480)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

Loading
Loading status checks…

f20e984

Adjust cost bucket capacity dynamically (ydb-platform#1681)

da66c07

* Adjust cost bucket capacity dynamically * ui32 for BlobSize

Fix burst tests, adjust cost bucket inflow dynamically (ydb-platform#…

9fe9ac6

…1778)

Pass VDisk burst threshold in config, fix TBucketQuoter bug (ydb-plat…

62005ad

…form#2165)

Add DiskTimeAvailable scaling option to BlobStorage configuration, im…

6f8e7c9

…prove burst threshold configuration (ydb-platform#2530)

Improve cost metrics configuration (ydb-platform#5045)

36b2aee

Fix config.proto

274a79d

serbel324 requested a review from a team as a code owner June 5, 2024 12:03

Fix merge mistake

ec12265

serbel324 force-pushed the merge/24-1/cost-metrics branch from d64f2e2 to ec12265 Compare June 5, 2024 12:08

Return DskUsedBytes metrics (ydb-platform#4196)

f0fac15

serbel324 force-pushed the merge/24-1/cost-metrics branch from af1e7e4 to f0fac15 Compare June 5, 2024 13:21

serbel324 added 2 commits June 6, 2024 12:16

Merge branch 'stable-24-1' into merge/24-1/cost-metrics

57951d1

Update config.proto

22e9603

serbel324 added 3 commits June 6, 2024 13:49

Update node_warden_impl.cpp

ff22142

Update node_warden_impl.h

f94d91d

Update node_warden_vdisk.cpp

33bdad7

Update blobstorage_cost_tracker.cpp

fedec87

Update monitoring.cpp

2c57836

Fix merge mistake

7bc079c

serbel324 linked an issue Jun 7, 2024 that may be closed by this pull request

Merge CostMetrics into 24-1 #5318

Closed

Fix PEERDIR

9ae4fe7

serbel324 added 2 commits June 10, 2024 17:21

Reintroduce test_helpers for ut_blobstorage (ydb-platform#1890)

0c0c243

Improve some headers (ydb-platform#1877)

b89f7f3

Initialize ICB in testlib properly, fix Burst UT

4268d97

serbel324 force-pushed the merge/24-1/cost-metrics branch from daf59d0 to 4268d97 Compare June 11, 2024 09:05

alexvru approved these changes Jun 11, 2024

View reviewed changes

fomichev3000 approved these changes Jun 11, 2024

View reviewed changes

serbel324 merged commit 0224081 into ydb-platform:stable-24-1 Jun 11, 2024
2 of 4 checks passed

CyberROFL mentioned this pull request Jul 12, 2024

24-2: Fix bugs in: change exchange split, removing schema snapshots & emitting of resolved timestamps #6614

Closed

GrigoriyPA mentioned this pull request Jul 15, 2024

KqpRun sync stable version with main #6670

Closed

StekPerepolnen mentioned this pull request Aug 23, 2024

merge/stable 24 2/query float test asan #8196

Closed

GrigoriyPA mentioned this pull request Sep 26, 2024

YQ-3684 fix screts not found error handling #9822

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge CostMetrics changes from main #5221

Merge CostMetrics changes from main #5221

serbel324 commented Jun 5, 2024

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

Merge CostMetrics changes from main #5221

Merge CostMetrics changes from main #5221

Conversation

serbel324 commented Jun 5, 2024

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 • edited Loading

github-actions bot commented Jun 7, 2024 • edited Loading

github-actions bot commented Jun 7, 2024 • edited Loading

github-actions bot commented Jun 10, 2024 • edited Loading

github-actions bot commented Jun 10, 2024 • edited Loading

github-actions bot commented Jun 10, 2024 • edited Loading

github-actions bot commented Jun 10, 2024 • edited Loading

github-actions bot commented Jun 11, 2024 • edited Loading

github-actions bot commented Jun 11, 2024 • edited Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024 •

edited

Loading

github-actions bot commented Jun 7, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 11, 2024 •

edited

Loading