Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIKIMR-20081: add grant/revoke permissions to query service #522

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

VPolka
Copy link
Collaborator

@VPolka VPolka commented Dec 15, 2023

No description provided.

Copy link

github-actions bot commented Dec 15, 2023

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: some tests FAILED for commit 9403e3b.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14082 13960 0 40 74 8

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 9403e3b.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
56809 48022 0 27 8756 4

@VPolka VPolka changed the title KIKIMR-20081: add grant/revore permissions to query service KIKIMR-20081: add grant/revoke permissions to query service Dec 20, 2023
ydb/core/kqp/host/kqp_gateway_proxy.cpp Outdated Show resolved Hide resolved
ydb/core/kqp/gateway/utils/scheme_helpers.cpp Outdated Show resolved Hide resolved
ydb/core/kqp/host/kqp_gateway_proxy.cpp Outdated Show resolved Hide resolved
ydb/core/kqp/host/kqp_gateway_proxy.cpp Outdated Show resolved Hide resolved
ydb/core/kqp/ut/service/kqp_qs_queries_ut.cpp Show resolved Hide resolved
)", TTxControl::NoTx()).ExtractValueSync();
UNIT_ASSERT_VALUES_EQUAL_C(result.GetStatus(), EStatus::GENERIC_ERROR, result.GetIssues().ToString());
UNIT_ASSERT_STRING_CONTAINS(result.GetIssues().ToString(), "Unexpected token 'ROW'");
checkPermissions(session, {{.Path = "/Root", .Permissions = {}}});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why empty?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is wrong requests and after them I expect that there aren't any permissions

@VPolka VPolka merged commit adc4da7 into ydb-platform:main Dec 20, 2023
2 of 4 checks passed
@jepett0 jepett0 mentioned this pull request Dec 28, 2023
This was referenced Dec 29, 2023
Closed
This was referenced Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants