Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cross join from grace join and add assert (crossjoin must be processed in optimizers) #5212

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Remove cross join from grace join and add assert (crossjoin must be processed in optimizers) #5212

merged 1 commit into from
Jun 5, 2024

Conversation

lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented Jun 5, 2024 •
edited
Loading

Changelog entry

Added assert in gracejoin to check if join type is not CrossJoin. CrossJoin must be processed in optimizers.
...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner June 5, 2024 10:17
@lll-phill-lll lll-phill-lll changed the title YQL-18500 remove cross join from grace join and add assert (crossjoin… remove cross join from grace join and add assert (crossjoin… Jun 5, 2024
@lll-phill-lll lll-phill-lll changed the title remove cross join from grace join and add assert (crossjoin… remove cross join from grace join and add assert (crossjoin must be processed in optimizers) Jun 5, 2024
@lll-phill-lll lll-phill-lll changed the title remove cross join from grace join and add assert (crossjoin must be processed in optimizers) Remove cross join from grace join and add assert (crossjoin must be processed in optimizers) Jun 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

⚪ 2024-06-05 10:20:36 UTC Pre-commit check for 74b4ace has started.
⚪ 2024-06-05 10:23:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-05 10:25:58 UTC Build successful.
⚪ 2024-06-05 10:26:13 UTC Tests are running...
🔴 2024-06-05 12:25:57 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11883 11787 0 36 53 7

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

⚪ 2024-06-05 10:20:41 UTC Pre-commit check for 74b4ace has started.
⚪ 2024-06-05 10:23:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-05 10:26:47 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024 •
edited
Loading

⚪ 2024-06-05 10:20:52 UTC Pre-commit check for 74b4ace has started.
⚪ 2024-06-05 10:23:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-05 10:26:43 UTC Build successful.
⚪ 2024-06-05 10:26:55 UTC Tests are running...
🔴 2024-06-05 12:21:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71184 58418 0 5 12755 6

@lll-phill-lll lll-phill-lll merged commit 03bfbd6 into ydb-platform:main Jun 5, 2024
14 of 18 checks passed
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 13, 2024
Merged
This was referenced Jun 14, 2024
Merged
Merged
This was referenced Jun 15, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 18, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Merged
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darych Darych Darych approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lll-phill-lll @Darych