Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zstd has been fixed #5187

Merged
merged 3 commits into from
Jun 5, 2024
Merged

zstd has been fixed #5187

merged 3 commits into from
Jun 5, 2024

Conversation

dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Jun 4, 2024

Changelog entry

zstd has been fixed

Changelog category

  • Bugfix

Additional information

...

@dorooleg dorooleg requested a review from a team as a code owner June 4, 2024 19:33
@github-actions github-actions bot added the bugfix label Jun 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 19:36:22 UTC Pre-commit check for b68ebac has started.
⚪ 2024-06-04 19:38:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-04 19:40:26 UTC Build successful.
⚪ 2024-06-04 19:40:44 UTC Tests are running...
🔴 2024-06-04 19:51:15 UTC Test run completed, no test results found for commit cbd00fa. Please check build logs.
⚫ 2024-06-04 19:51:50 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 19:36:29 UTC Pre-commit check for b68ebac has started.
⚪ 2024-06-04 19:39:01 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-04 19:41:24 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 19:38:29 UTC Pre-commit check for b68ebac has started.
⚪ 2024-06-04 19:40:59 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-04 19:42:48 UTC Build successful.
⚪ 2024-06-04 19:43:02 UTC Tests are running...
🔴 2024-06-04 19:51:15 UTC Test run completed, no test results found for commit cbd00fa. Please check build logs.
⚫ 2024-06-04 19:51:30 UTC Check cancelled

@uzhastik
Copy link
Collaborator

uzhastik commented Jun 4, 2024

Тестом покрыть можно?

uzhastik
uzhastik reviewed Jun 4, 2024
View reviewed changes
ydb/library/yql/providers/s3/compressors/zstd.h Outdated
@@ -20,6 +20,7 @@ class TReadBuffer : public NDB::ReadBuffer {
std::vector<char> InBuffer, OutBuffer;
::ZSTD_DStream *const ZCtx_;
size_t Offset_;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай лишний пробел удалим

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 19:55:34 UTC Pre-commit check for 2109a27 has started.
⚪ 2024-06-04 19:58:08 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-04 20:40:34 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 19:57:57 UTC Pre-commit check for 2109a27 has started.
⚪ 2024-06-04 20:00:32 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-04 20:32:45 UTC Build successful.
⚪ 2024-06-04 20:33:02 UTC Tests are running...
🔴 2024-06-04 21:01:16 UTC Test run completed, no test results found for commit bc6e977. Please check build logs.
⚫ 2024-06-04 21:01:33 UTC Check cancelled

@dorooleg
Copy link
Collaborator Author

dorooleg commented Jun 4, 2024

Тестом покрыть можно?

Нужно файлик разумного размера подбирать чтобы сработал этот случай. Сейчас на стенде 5 gib файл сжался в 512 kib. В тест его не вариант закидывать

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 20:01:26 UTC Pre-commit check for 2109a27 has started.
⚪ 2024-06-04 20:04:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-04 20:30:19 UTC Build successful.
⚪ 2024-06-04 20:30:33 UTC Tests are running...
🔴 2024-06-04 21:01:19 UTC Test run completed, no test results found for commit bc6e977. Please check build logs.
⚫ 2024-06-04 21:01:34 UTC Check cancelled

@uzhastik
Copy link
Collaborator

uzhastik commented Jun 4, 2024

Тестом покрыть можно?

Нужно файлик разумного размера подбирать чтобы сработал этот случай. Сейчас на стенде 5 gib файл сжался в 512 kib. В тест его не вариант закидывать

Можно юнит тест написать, который сформирует архив и нашей либой попробует разжать

uzhastik
uzhastik previously approved these changes Jun 4, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 21:03:00 UTC Pre-commit check for 23a1f73 has started.
⚪ 2024-06-04 21:05:32 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-04 21:08:29 UTC Build successful.
⚪ 2024-06-04 21:08:38 UTC Tests are running...
🔴 2024-06-04 23:03:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9516 9469 0 16 23 8

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 21:05:05 UTC Pre-commit check for 23a1f73 has started.
⚪ 2024-06-04 21:07:40 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-04 21:08:56 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

⚪ 2024-06-04 21:05:21 UTC Pre-commit check for 23a1f73 has started.
⚪ 2024-06-04 21:07:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-04 21:08:59 UTC Build successful.
⚪ 2024-06-04 21:09:12 UTC Tests are running...
🔴 2024-06-04 22:45:01 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36979 32170 0 4 4799 6

@dorooleg dorooleg merged commit 8395ad6 into ydb-platform:main Jun 5, 2024
8 of 12 checks passed
dorooleg added a commit to dorooleg/ydb that referenced this pull request Jun 5, 2024
@dorooleg
zstd has been fixed (ydb-platform#5187)
ad8d3af
dorooleg added a commit to dorooleg/ydb that referenced this pull request Jun 5, 2024
@dorooleg
zstd has been fixed (ydb-platform#5187)
0938eec
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 13, 2024
Merged
This was referenced Jun 14, 2024
Merged
Merged
This was referenced Jun 15, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 18, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Merged
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorooleg @uzhastik