Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http_proxy): actually perform DNS resolution when entry is stale #5139

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

Jorres
Copy link
Collaborator

@Jorres Jorres commented Jun 3, 2024

Changelog entry

  • fixed: http_proxy actor performed DNS resolution effectively only once upon startup for each FQDN

Changelog category

  • Bugfix

Additional information

Now, http_proxy actor performs DNS resolution whenever the host FQDN is not found in local cache, as well as when the entry is stale in the local cache. If the DNS resolution fails for some reason, http_proxy actor tries to fallback to the stale entry in the local cache, if it exists. Only if this fallback fails as well, the error is returned.

@github-actions github-actions bot added the bugfix label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

2024-06-03 16:52:20 UTC Pre-commit check for 53111a8 has started.
2024-06-03 16:54:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-03 16:58:25 UTC Build successful.

Copy link

github-actions bot commented Jun 3, 2024

2024-06-03 16:52:41 UTC Pre-commit check for 53111a8 has started.
2024-06-03 16:55:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-03 16:57:17 UTC Build successful.
2024-06-03 16:57:31 UTC Tests are running...
🔴 2024-06-03 17:34:38 UTC Test run completed, no test results found for commit 7cdadfa. Please check build logs.
2024-06-03 17:35:03 UTC Check cancelled

Copy link

github-actions bot commented Jun 3, 2024

2024-06-03 16:52:54 UTC Pre-commit check for 53111a8 has started.
2024-06-03 16:55:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-03 16:57:27 UTC Build successful.
2024-06-03 16:57:41 UTC Tests are running...
🔴 2024-06-03 17:34:38 UTC Test run completed, no test results found for commit 7cdadfa. Please check build logs.
2024-06-03 17:34:53 UTC Check cancelled

Copy link

github-actions bot commented Jun 3, 2024

2024-06-03 17:38:35 UTC Pre-commit check for cf32453 has started.
2024-06-03 17:41:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-03 17:43:18 UTC Build successful.

Copy link

github-actions bot commented Jun 3, 2024

2024-06-03 17:38:44 UTC Pre-commit check for cf32453 has started.
2024-06-03 17:41:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-03 17:43:19 UTC Build successful.
2024-06-03 17:43:36 UTC Tests are running...
🔴 2024-06-03 19:20:13 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37093 32281 0 6 4801 5

Copy link

github-actions bot commented Jun 3, 2024

2024-06-03 17:38:46 UTC Pre-commit check for cf32453 has started.
2024-06-03 17:41:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-03 17:43:56 UTC Build successful.
2024-06-03 17:44:09 UTC Tests are running...
🔴 2024-06-03 19:36:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9503 9440 0 16 38 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants