Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yql 18490 get rid of HasRunningAsyncIoOperation in mkql_grace_join_imp #5051

Conversation

lll-phill-lll
Copy link
Member

@lll-phill-lll lll-phill-lll commented May 30, 2024

Changelog entry

Removing HasRunningAsyncIoOperation from mkql_grace_join_imp. Checking spiller state should be enough to yield
...

Changelog category

  • Improvement

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner May 30, 2024 17:03
Copy link

github-actions bot commented May 30, 2024

2024-05-30 17:04:17 UTC Pre-commit check for 6edef2e has started.
2024-05-30 17:06:46 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-30 17:09:55 UTC Build successful.

Copy link

github-actions bot commented May 30, 2024

2024-05-30 17:05:51 UTC Pre-commit check for 6edef2e has started.
2024-05-30 17:08:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-30 17:11:35 UTC Build successful.
2024-05-30 17:11:51 UTC Tests are running...
🔴 2024-05-30 17:50:20 UTC Test run completed, no test results found for commit 755dca1. Please check build logs.
2024-05-30 17:50:33 UTC Check cancelled

Copy link

github-actions bot commented May 30, 2024

2024-05-30 17:05:59 UTC Pre-commit check for 6edef2e has started.
2024-05-30 17:08:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-30 17:10:50 UTC Build successful.
2024-05-30 17:11:04 UTC Tests are running...
🔴 2024-05-30 17:50:14 UTC Test run completed, no test results found for commit 755dca1. Please check build logs.
2024-05-30 17:50:21 UTC Check cancelled

Copy link

github-actions bot commented May 30, 2024

2024-05-30 17:52:26 UTC Pre-commit check for f9bd4e0 has started.
2024-05-30 17:54:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-30 17:58:12 UTC Build successful.

Copy link

github-actions bot commented May 30, 2024

2024-05-30 17:54:08 UTC Pre-commit check for f9bd4e0 has started.
2024-05-30 17:56:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-30 17:59:38 UTC Build successful.
2024-05-30 17:59:53 UTC Tests are running...
🔴 2024-05-30 18:10:27 UTC Test run completed, no test results found for commit 73e9546. Please check build logs.
2024-05-30 18:10:46 UTC Check cancelled

Copy link

github-actions bot commented May 30, 2024

2024-05-30 17:54:15 UTC Pre-commit check for f9bd4e0 has started.
2024-05-30 17:56:57 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-30 18:00:22 UTC Build successful.
2024-05-30 18:00:40 UTC Tests are running...
🔴 2024-05-30 18:10:23 UTC Test run completed, no test results found for commit 73e9546. Please check build logs.
2024-05-30 18:10:39 UTC Check cancelled

@lll-phill-lll lll-phill-lll changed the title Yql 18490 get rid of has async operaion in gracejoin imp Yql 18490 get rid of HasRunningAsyncIoOperation in mkql_grace_join_imp May 30, 2024
Copy link

github-actions bot commented May 30, 2024

2024-05-30 18:14:56 UTC Pre-commit check for 67ec8a8 has started.
2024-05-30 18:17:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-30 18:20:48 UTC Build successful.

Copy link

github-actions bot commented May 30, 2024

2024-05-30 18:15:07 UTC Pre-commit check for 67ec8a8 has started.
2024-05-30 18:17:44 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-30 18:21:02 UTC Build successful.
2024-05-30 18:21:19 UTC Tests are running...
🔴 2024-05-30 20:07:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70889 58158 0 10 12712 9

Copy link

github-actions bot commented May 30, 2024

2024-05-30 18:15:23 UTC Pre-commit check for 67ec8a8 has started.
2024-05-30 18:17:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-30 18:20:49 UTC Build successful.
2024-05-30 18:21:05 UTC Tests are running...
🔴 2024-05-30 20:08:14 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11713 11573 0 54 75 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants