[dq] Fix the parallel precompute execution hangup in some cases #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
|
⚪
|
vitstn
approved these changes
May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
Merged
This was referenced Jun 11, 2024
Merged
This was referenced Jun 14, 2024
This was referenced Jun 15, 2024
Closed
Merged
This was referenced Jun 19, 2024
This was referenced Jun 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
The root cause of the hang-up is the common ExecState in the dq exec transformer. The completion of any precompute triggers multiple TAsyncTransformCallback execution for all running graphs with precomputes. The first graph executes TAsyncTransformCallback, creates new promise, and adds subscription for it. The subsequent TAsyncTransformCallback execution overrides the promise, and then the first graph has no chance to report completion.
This fix keeps the common ExecState for all precomputes, but uses separate futures for each precompute node.
Changelog category
Additional information
...