Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix YQL-18475 #4937

Merged
merged 1 commit into from
May 31, 2024
Merged

Fix YQL-18475 #4937

merged 1 commit into from
May 31, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented May 28, 2024

ProcessSpilledData -> NextJoinedData -> HasMoreTuples -> iterates bucketId (refrerencing JoinTable1->CurrIterBucket) out of un-spilled data -> SIGSEGV in GetTupleData on access to empty/spilled TableBuckets[bucketNum].keyIntVals

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@yumkam
Fix YQL-18475
a33d1e2 
ProcessSpilledData -> NextJoinedData -> HasMoreTuples -> iterates
bucketId (refrerencing JoinTable1->CurrIterBucket) out of un-spilled
data -> SIGSEGV in GetTupleData on access to empty/spilled
TableBuckets[bucketNum].keyIntVals
@yumkam yumkam requested a review from lll-phill-lll May 28, 2024 13:32
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 13:34:03 UTC Pre-commit check for 49ecaa7 has started.
⚪ 2024-05-28 13:36:25 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-28 13:39:21 UTC Build successful.
⚪ 2024-05-28 13:39:32 UTC Tests are running...
🔴 2024-05-28 15:29:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70921 58209 0 2 12702 8

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 13:34:32 UTC Pre-commit check for 49ecaa7 has started.
⚪ 2024-05-28 13:37:05 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-28 13:40:23 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 13:34:54 UTC Pre-commit check for 49ecaa7 has started.
⚪ 2024-05-28 13:37:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-28 13:40:00 UTC Build successful.
⚪ 2024-05-28 13:40:09 UTC Tests are running...
🔴 2024-05-28 15:39:50 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11799 11683 0 39 60 17

@yumkam yumkam marked this pull request as ready for review May 29, 2024 07:46
@yumkam yumkam requested a review from a team as a code owner May 29, 2024 07:46
@aakulaga-ydb aakulaga-ydb merged commit 8c0f1bc into ydb-platform:main May 31, 2024
9 of 13 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request May 31, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 3, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 13, 2024
Merged
This was referenced Jun 14, 2024
Merged
Merged
This was referenced Jun 15, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 18, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Merged
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lll-phill-lll lll-phill-lll lll-phill-lll approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yumkam @lll-phill-lll @aakulaga-ydb