Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async (another mailbox) decoders + RawReadActor&Lister moved to separate files #4923

Merged
merged 3 commits into from
May 31, 2024
Merged

Async (another mailbox) decoders + RawReadActor&Lister moved to separate files #4923

merged 3 commits into from
May 31, 2024

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented May 28, 2024

No description provided.

@Hor911 Hor911 requested a review from a team as a code owner May 28, 2024 09:59
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 11:24:54 UTC Pre-commit check for fc9094d has started.
⚪ 2024-05-28 11:27:31 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-05-28 12:03:56 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 11:25:57 UTC Pre-commit check for fc9094d has started.
⚪ 2024-05-28 11:28:51 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-05-28 12:04:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 11:29:59 UTC Pre-commit check for fc9094d has started.
⚪ 2024-05-28 11:32:37 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-05-28 12:03:58 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 12:08:33 UTC Pre-commit check for 6ba1f66 has started.
⚪ 2024-05-28 12:11:12 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-28 12:13:46 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 12:08:57 UTC Pre-commit check for 6ba1f66 has started.
⚪ 2024-05-28 12:11:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-28 12:21:12 UTC Build successful.
⚪ 2024-05-28 12:21:22 UTC Tests are running...
🔴 2024-05-28 13:50:34 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38309 33508 0 9 4782 10

@Hor911 Hor911 changed the title Refactor S3 Reader to split huge file to parts and simplify development Async (another mailbox) decoders + RawReadActor&Lister moved to separate files May 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 12:10:55 UTC Pre-commit check for 6ba1f66 has started.
⚪ 2024-05-28 12:13:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-28 12:22:58 UTC Build successful.
⚪ 2024-05-28 12:23:10 UTC Tests are running...
🔴 2024-05-28 14:20:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10770 10691 0 36 29 14

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

⚪ 2024-05-30 08:33:03 UTC Pre-commit check for 0679185 has started.
⚪ 2024-05-30 08:35:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-30 09:18:03 UTC Build successful.
⚪ 2024-05-30 09:18:13 UTC Tests are running...
🔴 2024-05-30 10:47:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38283 33474 0 16 4788 5

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

⚪ 2024-05-30 08:36:47 UTC Pre-commit check for 0679185 has started.
⚪ 2024-05-30 08:39:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-30 09:17:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

⚪ 2024-05-30 08:48:59 UTC Pre-commit check for 0679185 has started.
⚪ 2024-05-30 08:51:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-30 09:34:50 UTC Build successful.
⚪ 2024-05-30 09:35:00 UTC Tests are running...
🔴 2024-05-30 11:15:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10725 10619 0 44 48 14

uzhastik
uzhastik reviewed May 31, 2024
View reviewed changes
ydb/library/yql/providers/s3/actors/ya.make
@@ -9,6 +9,7 @@ ADDINCL(
YQL_LAST_ABI_VERSION()

SRCS(
raw_read_actor.cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай сохраним конвенцию именования файлов в yql - используют префикс yql_

ydb/library/yql/providers/s3/actors/ya.make Show resolved Hide resolved
ydb/library/yql/providers/s3/common/ya.make
@@ -1,10 +1,23 @@
LIBRARY()

ADDINCL(
contrib/libs/poco/Foundation/include
ydb/library/yql/udfs/common/clickhouse/client/base
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

если тащишь clickhouse в либы, то нужно еще копипастить все дефайны типа CFLAGS. поэтому крайне нежелательно пиридириться на этот код, очень хрупко. сделай пр в аркадии для проверки билда под винду

@Hor911 Hor911 merged commit 0dab3a4 into ydb-platform:main May 31, 2024
8 of 12 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request May 31, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 3, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 13, 2024
Merged
This was referenced Jun 14, 2024
Merged
Merged
This was referenced Jun 15, 2024
Merged
Merged
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Jun 17, 2024
@Hor911 @dorooleg
Async (another mailbox) decoders + RawReadActor&Lister moved to separ…
6e77d66 
…ate files (ydb-platform#4923)
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 18, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Merged
Merged
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Jun 21, 2024
@Hor911 @dorooleg
Async (another mailbox) decoders + RawReadActor&Lister moved to separ…
bf3a069 
…ate files (ydb-platform#4923)
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik left review comments

@dorooleg dorooleg dorooleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hor911 @dorooleg @uzhastik