Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking 'PartitionWriterCacheActor` #4892

Merged
merged 1 commit into from
May 28, 2024
Merged

Leaking 'PartitionWriterCacheActor` #4892

merged 1 commit into from
May 28, 2024

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

The Die call was missing. As a result, the TPartitionWriterCacheActor destructor was not called

Changelog category

  • Bugfix

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner May 27, 2024 14:06
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 14:07:13 UTC Pre-commit check for 50f8bfc has started.
⚪ 2024-05-27 14:09:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-27 14:10:58 UTC Build successful.
⚪ 2024-05-27 14:11:09 UTC Tests are running...
🔴 2024-05-27 15:19:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13413 12091 0 11 1299 12

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 14:10:13 UTC Pre-commit check for 50f8bfc has started.
⚪ 2024-05-27 14:12:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-27 14:14:53 UTC Build successful.
⚪ 2024-05-27 14:15:06 UTC Tests are running...
🔴 2024-05-27 16:07:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9413 9360 0 19 23 11

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 14:10:15 UTC Pre-commit check for 50f8bfc has started.
⚪ 2024-05-27 14:12:45 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-27 14:14:27 UTC Build successful.

@Alek5andr-Kotov Alek5andr-Kotov merged commit 6149afe into ydb-platform:main May 28, 2024
9 of 13 checks passed
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request May 28, 2024
@Alek5andr-Kotov
Leaking 'PartitionWriterCacheActor` (ydb-platform#4892)
70cb67b
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request May 28, 2024
@Alek5andr-Kotov
Leaking 'PartitionWriterCacheActor` (ydb-platform#4892)
87d905f
Alek5andr-Kotov added a commit that referenced this pull request May 28, 2024
@Alek5andr-Kotov
Leaking 'TPartitionWriterCacheActor` (#4892) (#4911)
9315acb
Alek5andr-Kotov added a commit that referenced this pull request May 28, 2024
@Alek5andr-Kotov
Leaking 'PartitionWriterCacheActor` (#4892) (#4912)
e7f9bdd
@GrigoriyPA GrigoriyPA mentioned this pull request May 28, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
This was referenced Jun 7, 2024
Closed
Closed
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 14, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
@CyberROFL CyberROFL mentioned this pull request Jun 19, 2024
Closed
This was referenced Jun 23, 2024
Merged
Merged
Merged
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 30, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

@nshestakov nshestakov Awaiting requested review from nshestakov nshestakov is a code owner automatically assigned from ydb-platform/topics

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alek5andr-Kotov @alexnick88