Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-2651 use ChildPtr instead of ChildRef #488

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

zverevgeny
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Dec 7, 2023

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@alexv-smirnov alexv-smirnov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 22, 2023
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 22, 2023
@zverevgeny zverevgeny force-pushed the YQ-2651_refactor_childref branch from 11e8cd6 to 47a71a5 Compare December 25, 2023 14:23
@zverevgeny zverevgeny marked this pull request as draft December 25, 2023 14:28
@zverevgeny zverevgeny marked this pull request as ready for review December 25, 2023 14:29
@zverevgeny zverevgeny requested a review from rvu1024 December 26, 2023 14:13
Copy link
Member

@rvu1024 rvu1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use raw Child(). TExprNode guarantees all not null children

@zverevgeny
Copy link
Collaborator Author

Use raw Child(). TExprNode guarantees all not null children

fixed

Copy link

github-actions bot commented Dec 26, 2023

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-release-asan: some tests FAILED for commit 7c0932f.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15631 15479 0 22 99 31

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 7c0932f.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59417 50236 0 15 9139 27

@zverevgeny zverevgeny merged commit f59afad into ydb-platform:main Dec 27, 2023
2 of 4 checks passed
@jepett0 jepett0 mentioned this pull request Dec 28, 2023
@StekPerepolnen StekPerepolnen mentioned this pull request Dec 29, 2023
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Dec 29, 2023
* YQ-2651 use ChildPtr instead of ChildRef
This was referenced Jan 3, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants