YQ-3157 enable batch script results by size #4860

GrigoriyPA · 2024-05-25T13:50:33Z

Changelog entry

Enable script result batching by size

Changelog category

Improvement

Additional information

github-actions · 2024-05-25T13:52:21Z

⚪ 2024-05-25 13:52:20 UTC Pre-commit check for 895d102 has started.
⚪ 2024-05-25 13:54:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-25 13:56:05 UTC Build successful.
⚪ 2024-05-25 13:56:18 UTC Tests are running...
🔴 2024-05-25 15:46:47 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9260	9198	0	20	26	16

github-actions · 2024-05-25T13:53:03Z

⚪ 2024-05-25 13:53:03 UTC Pre-commit check for 895d102 has started.
⚪ 2024-05-25 13:55:30 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-25 13:57:02 UTC Build successful.

github-actions · 2024-05-25T13:54:08Z

⚪ 2024-05-25 13:54:08 UTC Pre-commit check for 895d102 has started.
⚪ 2024-05-25 13:56:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-25 13:58:23 UTC Build successful.
⚪ 2024-05-25 13:58:38 UTC Tests are running...
🔴 2024-05-25 15:31:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
36606	31816	0	4	4779	7

dorooleg · 2024-05-28T09:52:43Z

ydb/core/fq/libs/compute/ydb/ydb_connector_actor.cpp

@@ -130,6 +130,7 @@ class TYdbConnectorActor : public NActors::TActorBootstrapped<TYdbConnectorActor
    void Handle(const TEvYdbCompute::TEvFetchScriptResultRequest::TPtr& ev) {
        NYdb::NQuery::TFetchScriptResultsSettings settings;
        settings.FetchToken(ev->Get()->FetchToken);
+        settings.RowsLimit(0);


Почему он в connector ушел? его нужно в result writer пропихивать

connector это общая компонента которая может в других местах использоваться

github-actions · 2024-05-28T10:56:27Z

⚪ 2024-05-28 10:56:27 UTC Pre-commit check for e98c40c has started.
⚫ 2024-05-28 10:58:06 UTC Check cancelled

github-actions · 2024-05-28T10:57:37Z

⚪ 2024-05-28 10:57:36 UTC Pre-commit check for e98c40c has started.
⚫ 2024-05-28 10:58:01 UTC Check cancelled

github-actions · 2024-05-28T11:02:53Z

⚪ 2024-05-28 11:02:53 UTC Pre-commit check for e1d0972 has started.
⚪ 2024-05-28 11:05:07 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-28 11:07:06 UTC Build failed. see the build logs.

github-actions · 2024-05-28T11:07:16Z

⚪ 2024-05-28 11:07:15 UTC Pre-commit check for e1d0972 has started.
⚪ 2024-05-28 11:10:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-28 11:12:46 UTC Build successful.
⚪ 2024-05-28 11:12:55 UTC Tests are running...
🔴 2024-05-28 13:02:17 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
9275	9203	0	19	29	24

github-actions · 2024-05-28T11:10:13Z

⚪ 2024-05-28 11:10:13 UTC Pre-commit check for e1d0972 has started.
⚪ 2024-05-28 11:12:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-28 11:14:43 UTC Build successful.
⚪ 2024-05-28 11:14:54 UTC Tests are running...
🔴 2024-05-28 12:42:51 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
36646	31853	0	2	4779	12

GrigoriyPA requested a review from a team as a code owner May 25, 2024 13:50

github-actions bot added new-feature improvement labels May 25, 2024

GrigoriyPA requested a review from dorooleg May 25, 2024 13:51

uzhastik previously approved these changes May 28, 2024

View reviewed changes

dorooleg reviewed May 28, 2024

View reviewed changes

GrigoriyPA dismissed uzhastik’s stale review via caf64cf May 28, 2024 10:49

GrigoriyPA requested a review from dorooleg May 28, 2024 10:49

dorooleg approved these changes May 28, 2024

View reviewed changes

GrigoriyPA added 2 commits May 28, 2024 10:57

Added zero rows limit

afd6be1

Passed rows limit from TResultSetWriterActor

ff97289

GrigoriyPA force-pushed the YQ-3157-enable-batch-script-results-by-size branch from caf64cf to ff97289 Compare May 28, 2024 10:57

GrigoriyPA merged commit 8bca55f into ydb-platform:main May 28, 2024
6 of 12 checks passed

GrigoriyPA deleted the YQ-3157-enable-batch-script-results-by-size branch May 28, 2024 14:10

GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request May 28, 2024

YQ-3157 enable batch script results by size (ydb-platform#4860)

c08a35f

niksaveliev mentioned this pull request May 29, 2024

Autoscaling logs #4976

Merged

This was referenced May 29, 2024

YQ-3292 fixed kqprun ResourceBrokerConfig passing #4994

Merged

Added ExecutionId for script execution logs #5014

Merged

niksaveliev mentioned this pull request May 30, 2024

Forbid autoscaling with size retention #5054

Merged

StekPerepolnen mentioned this pull request May 31, 2024

vdisk evict #5093

Merged

This was referenced Jun 6, 2024

Mute split by load ut #5264

Closed

Mute split by load ut #5267

Closed

This was referenced Jun 6, 2024

Mute split by load ut #5272

Merged

Fix build #5310

Merged

serbel324 mentioned this pull request Jun 7, 2024

Don't mark slow disks if there is only one #5340

Merged

niksaveliev mentioned this pull request Jun 10, 2024

Fix split by load ut #5383

Merged

This was referenced Jun 11, 2024

metadata cache keeps merged issues #5461

Merged

json_hc metadata cache #5465

Merged

json tenantinfo status metadata cache #5543

Merged

json query transaction mode #5574

Merged

niksaveliev mentioned this pull request Jun 17, 2024

Fix win build #5622

Closed

This was referenced Jun 19, 2024

hc api doc #5703

Merged

move time difference issue under database level #5859

Merged

metadata requests flags fix #5860

Merged

StekPerepolnen mentioned this pull request Jun 28, 2024

oidc-proxy new iam 2 #6059

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YQ-3157 enable batch script results by size #4860

YQ-3157 enable batch script results by size #4860

GrigoriyPA commented May 25, 2024 •

edited

Loading

github-actions bot commented May 25, 2024 •

edited

Loading

github-actions bot commented May 25, 2024 •

edited

Loading

github-actions bot commented May 25, 2024 •

edited

Loading

dorooleg May 28, 2024

dorooleg May 28, 2024

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

YQ-3157 enable batch script results by size #4860

YQ-3157 enable batch script results by size #4860

Conversation

GrigoriyPA commented May 25, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented May 25, 2024 • edited Loading

github-actions bot commented May 25, 2024 • edited Loading

github-actions bot commented May 25, 2024 • edited Loading

dorooleg May 28, 2024

Choose a reason for hiding this comment

dorooleg May 28, 2024

Choose a reason for hiding this comment

github-actions bot commented May 28, 2024 • edited Loading

github-actions bot commented May 28, 2024 • edited Loading

github-actions bot commented May 28, 2024 • edited Loading

github-actions bot commented May 28, 2024 • edited Loading

github-actions bot commented May 28, 2024 • edited Loading

GrigoriyPA commented May 25, 2024 •

edited

Loading

github-actions bot commented May 25, 2024 •

edited

Loading

github-actions bot commented May 25, 2024 •

edited

Loading

github-actions bot commented May 25, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading

github-actions bot commented May 28, 2024 •

edited

Loading