Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the race between TEvLockStatus and TEvProposeTransaction #4758

Merged
merged 20 commits into from
May 28, 2024

Conversation

Alek5andr-Kotov
Copy link
Collaborator

Changelog entry

The PQ tablet may lose the beginning of the data recorded in the transaction.

An auxiliary partition is created at the first message with a WriteId and is deleted either when the transaction completes or when a TEvLockStatus message arrives with a status other than STATUS_SUBSCRIBED. A situation may arise where the partition is deleted, and then the next message with the same WriteId will arrive and the recording will continue to another partition. As a result, the recorded data will be partially lost.

It is proposed to save a number in KQP for each partition in a transaction, and then send the accumulated number to TEvProposeTransaction. The identifier of the auxiliary partition can be used as such a number.

Changelog category

Bugfix

  • Not for changelog (changelog entry is not required)

Copy link

github-actions bot commented May 22, 2024

2024-05-22 15:15:20 UTC Pre-commit check for 50dce30 has started.
2024-05-22 15:15:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-22 15:55:55 UTC Build successful.
2024-05-22 15:57:34 UTC Tests are running...
🔴 2024-05-22 17:51:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10671 10602 0 32 23 14

Copy link

github-actions bot commented May 22, 2024

2024-05-22 15:16:23 UTC Pre-commit check for 50dce30 has started.
2024-05-22 15:16:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-22 15:55:20 UTC Build successful.

Copy link

github-actions bot commented May 22, 2024

2024-05-22 15:16:31 UTC Pre-commit check for 50dce30 has started.
2024-05-22 15:16:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-22 15:58:20 UTC Build successful.
2024-05-22 16:00:13 UTC Tests are running...
🔴 2024-05-22 17:36:54 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38129 33331 0 5 4785 8

Copy link

github-actions bot commented May 23, 2024

2024-05-23 07:40:13 UTC Pre-commit check for 03f6cbd has started.
2024-05-23 07:40:15 UTC Build linux-x86_64-release-clang14 is running...
2024-05-23 07:51:14 UTC Check cancelled

Copy link

github-actions bot commented May 23, 2024

2024-05-23 07:40:16 UTC Pre-commit check for 03f6cbd has started.
2024-05-23 07:40:18 UTC Build linux-x86_64-release-asan is running...
2024-05-23 07:51:12 UTC Check cancelled

Copy link

github-actions bot commented May 23, 2024

2024-05-23 07:40:16 UTC Pre-commit check for 03f6cbd has started.
2024-05-23 07:40:23 UTC Build linux-x86_64-relwithdebinfo is running...
2024-05-23 07:51:13 UTC Check cancelled

Copy link

github-actions bot commented May 23, 2024

2024-05-23 07:52:30 UTC Pre-commit check for c13b904 has started.
2024-05-23 07:52:31 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-23 08:22:20 UTC Build failed. see the build logs.

Copy link

github-actions bot commented May 23, 2024

2024-05-23 07:52:35 UTC Pre-commit check for c13b904 has started.
2024-05-23 07:52:36 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-23 08:25:31 UTC Build failed. see the build logs.
🔴 2024-05-23 08:27:05 UTC Tests run skipped.

Copy link

github-actions bot commented May 23, 2024

2024-05-23 07:54:42 UTC Pre-commit check for c13b904 has started.
2024-05-23 07:54:45 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-23 08:27:44 UTC Build failed. see the build logs.
🔴 2024-05-23 08:29:22 UTC Tests run skipped.

Copy link

github-actions bot commented May 23, 2024

2024-05-23 08:54:31 UTC Pre-commit check for 20979ef has started.
2024-05-23 08:54:33 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-23 09:14:08 UTC Build failed. see the build logs.

Copy link

github-actions bot commented May 23, 2024

2024-05-23 08:54:33 UTC Pre-commit check for 20979ef has started.
2024-05-23 08:54:36 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-23 09:09:37 UTC Build failed. see the build logs.
🔴 2024-05-23 09:11:10 UTC Tests run skipped.

Copy link

github-actions bot commented May 23, 2024

2024-05-23 08:54:46 UTC Pre-commit check for 20979ef has started.
2024-05-23 08:54:49 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-23 09:10:58 UTC Build failed. see the build logs.
🔴 2024-05-23 09:12:36 UTC Tests run skipped.

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner May 23, 2024 09:28
Copy link

github-actions bot commented May 23, 2024

2024-05-23 09:30:08 UTC Pre-commit check for ad94c9c has started.
2024-05-23 09:32:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 10:15:26 UTC Build successful.
2024-05-23 10:15:36 UTC Tests are running...
🔴 2024-05-23 12:12:57 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10836 10756 0 34 29 17

Copy link

github-actions bot commented May 23, 2024

2024-05-23 09:32:07 UTC Pre-commit check for ad94c9c has started.
2024-05-23 09:35:00 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 10:14:30 UTC Build successful.

Copy link

github-actions bot commented May 27, 2024

2024-05-27 14:45:20 UTC Pre-commit check for 7d1e304 has started.
2024-05-27 14:48:03 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-27 14:50:31 UTC Build failed. see the build logs.
🔴 2024-05-27 14:50:33 UTC Tests run skipped.

Copy link

github-actions bot commented May 27, 2024

2024-05-27 14:45:28 UTC Pre-commit check for 7d1e304 has started.
2024-05-27 14:48:15 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-27 14:51:56 UTC Build failed. see the build logs.
🔴 2024-05-27 14:51:58 UTC Tests run skipped.

Copy link

github-actions bot commented May 27, 2024

2024-05-27 14:46:30 UTC Pre-commit check for 7d1e304 has started.
2024-05-27 14:49:12 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-27 14:51:52 UTC Build failed. see the build logs.

Copy link

github-actions bot commented May 27, 2024

2024-05-27 15:15:58 UTC Pre-commit check for 9ff99ff has started.
2024-05-27 15:18:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-27 15:21:21 UTC Build successful.
2024-05-27 15:21:34 UTC Tests are running...
🔴 2024-05-27 17:23:26 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15214 15087 0 54 60 13

Copy link

github-actions bot commented May 27, 2024

2024-05-27 15:16:57 UTC Pre-commit check for 9ff99ff has started.
2024-05-27 15:19:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-27 15:21:59 UTC Build successful.
2024-05-27 15:22:12 UTC Tests are running...
🔴 2024-05-27 17:23:54 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74342 61609 0 13 12711 9

Copy link

github-actions bot commented May 27, 2024

2024-05-27 15:17:00 UTC Pre-commit check for 9ff99ff has started.
2024-05-27 15:20:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-27 15:22:44 UTC Build successful.

@Alek5andr-Kotov Alek5andr-Kotov merged commit 38281eb into ydb-platform:main May 28, 2024
8 of 12 checks passed
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants