Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4715

Merged
merged 1 commit into from
May 21, 2024
Merged

Always add 'u-' prefix to the dedicated YDB database endpoint during resolving #4715

merged 1 commit into from
May 21, 2024

Conversation

vitalyisaev2
Copy link
Member

@vitalyisaev2 vitalyisaev2 commented May 21, 2024 •
edited
Loading

@vitalyisaev2 vitalyisaev2 requested a review from a team as a code owner May 21, 2024 09:37
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 09:40:50 UTC Pre-commit check for 106359a has started.
⚪ 2024-05-21 09:40:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-21 10:21:16 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 09:41:01 UTC Pre-commit check for 106359a has started.
⚪ 2024-05-21 09:41:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-21 10:33:23 UTC Build successful.
⚪ 2024-05-21 10:35:06 UTC Tests are running...
🔴 2024-05-21 11:52:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
23021 21222 0 46 1734 19

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

⚪ 2024-05-21 09:41:03 UTC Pre-commit check for 106359a has started.
⚪ 2024-05-21 09:41:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-21 10:37:03 UTC Build successful.
⚪ 2024-05-21 10:38:45 UTC Tests are running...
🔴 2024-05-21 12:16:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8922 8787 0 25 26 84

dcherednik
dcherednik requested changes May 21, 2024
View reviewed changes
Copy link
Member

@dcherednik dcherednik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make an explanation about this patch. It looks like some yc specific logic. How does this code work outside Yandex?

@dcherednik dcherednik requested review from dcherednik and removed request for dcherednik May 21, 2024 17:02
dcherednik
dcherednik approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@dcherednik dcherednik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still do not understand why this code is in OSS. But if it ok for FQ - ok.

@vitalyisaev2 vitalyisaev2 merged commit 0a651a8 into ydb-platform:q-stable-ydb-24-1 May 21, 2024
3 of 5 checks passed
kardymonds pushed a commit to kardymonds/ydb that referenced this pull request Jun 10, 2024
@vitalyisaev2 @kardymonds
Always add 'u-' prefix to the dedicated YDB database endpoint during …
d16b7b6 
…resolving (ydb-platform#4715)
uzhastik pushed a commit to uzhastik/ydb that referenced this pull request Jun 20, 2024
@vitalyisaev2 @uzhastik
Always add 'u-' prefix to the dedicated YDB database endpoint during …
fc4a023 
…resolving (ydb-platform#4715)
uzhastik pushed a commit that referenced this pull request Jun 20, 2024
@vitalyisaev2 @uzhastik
Always add 'u-' prefix to the dedicated YDB database endpoint during …
707c31d 
…resolving (#4715)
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherednik dcherednik dcherednik approved these changes

@uzhastik uzhastik uzhastik approved these changes

@kardymonds kardymonds kardymonds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitalyisaev2 @dcherednik @uzhastik @kardymonds