Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix huge blob keeper FirstLsnToKeep logic #4697

Merged
merged 1 commit into from
May 20, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented May 20, 2024

Changelog entry

Fix huge blob keeper FirstLsnToKeep logic

Changelog category

  • Bugfix

Additional information

PendingWrites are now accounted too when calculating FirstLsnToKeep.

Copy link

github-actions bot commented May 20, 2024

2024-05-20 17:52:11 UTC Pre-commit check for bfc62a9 has started.
2024-05-20 17:52:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 17:57:09 UTC Build successful.
2024-05-20 17:58:59 UTC Tests are running...
🔴 2024-05-20 18:08:53 UTC Test run completed, no test results found for commit cc9e009. Please check build logs.
2024-05-20 18:09:27 UTC Check cancelled

Copy link

github-actions bot commented May 20, 2024

2024-05-20 17:52:18 UTC Pre-commit check for bfc62a9 has started.
2024-05-20 17:52:20 UTC Build linux-x86_64-release-clang14 is running...
2024-05-20 18:09:10 UTC Check cancelled

Copy link

github-actions bot commented May 20, 2024

2024-05-20 17:52:23 UTC Pre-commit check for bfc62a9 has started.
2024-05-20 17:52:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 17:57:37 UTC Build successful.
2024-05-20 17:59:19 UTC Tests are running...
🔴 2024-05-20 18:08:55 UTC Test run completed, no test results found for commit cc9e009. Please check build logs.
2024-05-20 18:09:20 UTC Check cancelled

@alexvru alexvru force-pushed the vdisk/fix-huge-keeper branch from cc9e009 to 2d6aa5f Compare May 20, 2024 18:08
Copy link

github-actions bot commented May 20, 2024

2024-05-20 18:13:02 UTC Pre-commit check for 9137b24 has started.
2024-05-20 18:13:05 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 18:36:29 UTC Build successful.

Copy link

github-actions bot commented May 20, 2024

2024-05-20 18:13:11 UTC Pre-commit check for 9137b24 has started.
2024-05-20 18:13:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 18:15:03 UTC Build successful.
2024-05-20 18:16:46 UTC Tests are running...
🔴 2024-05-20 19:44:02 UTC Test run completed, no test results found for commit 2d6aa5f. Please check build logs.
2024-05-20 19:44:23 UTC Check cancelled

Copy link

github-actions bot commented May 20, 2024

2024-05-20 18:13:18 UTC Pre-commit check for 9137b24 has started.
2024-05-20 18:13:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 18:15:03 UTC Build successful.
2024-05-20 18:16:47 UTC Tests are running...
🔴 2024-05-20 19:29:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13888 12577 0 4 1298 9

@alexvru alexvru force-pushed the vdisk/fix-huge-keeper branch from 2d6aa5f to 6f29486 Compare May 20, 2024 19:43
Copy link

github-actions bot commented May 20, 2024

2024-05-20 19:47:52 UTC Pre-commit check for 830bc23 has started.
2024-05-20 19:47:55 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-20 19:50:38 UTC Build successful.

Copy link

github-actions bot commented May 20, 2024

2024-05-20 19:47:56 UTC Pre-commit check for 830bc23 has started.
2024-05-20 19:47:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-20 19:51:07 UTC Build successful.
2024-05-20 19:52:56 UTC Tests are running...
🔴 2024-05-20 21:50:00 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9767 9696 0 26 27 18

Copy link

github-actions bot commented May 20, 2024

2024-05-20 19:47:58 UTC Pre-commit check for 830bc23 has started.
2024-05-20 19:48:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-20 19:50:59 UTC Build successful.
2024-05-20 19:52:48 UTC Tests are running...
🔴 2024-05-20 21:03:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13889 12542 0 13 1323 11

@alexvru alexvru merged commit 5fd6893 into ydb-platform:main May 20, 2024
3 of 5 checks passed
@alexvru alexvru deleted the vdisk/fix-huge-keeper branch May 20, 2024 20:57
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
This was referenced Jun 7, 2024
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants