Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow depending on entire build/ directory #4639

Merged
merged 1 commit into from
May 17, 2024
Merged

Allow depending on entire build/ directory #4639

merged 1 commit into from
May 17, 2024

Conversation

georgthegreat
Copy link
Contributor

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Needed for
https://a.yandex-team.ru/review/5916903/details

Also: deny arc/api/public dependency for good.

@georgthegreat
Allow depending on entire build/ directory
2993f67 
Needed for 
https://a.yandex-team.ru/review/5916903/details

Also: deny arc/api/public dependency for good.
@github-actions GitHub Actions
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@maximyurchuk maximyurchuk added the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 17, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

⚪ 2024-05-17 10:26:29 UTC Pre-commit check for 1fc53dc has started.
⚪ 2024-05-17 10:26:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-17 10:27:29 UTC Build successful.
⚪ 2024-05-17 10:28:54 UTC Tests are running...
🔴 2024-05-17 10:29:00 UTC Test run completed, no test results found for commit 2993f67. Please check build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

⚪ 2024-05-17 10:28:30 UTC Pre-commit check for 1fc53dc has started.
⚪ 2024-05-17 10:28:32 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-17 10:30:06 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

⚪ 2024-05-17 10:28:40 UTC Pre-commit check for 1fc53dc has started.
⚪ 2024-05-17 10:28:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-17 10:29:51 UTC Build successful.
⚪ 2024-05-17 10:31:27 UTC Tests are running...
🔴 2024-05-17 10:31:34 UTC Test run completed, no test results found for commit 2993f67. Please check build logs.

@maximyurchuk maximyurchuk self-requested a review May 17, 2024 10:44
@maximyurchuk maximyurchuk merged commit d7b2c12 into ydb-platform:main May 17, 2024
7 checks passed
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@georgthegreat @MrLolthe1st
Allow depending on entire build/ directory (ydb-platform#4639)
d480c5f
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
This was referenced May 30, 2024
Merged
Closed
Closed
Merged
This was referenced Jun 7, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees
No one assigned
Labels
external not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgthegreat @maximyurchuk