Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many sinks for olap & one sink for oltp #4600

Merged
merged 1 commit into from
May 17, 2024
Merged

many sinks for olap & one sink for oltp #4600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 54 additions & 23 deletions ydb/core/kqp/opt/kqp_opt_effects.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,37 +321,68 @@ bool BuildUpsertRowsEffect(const TKqlUpsertRows& node, TExprContext& ctx, const
auto input = program.Body();

if (sinkEffect) {
auto sink = Build<TDqSink>(ctx, node.Pos())
.DataSink<TKqpTableSink>()
.Category(ctx.NewAtom(node.Pos(), NYql::KqpTableSinkName))
.Cluster(ctx.NewAtom(node.Pos(), "db"))
.Build()
.Index().Value("0").Build()
.Settings<TKqpTableSinkSettings>()
.Table(node.Table())
.Columns(node.Columns())
.Settings()
.Build()
.Build()
.Done();

const auto rowArgument = Build<TCoArgument>(ctx, node.Pos())
.Name("row")
.Done();

stageInput = Build<TDqStage>(ctx, node.Pos())
.Inputs()
.Add(dqUnion)
.Build()
.Program()
.Args({rowArgument})
.Body<TCoToFlow>()
.Input(rowArgument)
if (table.Metadata->Kind == EKikimrTableKind::Olap) {
// OLAP is expected to write into all shards (hash partitioning),
// so we use serveral sinks for this without union all.
// (TODO: shuffle by shard instead of DqCnMap)

auto mapCn = Build<TDqCnMap>(ctx, node.Pos())
.Output(dqUnion.Output())
.Done();
stageInput = Build<TDqStage>(ctx, node.Pos())
.Inputs()
.Add(mapCn)
.Build()
.Build()
.Outputs<TDqStageOutputsList>()
.Add<TDqSink>()
.DataSink<TKqpTableSink>()
.Category(ctx.NewAtom(node.Pos(), NYql::KqpTableSinkName))
.Cluster(ctx.NewAtom(node.Pos(), "db"))
.Program()
.Args({rowArgument})
.Body<TCoToFlow>()
.Input(rowArgument)
.Build()
.Index().Value("0").Build()
.Settings<TKqpTableSinkSettings>()
.Table(node.Table())
.Columns(node.Columns())
.Settings()
.Build()
.Build()
.Outputs<TDqStageOutputsList>()
.Add(sink)
.Build()
.Settings().Build()
.Done();
} else {
// OLTP is expected to mostly use just few shards,
// so we use union all + one sink. It's important for write optimizations support.
// NOTE: OLTP large writes expected to fail anyway due to problems with locks/splits.

stageInput = Build<TDqStage>(ctx, node.Pos())
.Inputs()
.Add(dqUnion)
.Build()
.Program()
.Args({rowArgument})
.Body<TCoToFlow>()
.Input(rowArgument)
.Build()
.Build()
.Build()
.Settings().Build()
.Done();
.Outputs<TDqStageOutputsList>()
.Add(sink)
.Build()
.Settings().Build()
.Done();
}

effect = Build<TKqpSinkEffect>(ctx, node.Pos())
.Stage(stageInput.Cast().Ptr())
Expand Down
Loading