Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNIETFERRO-2059: Fix use-after-free error in the TDqExecuter #4568

Merged
merged 2 commits into from
May 31, 2024

Conversation

ubyte
Copy link
Contributor

@ubyte ubyte commented May 15, 2024

Changelog entry

Fix use-after-free error caused by constructing an input stream over a temporary string object

Changelog category

  • Bugfix

@ubyte ubyte requested a review from a team as a code owner May 15, 2024 17:13
Copy link

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@maximyurchuk maximyurchuk added the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 15, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label May 15, 2024
Copy link

github-actions bot commented May 15, 2024

2024-05-15 21:30:03 UTC Pre-commit check for 628eed4 has started.
2024-05-15 21:30:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-15 21:32:51 UTC Build successful.
2024-05-15 21:34:36 UTC Tests are running...
🔴 2024-05-15 23:16:35 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9383 9334 0 18 21 10

Copy link

github-actions bot commented May 15, 2024

2024-05-15 21:32:14 UTC Pre-commit check for 628eed4 has started.
2024-05-15 21:32:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-15 21:35:51 UTC Build successful.

Copy link

github-actions bot commented May 15, 2024

2024-05-15 21:34:28 UTC Pre-commit check for 628eed4 has started.
2024-05-15 21:34:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-15 21:37:48 UTC Build successful.
2024-05-15 21:39:44 UTC Tests are running...
🔴 2024-05-15 23:12:11 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
36598 31819 0 2 4771 6

@maximyurchuk
Copy link
Collaborator

@vitstn please, take a look

@maximyurchuk maximyurchuk requested a review from zverevgeny May 17, 2024 12:53
@ubyte ubyte force-pushed the fix-use-after-free-stream branch from 0f740e7 to 1196c3b Compare May 28, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants