Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default minHugeBlobSize to migrate the heap #4499

Merged
merged 1 commit into from
May 14, 2024
Merged

Use default minHugeBlobSize to migrate the heap #4499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ydb/core/blobstorage/vdisk/common/vdisk_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,9 @@ namespace NKikimr {
MinHugeBlobInBytes = 512u << 10u;
break;
}
// for compatibility reasons it must be 512KB
MilestoneHugeBlobInBytes = 512u << 10u;
OldMinHugeBlobInBytes = MinHugeBlobInBytes; // preserved to migrate entry point state correctly
MilestoneHugeBlobInBytes = 512u << 10u; // for compatibility reasons it must be 512KB

}

void TVDiskConfig::Merge(const NKikimrBlobStorage::TVDiskConfig &update) {
Expand Down
1 change: 1 addition & 0 deletions ydb/core/blobstorage/vdisk/common/vdisk_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ namespace NKikimr {
ui32 HullSstSizeInChunksLevel;
ui32 HugeBlobsFreeChunkReservation;
ui32 MinHugeBlobInBytes;
ui32 OldMinHugeBlobInBytes;
ui32 MilestoneHugeBlobInBytes;
ui32 HugeBlobOverhead;
ui32 HullCompLevel0MaxSstsAtOnce;
Expand Down
4 changes: 2 additions & 2 deletions ydb/core/blobstorage/vdisk/localrecovery/localrecovery_public.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ namespace NKikimr {
LocRecCtx->PDiskCtx->Dsk->ChunkSize,
LocRecCtx->PDiskCtx->Dsk->AppendBlockSize,
LocRecCtx->PDiskCtx->Dsk->AppendBlockSize,
Config->MinHugeBlobInBytes,
Config->OldMinHugeBlobInBytes,
Config->MilestoneHugeBlobInBytes,
Config->MaxLogoBlobDataSize,
Config->HugeBlobOverhead,
Expand All @@ -440,7 +440,7 @@ namespace NKikimr {
LocRecCtx->PDiskCtx->Dsk->ChunkSize,
LocRecCtx->PDiskCtx->Dsk->AppendBlockSize,
LocRecCtx->PDiskCtx->Dsk->AppendBlockSize,
Config->MinHugeBlobInBytes,
Config->OldMinHugeBlobInBytes,
Config->MilestoneHugeBlobInBytes,
Config->MaxLogoBlobDataSize,
Config->HugeBlobOverhead,
Expand Down
Loading