Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't erase first numerical character in sensor name in prometheus format #4226

Conversation

dvrazumov
Copy link
Contributor

@dvrazumov dvrazumov commented May 2, 2024

Changelog entry

In case if sensor name starts with numerical character it is not replaced by "_", but preceeded with "_"

...

Changelog category

  • Bugfix

Additional information

For now there is a problem while reporting metrics in prometheus format. Sensors with names "50" and "90" (used as percentiles names) both transform into the name "_0".

...

Copy link

github-actions bot commented May 2, 2024

2024-05-02 10:11:01 UTC Pre-commit check for 3ac6c2f has started.
2024-05-02 10:11:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-02 10:14:07 UTC Build successful.
2024-05-02 10:15:56 UTC Tests are running...
🔴 2024-05-02 12:08:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14213 14064 0 52 88 9

@github-actions github-actions bot added the bugfix label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

2024-05-02 10:12:40 UTC Pre-commit check for 3ac6c2f has started.
2024-05-02 10:12:41 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-02 10:15:38 UTC Build successful.

Copy link

github-actions bot commented May 2, 2024

2024-05-02 10:13:05 UTC Pre-commit check for 3ac6c2f has started.
2024-05-02 10:13:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-02 10:16:15 UTC Build successful.
2024-05-02 10:18:04 UTC Tests are running...
🔴 2024-05-02 12:14:49 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72892 59778 0 7 13100 7

ulya-sidorina
ulya-sidorina previously approved these changes May 2, 2024
Copy link

github-actions bot commented May 2, 2024

2024-05-02 13:25:14 UTC Pre-commit check for 2873a18 has started.
2024-05-02 13:25:17 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-02 13:26:22 UTC Build successful.

Copy link

github-actions bot commented May 2, 2024

2024-05-02 13:26:41 UTC Pre-commit check for 2873a18 has started.
2024-05-02 13:26:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-02 13:27:53 UTC Build successful.
2024-05-02 13:29:37 UTC Tests are running...
🔴 2024-05-02 15:19:49 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72901 59798 0 7 13088 8
2024-05-02 15:20:06 UTC Check cancelled

Copy link

github-actions bot commented May 2, 2024

2024-05-02 13:26:53 UTC Pre-commit check for 2873a18 has started.
2024-05-02 13:26:56 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-02 13:28:08 UTC Build successful.
2024-05-02 13:29:56 UTC Tests are running...
🔴 2024-05-02 15:19:46 UTC Test run completed, no test results found for commit 9504492. Please check build logs.
2024-05-02 15:19:49 UTC Check cancelled

@dvrazumov dvrazumov force-pushed the fix-numerical-sensors-in-prometheus-format branch from 9504492 to ec4d6ab Compare May 2, 2024 15:19
Copy link

github-actions bot commented May 2, 2024

2024-05-02 15:22:49 UTC Pre-commit check for ff684d1 has started.
2024-05-02 15:22:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-02 15:23:56 UTC Build successful.
2024-05-02 15:25:42 UTC Tests are running...
🔴 2024-05-02 17:12:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14219 14037 0 54 115 13

Copy link

github-actions bot commented May 2, 2024

2024-05-02 15:23:32 UTC Pre-commit check for ff684d1 has started.
2024-05-02 15:23:35 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-02 15:24:43 UTC Build successful.

Copy link

github-actions bot commented May 2, 2024

2024-05-02 15:23:38 UTC Pre-commit check for ff684d1 has started.
2024-05-02 15:23:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-02 15:24:50 UTC Build successful.
2024-05-02 15:26:36 UTC Tests are running...
🔴 2024-05-02 17:20:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72905 59798 0 8 13090 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants