Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update token interval calculation. #3064

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Fix update token interval calculation. #3064

merged 2 commits into from
Mar 22, 2024

Conversation

dcherednik
Copy link
Member

We should chouse min value from expiresIn and RefreshPeriod_, not max one

Changelog category

  • Bugfix

Additional information

...

@dcherednik
Fix update token interval calculation.
152db69 
We should chouse min value from expiresIn and RefreshPeriod_, not max one
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

⚪ 2024-03-21 17:03:47 UTC Pre-commit check for 75952cc has started.
⚪ 2024-03-21 17:03:49 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-21 17:30:29 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

⚪ 2024-03-21 17:03:48 UTC Pre-commit check for 75952cc has started.
⚪ 2024-03-21 17:03:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-21 17:15:24 UTC Build successful.
⚪ 2024-03-21 17:15:40 UTC Tests are running...
🔴 2024-03-21 17:49:57 UTC Test run completed, no test results found for commit 152db69. Please check build logs.
⚫ 2024-03-21 17:50:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

⚪ 2024-03-21 17:03:51 UTC Pre-commit check for 75952cc has started.
⚪ 2024-03-21 17:03:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-21 17:25:59 UTC Build successful.
⚪ 2024-03-21 17:26:17 UTC Tests are running...
🔴 2024-03-21 17:49:55 UTC Test run completed, no test results found for commit 152db69. Please check build logs.
⚫ 2024-03-21 17:49:58 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

⚪ 2024-03-21 17:53:08 UTC Pre-commit check for 1644f9a has started.
⚪ 2024-03-21 17:53:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-21 17:56:15 UTC Build successful.
⚪ 2024-03-21 17:56:30 UTC Tests are running...
🔴 2024-03-21 19:40:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68930 57839 0 4 11011 76

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

⚪ 2024-03-21 17:53:13 UTC Pre-commit check for 1644f9a has started.
⚪ 2024-03-21 17:53:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-21 17:54:37 UTC Build successful.
⚪ 2024-03-21 17:54:54 UTC Tests are running...
🔴 2024-03-21 19:54:31 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15133 14524 0 77 504 28

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

⚪ 2024-03-21 17:53:40 UTC Pre-commit check for 1644f9a has started.
⚪ 2024-03-21 17:53:42 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-21 17:57:01 UTC Build successful.

@dcherednik
Copy link
Member Author

We should chouse min value from expiresIn and RefreshPeriod_, not max one
Also reduce server returned interval by 2 to prevent race at expiring time.

@dcherednik dcherednik merged commit 431b71b into ydb-platform:main Mar 22, 2024
3 of 5 checks passed
@dcherednik dcherednik deleted the sdk_iam_fix branch March 22, 2024 10:29
@shnikd shnikd mentioned this pull request Mar 22, 2024
Merged
Hor911 pushed a commit to Hor911/ydb that referenced this pull request Mar 25, 2024
@dcherednik @Hor911
Fix update token interval calculation. (ydb-platform#3064)
9c73319 
We should chouse min value from expiresIn and RefreshPeriod_, not max one
Also reduce server returned interval by 2 to prevent race at expiring time.
Hor911 pushed a commit to Hor911/ydb that referenced this pull request Mar 25, 2024
@dcherednik @Hor911
Fix update token interval calculation. (ydb-platform#3064)
b5ffb59 
We should chouse min value from expiresIn and RefreshPeriod_, not max one
Also reduce server returned interval by 2 to prevent race at expiring time.
Hor911 added a commit that referenced this pull request Mar 25, 2024
@Hor911 @dcherednik
Merge from trunk: #3064 (IAM token update), #3107 (CPU load sensors a…
c1baa48 
…nd logs), #3111 (private S3 backets in dynlisting) (#3132)

Co-authored-by: Daniil Cherednik <dcherednik@ydb.tech>
Hor911 added a commit that referenced this pull request Mar 25, 2024
@Hor911 @dcherednik
Merge from trunk: #3064 (IAM token update), #3107 (CPU load sensors a…
736d80e 
…nd logs), #3111 (private S3 backets in dynlisting) (#3133)

Co-authored-by: Daniil Cherednik <dcherednik@ydb.tech>
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 29, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 2, 2024
Merged
@serbel324 serbel324 mentioned this pull request Apr 2, 2024
Merged
This was referenced Apr 4, 2024
Merged
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 4, 2024
Open
@niksaveliev niksaveliev mentioned this pull request Apr 6, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Apr 7, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 10, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 11, 2024
Merged
This was referenced Apr 16, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adameat adameat adameat approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherednik @adameat