Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run & stop workers #2860

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Run & stop workers #2860

merged 1 commit into from
Mar 18, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Mar 17, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@CyberROFL CyberROFL requested a review from Enjection March 17, 2024 10:04
@CyberROFL CyberROFL self-assigned this Mar 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2024 •
edited
Loading

⚪ 2024-03-17 10:07:06 UTC Pre-commit check for 62815c9 has started.
⚪ 2024-03-17 10:07:08 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-03-17 10:44:52 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2024 •
edited
Loading

⚪ 2024-03-17 10:07:09 UTC Pre-commit check for 62815c9 has started.
⚪ 2024-03-17 10:07:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-17 10:47:14 UTC Build successful.
⚪ 2024-03-17 10:47:32 UTC Tests are running...
🔴 2024-03-17 12:57:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15087 14488 0 81 486 32

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2024 •
edited
Loading

⚪ 2024-03-17 10:07:15 UTC Pre-commit check for 62815c9 has started.
⚪ 2024-03-17 10:07:18 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-17 10:47:54 UTC Build successful.
⚪ 2024-03-17 10:48:08 UTC Tests are running...
🔴 2024-03-17 12:40:10 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68410 57402 0 2 10955 51

@CyberROFL CyberROFL marked this pull request as ready for review March 18, 2024 08:40
Enjection
Enjection approved these changes Mar 18, 2024
View reviewed changes
ydb/core/tx/replication/controller/controller.cpp
@@ -213,7 +215,7 @@ void TController::CreateSession(ui32 nodeId, const TActorContext& ctx) {
<< ": nodeId# " << nodeId);

Y_ABORT_UNLESS(!Sessions.contains(nodeId));
Sessions.emplace(nodeId, TSessionInfo{});
Sessions.emplace(nodeId, TSessionInfo());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are calling default constructor, maybe better just Sessions.emplace(nodeId). And instead of contains + emplace, you could use result of emplace to check either you emplaced new value or it was already there.

@CyberROFL CyberROFL merged commit c255e5c into ydb-platform:main Mar 18, 2024
5 of 7 checks passed
@CyberROFL CyberROFL deleted the run-stop-workers branch March 18, 2024 13:20
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 19, 2024
Merged
This was referenced Mar 20, 2024
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 29, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request Apr 2, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
This was referenced Apr 6, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 11, 2024
Merged
@serbel324 serbel324 mentioned this pull request Apr 25, 2024
Merged
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jun 10, 2024
@CyberROFL
Run & stop workers (ydb-platform#2860)
d8f3104
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jun 10, 2024
@CyberROFL
Run & stop workers (ydb-platform#2860)
a5c5c40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enjection Enjection Enjection approved these changes

Assignees

@CyberROFL CyberROFL

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberROFL @Enjection