-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQ-2918: add processing speed statistics to logs #2720
Conversation
⚪
|
⚪
|
⚪
|
⚪
|
first = false; | ||
} | ||
PrintSpeeds(builder, statistics.Stats); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно две чиселки печатать. Одна скорость по статистике, а другая скорость на все выполнение query. Полное время выполнения query можно из query.meta достать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Времени выполнения по статистике нет в v2, сейчас вычисляется из времени начала в job.meta()
. Вторая чиселка из CpuTimeUs
в статистике: считаем скорость per cpu
} | ||
// getting bytes/second = 1'000'000 * bytes/microsecond | ||
auto speed = (value * 1000000.) / std::max(execTime.MicroSeconds(), ui64{1}); | ||
builder << ", \"" << statName << postfix << "\": " << speed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
размерность бы к скорости дописать bytes/sec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
У нас и так названия полей выглядят как IngressBytesPerSecond
/ IngressBytesPerCpuPerSecond
, плюс тут печаетется жсон, проще жить, когда его не надо дополнительно парсить
⚪
|
⚪
|
⚪ |
Changelog entry
Changelog category
Additional information