Forward cache simplify #2514

kunga · 2024-03-06T13:57:45Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

Simplify NFwd::TCache so it doesn't use NTable::TForward (without handling page faults as before)

github-actions · 2024-03-06T14:03:19Z

⚪ 2024-03-06 14:03:19 UTC Pre-commit check for 464cb3f has started.
⚪ 2024-03-06 14:03:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 14:06:43 UTC Build successful.
⚪ 2024-03-06 14:06:52 UTC Tests are running...
🔴 2024-03-06 15:55:15 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68162	56054	0	500	11152	456

github-actions · 2024-03-06T14:31:20Z

⚪ 2024-03-06 14:31:20 UTC Pre-commit check for 464cb3f has started.
⚪ 2024-03-06 14:31:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 14:33:32 UTC Build successful.
⚪ 2024-03-06 14:33:41 UTC Tests are running...
🔴 2024-03-06 16:35:01 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14964	13625	0	534	319	486

github-actions · 2024-03-06T14:50:28Z

⚪ 2024-03-06 14:50:27 UTC Pre-commit check for 464cb3f has started.
⚪ 2024-03-06 14:50:29 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 14:54:08 UTC Build successful.

github-actions · 2024-03-06T17:44:15Z

⚪ 2024-03-06 17:44:14 UTC Pre-commit check for 538b0b0 has started.
⚪ 2024-03-06 17:44:17 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 17:46:55 UTC Build successful.
⚪ 2024-03-06 17:47:08 UTC Tests are running...
🔴 2024-03-06 19:37:57 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68248	57293	0	5	10918	32

github-actions · 2024-03-06T17:44:23Z

⚪ 2024-03-06 17:44:22 UTC Pre-commit check for 538b0b0 has started.
⚪ 2024-03-06 17:44:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 17:47:26 UTC Build successful.
⚪ 2024-03-06 17:47:38 UTC Tests are running...
🔴 2024-03-06 19:35:44 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14947	14778	0	33	102	34

github-actions · 2024-03-06T17:44:28Z

⚪ 2024-03-06 17:44:27 UTC Pre-commit check for 538b0b0 has started.
⚪ 2024-03-06 17:44:30 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 17:55:18 UTC Build successful.

github-actions · 2024-03-06T22:28:03Z

⚪ 2024-03-06 22:28:03 UTC Pre-commit check for 0456d4d has started.
⚪ 2024-03-06 22:28:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-06 22:30:24 UTC Build successful.
⚪ 2024-03-06 22:30:35 UTC Tests are running...
🔴 2024-03-07 00:12:30 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14959	14792	0	28	107	32

github-actions · 2024-03-06T22:29:11Z

⚪ 2024-03-06 22:29:11 UTC Pre-commit check for 0456d4d has started.
⚪ 2024-03-06 22:29:13 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-06 22:31:32 UTC Build successful.

github-actions · 2024-03-06T22:29:11Z

⚪ 2024-03-06 22:29:11 UTC Pre-commit check for 0456d4d has started.
⚪ 2024-03-06 22:29:13 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-06 22:31:37 UTC Build successful.
⚪ 2024-03-06 22:31:49 UTC Tests are running...
🔴 2024-03-06 23:45:09 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68258	57314	0	1	10918	25

github-actions · 2024-03-07T10:20:23Z

⚪ 2024-03-07 10:20:23 UTC Pre-commit check for d1865bb has started.
⚪ 2024-03-07 10:20:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-07 10:22:59 UTC Build successful.
⚪ 2024-03-07 10:23:08 UTC Tests are running...
🔴 2024-03-07 12:02:56 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14957	14821	0	22	86	28

github-actions · 2024-03-07T10:30:42Z

⚪ 2024-03-07 10:30:41 UTC Pre-commit check for d1865bb has started.
⚪ 2024-03-07 10:30:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-07 10:32:39 UTC Build successful.
⚪ 2024-03-07 10:32:49 UTC Tests are running...
🔴 2024-03-07 12:21:23 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68161	57219	0	2	10918	22

github-actions · 2024-03-07T10:49:40Z

⚪ 2024-03-07 10:49:40 UTC Pre-commit check for d1865bb has started.
⚪ 2024-03-07 10:49:42 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-07 10:52:33 UTC Build successful.

snaury · 2024-03-11T11:26:35Z

ydb/core/tablet_flat/flat_fwd_cache.h

@@ -58,8 +61,16 @@ namespace NFwd {
        TCache() = delete;

        TCache(const TPart* part, IPages* env, TGroupId groupId, const TIntrusiveConstPtr<TSlices>& bounds = nullptr)
-            : Index(part, env, groupId, 1, bounds)
-        { }
+            : Index(MakeHolder<TPartIndexIt>(part, env, groupId)) // TODO: use CreateIndexIter(part, env, groupId)


На будущее: стоит подумать о том, чтобы не аллоцировать память, если можно не аллоцировать. Например можно выделять место под разные реализации через std::variant и сохранять указатель на интерфейс. Это к тому, что в будущем в CreateIndexIter стоит передавать ещё место под сторадж итератора.

github-actions bot added the not-for-changelog label Mar 6, 2024

kunga self-assigned this Mar 7, 2024

kunga added 6 commits March 7, 2024 12:50

wip

89e3e58

fix tests

a164650

del flat_part_forward

4830446

clean up

fb50ca8

extract SyncIndex

5546f3e

fix only flat

57d566e

kunga force-pushed the forward-cache-simplify branch from 3ddc5ea to 57d566e Compare March 7, 2024 09:51

kunga requested a review from snaury March 7, 2024 10:02

snaury reviewed Mar 11, 2024

View reviewed changes

snaury approved these changes Mar 11, 2024

View reviewed changes

kunga mentioned this pull request Mar 11, 2024

👑 Readonly B-Tree SST index #1483

Open

61 tasks

kunga merged commit e0a15dd into ydb-platform:main Mar 11, 2024
3 of 5 checks passed

GrigoriyPA mentioned this pull request Mar 19, 2024

Fixed error due to empty token #2966

Merged

This was referenced Mar 20, 2024

Test alter temp table #3011

Merged

Support sequences backup with current value #3023

Closed

Support sequences backup with current value #3089

Merged

shnikd mentioned this pull request Mar 25, 2024

YDBDOCS-632: Documentation of temporary tables #3137

Merged

GrigoriyPA mentioned this pull request Mar 26, 2024

YQ-2738 add integration tests for YT in KQP #3150

Merged

shnikd mentioned this pull request Mar 26, 2024

Test temp indexes #3163

Merged

This was referenced Mar 29, 2024

Unmute kafka tests #3285

Merged

Fix kafka counters and RU #3348

Merged

shnikd mentioned this pull request Apr 4, 2024

Support create sequence in pg parser #3465

Merged

This was referenced Apr 6, 2024

Fix kafka read session verify #3522

Merged

Fix kafka read session partitions releases #3528

Merged

shnikd mentioned this pull request Apr 11, 2024

Support create sequence #3662

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forward cache simplify #2514

Forward cache simplify #2514

kunga commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

snaury Mar 11, 2024

Forward cache simplify #2514

Forward cache simplify #2514

Conversation

kunga commented Mar 6, 2024 • edited Loading

Changelog entry

Changelog category

Additional information

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 6, 2024 • edited Loading

github-actions bot commented Mar 7, 2024 • edited Loading

github-actions bot commented Mar 7, 2024 • edited Loading

github-actions bot commented Mar 7, 2024 • edited Loading

snaury Mar 11, 2024

Choose a reason for hiding this comment

kunga commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 6, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading

github-actions bot commented Mar 7, 2024 •

edited

Loading