Implement indexlookupjoin for non-point selection #2298

ssmike · 2024-02-28T02:58:05Z

No description provided.

github-actions · 2024-02-28T03:30:02Z

⚪ 2024-02-28 03:30:02 UTC Pre-commit check for 0285f25 has started.
⚪ 2024-02-28 03:30:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-28 04:03:58 UTC Build successful.
⚪ 2024-02-28 04:04:15 UTC Tests are running...
🔴 2024-02-28 06:02:43 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68037	56233	0	203	11097	504

github-actions · 2024-02-28T03:30:03Z

⚪ 2024-02-28 03:30:03 UTC Pre-commit check for 0285f25 has started.
⚪ 2024-02-28 03:30:06 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-28 04:01:57 UTC Build successful.

github-actions · 2024-02-28T03:30:07Z

⚪ 2024-02-28 03:30:07 UTC Pre-commit check for 0285f25 has started.
⚪ 2024-02-28 03:30:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-28 04:05:24 UTC Build successful.
⚪ 2024-02-28 04:05:38 UTC Tests are running...
🔴 2024-02-28 06:14:25 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14936	13906	0	202	473	355

github-actions · 2024-02-28T14:04:56Z

⚪ 2024-02-28 14:04:56 UTC Pre-commit check for de1e4a9 has started.
⚪ 2024-02-28 14:04:58 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-02-28 14:10:04 UTC Check cancelled

github-actions · 2024-02-28T14:06:38Z

⚪ 2024-02-28 14:06:37 UTC Pre-commit check for de1e4a9 has started.
⚪ 2024-02-28 14:06:39 UTC Build linux-x86_64-release-cmake14 is running...
⚫ 2024-02-28 14:10:04 UTC Check cancelled

github-actions · 2024-02-28T14:11:09Z

⚪ 2024-02-28 14:11:09 UTC Pre-commit check for 8bd4b19 has started.
⚪ 2024-02-28 14:11:11 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-28 14:38:24 UTC Build successful.

github-actions · 2024-02-28T14:12:19Z

⚪ 2024-02-28 14:12:19 UTC Pre-commit check for 8bd4b19 has started.
⚪ 2024-02-28 14:12:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-28 14:44:34 UTC Build successful.
⚪ 2024-02-28 14:44:46 UTC Tests are running...
🔴 2024-02-28 14:59:49 UTC Test run completed, no test results found for commit c277e5a. Please check build logs.
⚫ 2024-02-28 14:59:52 UTC Check cancelled

github-actions · 2024-02-28T14:12:26Z

⚪ 2024-02-28 14:12:26 UTC Pre-commit check for 8bd4b19 has started.
⚪ 2024-02-28 14:12:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-28 14:45:15 UTC Build successful.
⚪ 2024-02-28 14:45:26 UTC Tests are running...
🔴 2024-02-28 14:59:49 UTC Test run completed, no test results found for commit c277e5a. Please check build logs.
⚫ 2024-02-28 14:59:52 UTC Check cancelled

github-actions · 2024-02-28T15:03:32Z

⚪ 2024-02-28 15:03:32 UTC Pre-commit check for 7862eb0 has started.
⚪ 2024-02-28 15:03:33 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-28 15:05:17 UTC Build successful.

github-actions · 2024-02-28T15:09:20Z

⚪ 2024-02-28 15:09:19 UTC Pre-commit check for 7862eb0 has started.
⚪ 2024-02-28 15:09:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-28 15:11:32 UTC Build successful.
⚪ 2024-02-28 15:11:45 UTC Tests are running...
🔴 2024-02-28 16:49:19 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14880	14742	0	25	89	24

github-actions · 2024-02-28T15:15:14Z

⚪ 2024-02-28 15:15:14 UTC Pre-commit check for 7862eb0 has started.
⚪ 2024-02-28 15:15:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-28 15:17:15 UTC Build successful.
⚪ 2024-02-28 15:17:30 UTC Tests are running...
🔴 2024-02-28 16:48:30 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68016	57094	0	11	10890	21

github-actions · 2024-02-28T19:00:27Z

⚪ 2024-02-28 19:00:27 UTC Pre-commit check for 23b43a1 has started.
⚪ 2024-02-28 19:00:30 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-28 19:02:36 UTC Build successful.

github-actions · 2024-02-28T19:00:43Z

⚪ 2024-02-28 19:00:43 UTC Pre-commit check for 23b43a1 has started.
⚪ 2024-02-28 19:00:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-28 19:02:52 UTC Build successful.
⚪ 2024-02-28 19:03:07 UTC Tests are running...
🔴 2024-02-28 20:17:38 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68015	57097	0	10	10890	18

github-actions · 2024-02-28T19:01:20Z

⚪ 2024-02-28 19:01:20 UTC Pre-commit check for 23b43a1 has started.
⚪ 2024-02-28 19:01:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-28 19:03:33 UTC Build successful.
⚪ 2024-02-28 19:03:45 UTC Tests are running...
🔴 2024-02-28 20:42:51 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14880	14739	0	27	87	27

ydb/core/kqp/opt/logical/kqp_opt_log_join.cpp

github-actions · 2024-02-29T12:33:23Z

⚪ 2024-02-29 12:33:23 UTC Pre-commit check for 37791fb has started.
⚪ 2024-02-29 12:33:24 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-02-29 12:39:08 UTC Check cancelled

github-actions · 2024-02-29T12:33:36Z

⚪ 2024-02-29 12:33:36 UTC Pre-commit check for 37791fb has started.
⚪ 2024-02-29 12:33:39 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-29 12:39:08 UTC Check cancelled

github-actions · 2024-02-29T12:34:00Z

⚪ 2024-02-29 12:34:00 UTC Pre-commit check for 37791fb has started.
⚪ 2024-02-29 12:34:02 UTC Build linux-x86_64-release-cmake14 is running...
⚫ 2024-02-29 12:39:08 UTC Check cancelled

github-actions · 2024-02-29T12:40:16Z

⚪ 2024-02-29 12:40:15 UTC Pre-commit check for 77fd293 has started.
⚪ 2024-02-29 12:40:17 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-29 13:09:16 UTC Build successful.

github-actions · 2024-02-29T12:40:19Z

⚪ 2024-02-29 12:40:19 UTC Pre-commit check for 77fd293 has started.
⚪ 2024-02-29 12:40:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-29 13:08:42 UTC Build successful.
⚪ 2024-02-29 13:08:51 UTC Tests are running...
🔴 2024-02-29 14:41:19 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68022	57109	0	6	10890	17

github-actions · 2024-02-29T12:40:53Z

⚪ 2024-02-29 12:40:53 UTC Pre-commit check for 77fd293 has started.
⚪ 2024-02-29 12:40:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-29 13:09:45 UTC Build successful.
⚪ 2024-02-29 13:09:55 UTC Tests are running...
🔴 2024-02-29 14:48:42 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14895	14751	0	31	88	25

spuchin · 2024-02-29T12:47:01Z

ydb/core/kqp/opt/logical/kqp_opt_log_join.cpp

        .LookupStrategy().Build(TKqpStreamLookupJoinStrategyName)
        .Done();

    // Stream lookup join output: stream<tuple<left_row_struct, optional<right_row_struct>>>
    // so we should apply filters to second element of tuple for each row

+    if (extraRightFilter.IsValid()) {


Добавь коммент, что такое extraRightFilter и что мы с ним делаем.

На самом деле по модулю комментария про то что именно делает rewritetoprefixlookup непонятно что тут написать

ydb/core/kqp/opt/logical/kqp_opt_log_join.cpp

github-actions · 2024-03-07T13:05:36Z

⚪ 2024-03-07 13:05:36 UTC Pre-commit check for ac335f8 has started.
⚪ 2024-03-07 13:05:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-07 13:42:55 UTC Build successful.
⚪ 2024-03-07 13:43:06 UTC Tests are running...
🔴 2024-03-07 15:26:43 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14964	14796	0	39	99	30

github-actions · 2024-03-07T13:08:32Z

⚪ 2024-03-07 13:08:32 UTC Pre-commit check for ac335f8 has started.
⚪ 2024-03-07 13:08:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-07 13:44:28 UTC Build successful.
⚪ 2024-03-07 13:44:39 UTC Tests are running...
🔴 2024-03-07 15:18:50 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68265	57311	0	10	10918	26

github-actions · 2024-03-07T18:24:09Z

⚪ 2024-03-07 18:24:09 UTC Pre-commit check for 76028e0 has started.
⚪ 2024-03-07 18:24:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-07 18:58:50 UTC Build successful.
⚪ 2024-03-07 18:59:03 UTC Tests are running...
🔴 2024-03-07 20:30:27 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
68193	57238	0	10	10922	23

github-actions · 2024-03-07T18:24:40Z

⚪ 2024-03-07 18:24:40 UTC Pre-commit check for 76028e0 has started.
⚪ 2024-03-07 18:24:42 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-07 18:54:44 UTC Build successful.

github-actions · 2024-03-07T18:25:58Z

⚪ 2024-03-07 18:25:58 UTC Pre-commit check for 76028e0 has started.
⚪ 2024-03-07 18:26:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-07 19:02:41 UTC Build successful.
⚪ 2024-03-07 19:02:55 UTC Tests are running...
🔴 2024-03-07 21:03:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15008	14425	0	76	477	30

…rm#2298)" This reverts commit 994d1c7.

ssmike force-pushed the fix-joins branch from 6511476 to b252df2 Compare February 28, 2024 03:27

ssmike force-pushed the fix-joins branch from 8ee1b15 to c277e5a Compare February 28, 2024 14:09

ssmike force-pushed the fix-joins branch from af47632 to 1d3f7d9 Compare February 28, 2024 14:59