Use empty parsing context to build view's select in CREATE VIEW statement #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queries in CREATE VIEW statement and for selecting from the views Preliminary validation is done by adding "query_ast" node to the builded AST of the CREATE VIEW statement. It does not surve any real purpose (it is not persisted in the scheme) as of now except early validation of view queries.
|
⚪
|
|
⚪
|
vitstn
approved these changes
Feb 19, 2024
This was referenced Feb 20, 2024
jepett0
added a commit
to jepett0/ydb
that referenced
this pull request
Mar 6, 2024
jepett0
added a commit
to jepett0/ydb
that referenced
this pull request
Mar 6, 2024
jepett0
added a commit
to jepett0/ydb
that referenced
this pull request
Mar 11, 2024
jepett0
added a commit
that referenced
this pull request
Mar 13, 2024
…ment (#2049) (#2595) Based on: #2049 KIKIMR-20891 CREATE VIEW statement parses (and validates) the select statement saved in the view. It should be parsed in a context isolated from the statements executed before the CREATE VIEW statement (we haven't decided yet on the exact scope of the context of the view's select statement, see [KIKIMR-20656](https://st.yandex-team.ru/KIKIMR-20656)). It is pretty obvious that one should be able to execute the following statement in one go ("one go" = one press of a "run" button in YDB UI): ```sql -- create view NecessaryInnerView with (security_invoker = true) as select 1; -- create view ContextTestingView with (security_invoker = true) as select * from `/local/NecessaryInnerView`; -- where `/local/...` is your cluster name drop view ContextTestingView; create view ContextTestingView with (security_invoker = true) as select * from `/local/NecessaryInnerView`; ``` However, executing both drop view and create view in one go currently produces and error: ``` DropObject is not yet implemented for intent determination transformer ``` which indicates that the context of the inner query: ```sql select * from `/local/NecessaryInnerView` ``` is polluted by the previous: ```sql drop view ContextTestingView; ``` statement. This problem is fixed by using an empty parsing context for parsing view's inner select statement during handling of CREATE VIEW statement.
Closed
This was referenced Jun 7, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KIKIMR-20891
CREATE VIEW statement parses (and validates) the select statement saved in the view. It should be parsed in a context isolated from the statements executed before the CREATE VIEW statement (we haven't decided yet on the exact scope of the context of the view's select statement, see KIKIMR-20656). It is pretty obvious that one should be able to execute the following statement in one go ("one go" = one press of a "run" button in YDB UI):
However, executing both drop view and create view in one go currently produces and error:
which indicates that the context of the inner query:
is polluted by the previous:
statement.
This problem is fixed by using an empty parsing context for parsing view's inner select statement during handling of CREATE VIEW statement.