Fix readset acks sent too early in volatile transactions #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
|
⚪
|
fomichev3000
approved these changes
Feb 16, 2024
snaury
deleted the
cherry-pick-16f7980968f8ef94ba96fecb48c3611c5d5db182-24-1
branch
Closed
This was referenced Feb 28, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Fix readset acks sent too early in volatile transactions.
Changelog category
Additional information
An incorrect callback was used for acknowledging readsets, which caused them to be lost when commit eventually failed, which in turn caused effects to rollback when shard is then restarted. Fixes bug KIKIMR-21060.
Merge from #1945