-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "Support returning list in delete statements (#1684)" (#1705) #1706
Conversation
⚪
|
⚪
|
⚪
|
⚪
|
.Input(del.Input()) | ||
.Build() | ||
.Table(del.Table()) | ||
.ReturningColumns<TCoAtomList>().Build() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
К сожалению, не очень понял: мы не передаем сюда del.ReturningColumns(), а конструируем пустой лист?
@@ -699,6 +704,7 @@ TExprBase BuildUpdateTableWithIndex(const TKiUpdateTable& update, const TKikimrT | |||
auto indexDelete = Build<TKqlDeleteRows>(ctx, update.Pos()) | |||
.Table(indexMeta) | |||
.Input(ProjectColumns(rowsToUpdate, indexTableColumns, ctx)) | |||
.ReturningColumns<TCoAtomList>().Build() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а можно не добоавлять чайлда, наверное?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну совершенно точно это нужная штука. Надо будет поправить правила про ExtractMembers логические к примеру
No description provided.