Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Support returning list in delete statements (#1684)" (#1705) #1706

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

ssmike
Copy link
Collaborator

@ssmike ssmike commented Feb 8, 2024

No description provided.

Copy link

github-actions bot commented Feb 8, 2024

2024-02-08 10:54:37 UTC Pre-commit check for ae86cbc has started.
2024-02-08 10:54:40 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 10:55:49 UTC Build successful.
2024-02-08 10:56:01 UTC Tests are running...
🔴 2024-02-08 11:29:34 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67244 55918 0 482 10820 24

Copy link

github-actions bot commented Feb 8, 2024

2024-02-08 10:56:42 UTC Pre-commit check for ae86cbc has started.
2024-02-08 10:56:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 10:57:54 UTC Build successful.
2024-02-08 10:58:06 UTC Tests are running...
🔴 2024-02-08 11:47:20 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14586 13999 0 490 69 28

Copy link

github-actions bot commented Feb 8, 2024

2024-02-08 12:28:32 UTC Pre-commit check for 404f362 has started.
2024-02-08 12:28:36 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 12:32:35 UTC Build successful.
2024-02-08 12:32:47 UTC Tests are running...
🟢 2024-02-08 14:36:13 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67266 56413 0 0 10822 31

Copy link

github-actions bot commented Feb 8, 2024

2024-02-08 12:28:46 UTC Pre-commit check for 404f362 has started.
2024-02-08 12:28:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 12:33:12 UTC Build successful.
2024-02-08 12:33:24 UTC Tests are running...
🔴 2024-02-08 14:07:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14591 14500 0 16 53 22

@ssmike ssmike requested review from gridnevvvit and qrort February 8, 2024 13:11
.Input(del.Input())
.Build()
.Table(del.Table())
.ReturningColumns<TCoAtomList>().Build()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

К сожалению, не очень понял: мы не передаем сюда del.ReturningColumns(), а конструируем пустой лист?

@@ -699,6 +704,7 @@ TExprBase BuildUpdateTableWithIndex(const TKiUpdateTable& update, const TKikimrT
auto indexDelete = Build<TKqlDeleteRows>(ctx, update.Pos())
.Table(indexMeta)
.Input(ProjectColumns(rowsToUpdate, indexTableColumns, ctx))
.ReturningColumns<TCoAtomList>().Build()
Copy link
Collaborator

@qrort qrort Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а можно не добоавлять чайлда, наверное?

Copy link
Collaborator Author

@ssmike ssmike Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну совершенно точно это нужная штука. Надо будет поправить правила про ExtractMembers логические к примеру

@ssmike ssmike merged commit 33ba54d into ydb-platform:main Feb 8, 2024
3 of 4 checks passed
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants