Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrubbing and flapping unittest #1640

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix scrubbing and flapping unittest #1640

merged 1 commit into from
Feb 7, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Feb 6, 2024

Changelog entry

Fixed scrubbing logic and flapping unittest.

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

There were some logic issues in blob recovery actor leading to blob read multiplication.

@alexvru alexvru force-pushed the blobstorage/fix-scrub-and-test branch from cde0cb8 to 11be8af Compare February 6, 2024 17:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 17:11:04 UTC Pre-commit check for c90b0b2 has started.
⚪ 2024-02-06 17:11:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-06 17:13:00 UTC Build successful.
⚪ 2024-02-06 17:13:09 UTC Tests are running...
🔴 2024-02-06 17:44:08 UTC Test run completed, no test results found for commit 11be8af. Please check build logs.
⚫ 2024-02-06 17:44:12 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 17:15:04 UTC Pre-commit check for c90b0b2 has started.
⚪ 2024-02-06 17:15:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-06 17:16:55 UTC Build successful.
⚪ 2024-02-06 17:17:05 UTC Tests are running...
🔴 2024-02-06 17:44:06 UTC Test run completed, no test results found for commit 11be8af. Please check build logs.
⚫ 2024-02-06 17:44:09 UTC Check cancelled

@alexvru alexvru force-pushed the blobstorage/fix-scrub-and-test branch from 11be8af to f5047f1 Compare February 6, 2024 17:43
@alexvru alexvru force-pushed the blobstorage/fix-scrub-and-test branch from f5047f1 to f5ca891 Compare February 6, 2024 17:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

⚫ 2024-02-06 17:58:19 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 18:16:51 UTC Pre-commit check for 97bc539 has started.
⚪ 2024-02-06 18:16:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-06 18:19:06 UTC Build successful.
⚪ 2024-02-06 18:19:18 UTC Tests are running...
🔴 2024-02-06 19:39:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58837 49528 0 2 9280 27

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 18:20:17 UTC Pre-commit check for 97bc539 has started.
⚪ 2024-02-06 18:20:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-06 18:22:33 UTC Build successful.
⚪ 2024-02-06 18:22:43 UTC Tests are running...
🔴 2024-02-06 19:56:15 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14557 14456 0 14 56 31

@alexvru alexvru merged commit 7bc2f70 into ydb-platform:main Feb 7, 2024
2 of 4 checks passed
@alexvru alexvru deleted the blobstorage/fix-scrub-and-test branch February 7, 2024 07:40
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 7, 2024
Merged
alexvru added a commit to alexvru/ydb that referenced this pull request Feb 7, 2024
@alexvru
Fix scrubbing and flapping unittest (ydb-platform#1640)
f5e8d85
@alexvru alexvru mentioned this pull request Feb 7, 2024
Merged
alexvru added a commit that referenced this pull request Feb 7, 2024
@alexvru @kruall
Merge some fixes from main (#1672)
2751a13 
* Fix scrubbing and flapping unittest (#1640)

* Fix leaking blobs via using patching (#1639)

---------

Co-authored-by: kruall <kruall@ydb.tech>
This was referenced Feb 8, 2024
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 9, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 9, 2024
Merged
vporyadke pushed a commit to vporyadke/ydb that referenced this pull request Feb 9, 2024
@alexvru @vporyadke
Fix scrubbing and flapping unittest (ydb-platform#1640)
0e41d1c
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 12, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
This was referenced Feb 17, 2024
Merged
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruall kruall kruall approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexvru @kruall