Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix empty config requirement #1622

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix empty config requirement #1622

merged 1 commit into from
Feb 6, 2024

Conversation

Enjection
Copy link
Member

Changelog entry

Fix --yaml-config requirement

Changelog category

  • Bugfix

Additional information

...

@Enjection Enjection requested a review from a team as a code owner February 6, 2024 11:12
@gridnevvvit gridnevvvit self-requested a review February 6, 2024 11:15
gridnevvvit
gridnevvvit approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@gridnevvvit gridnevvvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this must be merged to 24-1 and put my approve on this since it's might be blocking some production environments where config yaml is not used yet.

@Enjection Enjection merged commit a2eb383 into ydb-platform:stable-24-1 Feb 6, 2024
5 of 9 checks passed
@Enjection Enjection deleted the bugfix/YDBOPS-8789/fix-empty-yaml-config-24-1 branch February 6, 2024 11:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 11:34:25 UTC Pre-commit check for f933060 has started.
⚪ 2024-02-06 11:34:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-06 11:36:21 UTC Build successful.
⚪ 2024-02-06 11:36:32 UTC Tests are running...
🔴 2024-02-06 12:46:17 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60356 51051 0 1 9270 34

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024 •
edited
Loading

⚪ 2024-02-06 11:35:39 UTC Pre-commit check for f933060 has started.
⚪ 2024-02-06 11:35:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-06 11:37:51 UTC Build successful.
⚪ 2024-02-06 11:38:05 UTC Tests are running...
🔴 2024-02-06 13:16:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
16046 15910 0 34 62 40

@mvgorbunov mvgorbunov mentioned this pull request Feb 22, 2024
Closed
@shnikd shnikd mentioned this pull request Feb 27, 2024
Closed
This was referenced Feb 28, 2024
Closed
Closed
@robdrynkin robdrynkin mentioned this pull request Mar 21, 2024
Closed
@niksaveliev niksaveliev mentioned this pull request Apr 8, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Apr 24, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Apr 26, 2024
Closed
@mregrock mregrock mentioned this pull request May 15, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request May 24, 2024
Closed
This was referenced Jun 7, 2024
Closed
Closed
@CyberROFL CyberROFL mentioned this pull request Jun 19, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 12, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 15, 2024
Closed
@CyberROFL CyberROFL mentioned this pull request Jul 30, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Enjection @fomichev3000 @gridnevvvit