Don't make lookups on predicate pushdown stage #1560

ssmike · 2024-02-02T15:13:57Z

No description provided.

github-actions · 2024-02-02T15:17:10Z

⚪ 2024-02-02 15:17:10 UTC Pre-commit check for bbbeaa2 has started.
⚪ 2024-02-02 15:17:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-02 15:22:55 UTC Build successful.
⚪ 2024-02-02 15:23:11 UTC Tests are running...
🔴 2024-02-02 17:03:41 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58861	49535	0	29	9265	32

github-actions · 2024-02-02T15:17:21Z

⚪ 2024-02-02 15:17:19 UTC Pre-commit check for bbbeaa2 has started.
⚪ 2024-02-02 15:17:23 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-02 15:23:47 UTC Build successful.
⚪ 2024-02-02 15:23:59 UTC Tests are running...
🔴 2024-02-02 17:01:25 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14529	14379	0	54	63	33

github-actions · 2024-02-03T16:57:42Z

⚪ 2024-02-03 16:57:42 UTC Pre-commit check for 6d2000b has started.
⚪ 2024-02-03 16:57:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-03 17:00:48 UTC Build successful.
⚪ 2024-02-03 17:01:01 UTC Tests are running...
🔴 2024-02-03 18:13:44 UTC Test run completed, no test results found for commit e9291cb. Please check build logs.
⚫ 2024-02-03 18:13:47 UTC Check cancelled

github-actions · 2024-02-03T16:57:51Z

⚪ 2024-02-03 16:57:50 UTC Pre-commit check for 6d2000b has started.
⚪ 2024-02-03 16:57:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-03 17:00:30 UTC Build successful.
⚪ 2024-02-03 17:00:46 UTC Tests are running...
🔴 2024-02-03 18:13:44 UTC Test run completed, no test results found for commit e9291cb. Please check build logs.
⚫ 2024-02-03 18:13:47 UTC Check cancelled

github-actions · 2024-02-03T18:15:00Z

⚪ 2024-02-03 18:15:00 UTC Pre-commit check for 39c4b8c has started.
⚪ 2024-02-03 18:15:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-03 18:17:13 UTC Build successful.
⚪ 2024-02-03 18:17:23 UTC Tests are running...
🔴 2024-02-03 18:45:27 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58854	49532	0	18	9267	37

github-actions · 2024-02-03T18:17:08Z

⚪ 2024-02-03 18:17:08 UTC Pre-commit check for 39c4b8c has started.
⚪ 2024-02-03 18:17:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-03 18:19:39 UTC Build successful.
⚪ 2024-02-03 18:19:53 UTC Tests are running...
🔴 2024-02-03 18:49:08 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14528	14351	0	56	85	36

github-actions · 2024-02-04T18:23:28Z

⚪ 2024-02-04 18:23:28 UTC Pre-commit check for 9ec9229 has started.
⚪ 2024-02-04 18:23:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-04 18:25:25 UTC Build successful.
⚪ 2024-02-04 18:25:36 UTC Tests are running...
🔴 2024-02-04 18:33:40 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14528	14352	0	54	85	37

github-actions · 2024-02-04T18:25:04Z

⚪ 2024-02-04 18:25:04 UTC Pre-commit check for 9ec9229 has started.
⚪ 2024-02-04 18:25:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-04 18:27:10 UTC Build successful.
⚪ 2024-02-04 18:27:23 UTC Tests are running...
🔴 2024-02-04 18:36:32 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58854	49534	0	16	9267	37

github-actions · 2024-02-04T21:09:40Z

⚪ 2024-02-04 21:09:40 UTC Pre-commit check for 5d051d0 has started.
⚪ 2024-02-04 21:09:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-04 21:12:18 UTC Build successful.
⚪ 2024-02-04 21:12:33 UTC Tests are running...
🔴 2024-02-04 22:26:43 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58856	49551	0	10	9265	30

github-actions · 2024-02-04T21:09:47Z

⚪ 2024-02-04 21:09:46 UTC Pre-commit check for 5d051d0 has started.
⚪ 2024-02-04 21:09:49 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-04 21:12:38 UTC Build successful.
⚪ 2024-02-04 21:12:49 UTC Tests are running...
🔴 2024-02-04 22:48:40 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14523	14395	0	38	57	33

github-actions · 2024-02-05T00:03:30Z

⚪ 2024-02-05 00:03:30 UTC Pre-commit check for 5dec7d3 has started.
⚪ 2024-02-05 00:03:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-05 00:05:31 UTC Build successful.
⚪ 2024-02-05 00:05:45 UTC Tests are running...
🔴 2024-02-05 00:14:21 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
58856	49552	0	9	9265	30

github-actions · 2024-02-05T00:10:36Z

⚪ 2024-02-05 00:10:36 UTC Pre-commit check for 5dec7d3 has started.
⚪ 2024-02-05 00:10:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-05 00:12:42 UTC Build successful.
⚪ 2024-02-05 00:13:01 UTC Tests are running...
🔴 2024-02-05 00:16:19 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14523	14396	0	37	57	33

ulya-sidorina · 2024-02-07T15:39:27Z

ydb/core/kqp/opt/logical/kqp_opt_log_effects.cpp

+
+namespace {
+
+bool CanPushFlatMap(const NYql::NNodes::TCoFlatMapBase& flatMap, const NYql::TKikimrTableDescription& tableDesc, const NYql::TParentsMap& parentsMap, TVector<TString> & extraColumns) {


Подобная функция уже есть в kqp_opt_log_indexes.cpp, может вынесем в хэлперы?

nepal · 2024-02-08T11:29:39Z

ydb/library/yql/core/yql_opt_utils.cpp

@@ -412,15 +412,15 @@ bool HaveFieldsSubset(const TExprNode::TPtr& start, const TExprNode& arg, TField
        }
    }

-    return usedFields.size() < inputStructType->GetSize();
+    return allowTrivial || usedFields.size() < inputStructType->GetSize();


А почему эту проверку нельзя в клиенте сделать?
HaveFieldSubset ведь заполнит usedFields

github-actions · 2024-02-08T11:48:14Z

⚪ 2024-02-08 11:48:14 UTC Pre-commit check for 4f7ea1c has started.
⚪ 2024-02-08 11:48:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 11:51:30 UTC Build successful.
⚪ 2024-02-08 11:51:39 UTC Tests are running...
🔴 2024-02-08 11:52:54 UTC Test run completed, no test results found for commit 616a026. Please check build logs.
⚫ 2024-02-08 11:52:56 UTC Check cancelled

github-actions · 2024-02-08T11:49:14Z

⚪ 2024-02-08 11:49:14 UTC Pre-commit check for 4f7ea1c has started.
⚪ 2024-02-08 11:49:16 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-02-08 11:52:53 UTC Check cancelled

github-actions · 2024-02-08T11:55:12Z

⚪ 2024-02-08 11:55:11 UTC Pre-commit check for 16848b1 has started.
⚪ 2024-02-08 11:55:15 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 11:57:04 UTC Build successful.
⚪ 2024-02-08 11:57:19 UTC Tests are running...
🔴 2024-02-08 12:09:58 UTC Test run completed, no test results found for commit a9e4160. Please check build logs.
⚫ 2024-02-08 12:10:01 UTC Check cancelled

github-actions · 2024-02-08T11:56:29Z

⚪ 2024-02-08 11:56:28 UTC Pre-commit check for 16848b1 has started.
⚪ 2024-02-08 11:56:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 11:58:05 UTC Build successful.
⚪ 2024-02-08 11:58:14 UTC Tests are running...
🔴 2024-02-08 12:09:57 UTC Test run completed, no test results found for commit a9e4160. Please check build logs.
⚫ 2024-02-08 12:10:00 UTC Check cancelled

Don't make lookups on predicate pushdown stage

ssmike requested a review from a team as a code owner February 2, 2024 15:13

ssmike assigned spuchin and ulya-sidorina Feb 2, 2024

ssmike assigned gridnevvvit Feb 3, 2024

ssmike assigned pavelvelikhov Feb 7, 2024

ulya-sidorina reviewed Feb 7, 2024

View reviewed changes

ssmike requested review from nepal and ulya-sidorina February 7, 2024 18:27

ulya-sidorina previously approved these changes Feb 8, 2024

View reviewed changes

ssmike enabled auto-merge (squash) February 8, 2024 10:37

nepal previously requested changes Feb 8, 2024

View reviewed changes

ssmike dismissed ulya-sidorina’s stale review via 616a026 February 8, 2024 11:45

ssmike force-pushed the delete-over-readranges branch from 616a026 to a9e4160 Compare February 8, 2024 11:52

ssmike force-pushed the delete-over-readranges branch from a9e4160 to 7398e96 Compare February 8, 2024 12:09

ulya-sidorina approved these changes Feb 8, 2024

View reviewed changes

ssmike merged commit ffc1355 into ydb-platform:main Feb 8, 2024
2 of 4 checks passed

niksaveliev mentioned this pull request Feb 9, 2024

Fix pq writer and few renames #1757

Merged

GrigoriyPA mentioned this pull request Feb 9, 2024

Moved optimizers from yql/providers/dq to yql/dq #1758

Merged

serbel324 mentioned this pull request Feb 9, 2024

Mute Burst Detection tests #1763

Merged

ssmike added a commit to ssmike/ydb that referenced this pull request Feb 9, 2024

Don't make lookups on predicate pushdown stage (ydb-platform#1560)

ef891ed

Don't make lookups on predicate pushdown stage

ssmike mentioned this pull request Feb 9, 2024

Merge to 24.1 #1772

Merged

pavelvelikhov mentioned this pull request Feb 9, 2024

Cannonized two plans #1773

Merged

niksaveliev mentioned this pull request Feb 12, 2024

Workload read without consumer and metrics fixes #1792

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching #1800

Closed

vitstn mentioned this pull request Feb 12, 2024

quick fix for column name of select version() #1801

Merged

GrigoriyPA mentioned this pull request Feb 12, 2024

YQ 2786 fix test fq restarts #1810

Merged

vitstn mentioned this pull request Feb 12, 2024

Support of database sys cache #1817

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching (fixed) #1847

Merged

serbel324 mentioned this pull request Feb 13, 2024

Improve some headers #1877

Merged

pavelvelikhov mentioned this pull request Feb 13, 2024

Fixed a problem with simplified plan JSONs #1878

Merged

serbel324 mentioned this pull request Feb 13, 2024

Reintroduce test_helpers for ut_blobstorage #1890

Merged

This was referenced Feb 13, 2024

Case insensivity for pg_catalog tables/cluster, columns. Support of pg_class:relam, and some columns in pg_database & pg_namespace #1893

Merged

fixed pg_get_userbyid function #1936

Merged

support of AnyNonArray type, fixes for array_agg #1958

Merged

pavelvelikhov mentioned this pull request Feb 15, 2024

Fixed a problem with plans in PG ut #1974

Merged

niksaveliev mentioned this pull request Feb 16, 2024

Fix kafka with enabled proxy #2017

Merged

vitstn mentioned this pull request Feb 16, 2024

mock of savepoints #2026

Merged

This was referenced Feb 17, 2024

YQ 2786 unmute s3 test bindings #2042

Merged

YQ-2884 fixed fq cancel operation race #2055

Merged

YQ-2883 fix retries for recover point COMPLETING #2107

Merged

ssmike deleted the delete-over-readranges branch February 20, 2024 17:08

This was referenced Feb 21, 2024

YQ-2873 fix hanging in kqp compute actor #2131

Merged

YQ-2786 partly unmute tests fq s3 #2143

Merged

YQ-2898 fix query failed with unknown uncommitted upload issue #2240

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't make lookups on predicate pushdown stage #1560

Don't make lookups on predicate pushdown stage #1560

ssmike commented Feb 2, 2024

github-actions bot commented Feb 2, 2024 •

edited

Loading

github-actions bot commented Feb 2, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

ulya-sidorina Feb 7, 2024 •

edited

Loading

nepal Feb 8, 2024

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading


		namespace {

		bool CanPushFlatMap(const NYql::NNodes::TCoFlatMapBase& flatMap, const NYql::TKikimrTableDescription& tableDesc, const NYql::TParentsMap& parentsMap, TVector<TString> & extraColumns) {

Don't make lookups on predicate pushdown stage #1560

Don't make lookups on predicate pushdown stage #1560

Conversation

ssmike commented Feb 2, 2024

github-actions bot commented Feb 2, 2024 • edited Loading

github-actions bot commented Feb 2, 2024 • edited Loading

github-actions bot commented Feb 3, 2024 • edited Loading

github-actions bot commented Feb 3, 2024 • edited Loading

github-actions bot commented Feb 3, 2024 • edited Loading

github-actions bot commented Feb 3, 2024 • edited Loading

github-actions bot commented Feb 4, 2024 • edited Loading

github-actions bot commented Feb 4, 2024 • edited Loading

github-actions bot commented Feb 4, 2024 • edited Loading

github-actions bot commented Feb 4, 2024 • edited Loading

github-actions bot commented Feb 5, 2024 • edited Loading

github-actions bot commented Feb 5, 2024 • edited Loading

ulya-sidorina Feb 7, 2024 • edited Loading

Choose a reason for hiding this comment

nepal Feb 8, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 2, 2024 •

edited

Loading

github-actions bot commented Feb 2, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 4, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

github-actions bot commented Feb 5, 2024 •

edited

Loading

ulya-sidorina Feb 7, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading