Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDisk log flush completion action use after free #1359

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented Jan 26, 2024

Changelog entry

Fixes use after free in pdisk log flush wrapper

Changelog category

  • Bugfix

Additional information

Should fix:

Test crashed (return code: -6)
See logs for more info
Problem thread backtrace:
Thread 1 (LWP 156277):
#0  0x00007fb31dedf00b in raise () from /lib/x86_64-linux-gnu/libc.so.6
No symbol table info available.
#1  0x00007fb31debe859 in abort () from /lib/x86_64-linux-gnu/libc.so.6
No symbol table info available.
#2  0x0000000001e027c6 in __cxa_pure_virtual () at /-S/contrib/libs/cxxsupp/libcxxrt/auxhelper.cc:80
No locals.
#3  0x00000000031cdbde in NKikimr::NPDisk::TLogFlushCompletionAction::Release(NActors::TActorSystem*) () at /-S/contrib/ydb/core/blobstorage/pdisk/blobstorage_pdisk_impl_log.cpp:36
No locals.

Copy link

github-actions bot commented Jan 26, 2024

2024-01-26 21:14:35 UTC Pre-commit check for da07029 has started.
2024-01-26 21:14:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-26 21:16:40 UTC Build successful.
2024-01-26 21:16:55 UTC Tests are running...
🔴 2024-01-26 22:29:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60210 50920 0 3 9251 36

Copy link

github-actions bot commented Jan 26, 2024

2024-01-26 21:14:41 UTC Pre-commit check for da07029 has started.
2024-01-26 21:14:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-26 21:16:53 UTC Build successful.
2024-01-26 21:17:05 UTC Tests are running...
🔴 2024-01-26 22:54:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15985 15870 0 28 63 24

Copy link

github-actions bot commented Jan 29, 2024

2024-01-29 10:56:32 UTC Pre-commit check for 307a247 has started.
2024-01-29 10:56:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-29 10:58:33 UTC Build successful.
2024-01-29 10:58:48 UTC Tests are running...
🔴 2024-01-29 12:35:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60134 50837 0 14 9260 23

Copy link

github-actions bot commented Jan 29, 2024

2024-01-29 10:56:50 UTC Pre-commit check for 307a247 has started.
2024-01-29 10:56:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-29 10:59:01 UTC Build successful.
2024-01-29 10:59:14 UTC Tests are running...
🔴 2024-01-29 12:30:19 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15887 15786 0 23 48 30

@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants