Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify portion change operations #13157

Merged
merged 14 commits into from
Jan 4, 2025
Merged

unify portion change operations #13157

merged 14 commits into from
Jan 4, 2025

Conversation

ivanmorozov333
Copy link
Collaborator

  • Improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 15:48:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 487b9ab has started.
⚪ 2025-01-02 15:48:34 UTC Artifacts will be uploaded here
⚪ 2025-01-02 15:51:25 UTC ya make is running...
⚫ 2025-01-02 15:52:48 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 15:48:48 UTC Pre-commit check linux-x86_64-release-asan for 487b9ab has started.
⚪ 2025-01-02 15:49:03 UTC Artifacts will be uploaded here
⚪ 2025-01-02 15:51:55 UTC ya make is running...
⚫ 2025-01-02 15:52:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 15:53:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 919c6d6 has started.
⚪ 2025-01-02 15:54:14 UTC Artifacts will be uploaded here
⚪ 2025-01-02 15:57:29 UTC ya make is running...
⚫ 2025-01-02 16:02:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 15:57:30 UTC Pre-commit check linux-x86_64-release-asan for 919c6d6 has started.
⚪ 2025-01-02 15:57:42 UTC Artifacts will be uploaded here
⚪ 2025-01-02 16:00:41 UTC ya make is running...
⚫ 2025-01-02 16:02:59 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 16:05:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1fa9192 has started.
⚪ 2025-01-02 16:05:50 UTC Artifacts will be uploaded here
⚪ 2025-01-02 16:08:47 UTC ya make is running...
⚫ 2025-01-02 16:10:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 16:05:05 UTC Pre-commit check linux-x86_64-release-asan for 1fa9192 has started.
⚪ 2025-01-02 16:05:17 UTC Artifacts will be uploaded here
⚪ 2025-01-02 16:08:10 UTC ya make is running...
⚫ 2025-01-02 16:10:54 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 16:12:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7f4c0fc has started.
⚪ 2025-01-02 16:12:31 UTC Artifacts will be uploaded here
⚪ 2025-01-02 16:15:31 UTC ya make is running...
🔴 2025-01-02 16:28:34 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

⚪ 2025-01-02 16:15:12 UTC Pre-commit check linux-x86_64-release-asan for 7f4c0fc has started.
⚪ 2025-01-02 16:15:26 UTC Artifacts will be uploaded here
⚪ 2025-01-02 16:18:19 UTC ya make is running...
🔴 2025-01-02 16:25:52 UTC Build failed, see the logs. Also see fail summary

@ivanmorozov333 ivanmorozov333 force-pushed the unify_portion_change_operations branch from c136909 to 5275ae8 Compare January 3, 2025 08:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 08:59:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for f4b6e6c has started.
⚪ 2025-01-03 08:59:14 UTC Artifacts will be uploaded here
⚪ 2025-01-03 09:02:28 UTC ya make is running...
🔴 2025-01-03 09:30:05 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 08:59:05 UTC Pre-commit check linux-x86_64-release-asan for f4b6e6c has started.
⚪ 2025-01-03 08:59:18 UTC Artifacts will be uploaded here
⚪ 2025-01-03 09:02:35 UTC ya make is running...
🔴 2025-01-03 09:26:42 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 09:41:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 952590a has started.
⚪ 2025-01-03 09:41:21 UTC Artifacts will be uploaded here
⚪ 2025-01-03 09:44:34 UTC ya make is running...
🔴 2025-01-03 09:51:44 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 09:41:37 UTC Pre-commit check linux-x86_64-release-asan for 952590a has started.
⚪ 2025-01-03 09:41:48 UTC Artifacts will be uploaded here
⚪ 2025-01-03 09:45:10 UTC ya make is running...
🔴 2025-01-03 09:55:15 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 10:10:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for e6e0362 has started.
⚪ 2025-01-03 10:10:36 UTC Artifacts will be uploaded here
⚪ 2025-01-03 10:13:58 UTC ya make is running...
🔴 2025-01-03 10:19:53 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 10:10:31 UTC Pre-commit check linux-x86_64-release-asan for e6e0362 has started.
⚪ 2025-01-03 10:10:43 UTC Artifacts will be uploaded here
⚪ 2025-01-03 10:14:09 UTC ya make is running...
🔴 2025-01-03 10:21:37 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 11:11:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4222fe5 has started.
⚪ 2025-01-03 11:11:53 UTC Artifacts will be uploaded here
⚪ 2025-01-03 11:15:06 UTC ya make is running...
🟡 2025-01-03 12:07:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
23877 22150 0 228 1374 125

⚪ 2025-01-03 12:09:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-03 12:22:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
575 (only retried tests) 259 0 194 0 122

⚪ 2025-01-03 12:22:15 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-03 12:34:24 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
506 (only retried tests) 218 0 157 9 122

🟢 2025-01-03 12:34:33 UTC Build successful.
🟢 2025-01-03 12:35:02 UTC ydbd size 2.1 GiB changed* by +53.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 77b7c35 merge: 4222fe5 diff diff %
ydbd size 2 243 476 656 Bytes 2 243 531 184 Bytes +53.2 KiB +0.002%
ydbd stripped size 472 241 552 Bytes 472 241 680 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 11:11:55 UTC Pre-commit check linux-x86_64-release-asan for 4222fe5 has started.
⚪ 2025-01-03 11:12:06 UTC Artifacts will be uploaded here
⚪ 2025-01-03 11:15:19 UTC ya make is running...
🟡 2025-01-03 12:19:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13453 13344 0 69 9 31

⚪ 2025-01-03 12:20:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-03 12:34:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 110 0 49 0 25

⚪ 2025-01-03 12:34:21 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-03 12:46:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 68 0 36 0 25

🟢 2025-01-03 12:46:25 UTC Build successful.
🟢 2025-01-03 12:46:54 UTC ydbd size 3.6 GiB changed* by +68.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 77b7c35 merge: 4222fe5 diff diff %
ydbd size 3 872 511 544 Bytes 3 872 581 656 Bytes +68.5 KiB +0.002%
ydbd stripped size 1 350 376 080 Bytes 1 350 393 200 Bytes +16.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 13:29:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for c58be4f has started.
⚪ 2025-01-03 13:30:02 UTC Artifacts will be uploaded here
⚪ 2025-01-03 13:33:24 UTC ya make is running...
🟡 2025-01-03 14:23:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
23877 22371 0 29 1353 124

⚪ 2025-01-03 14:25:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-03 14:38:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
238 (only retried tests) 92 0 26 0 120

⚪ 2025-01-03 14:39:02 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-03 14:50:42 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
226 (only retried tests) 80 0 26 0 120

🟢 2025-01-03 14:50:49 UTC Build successful.
🟢 2025-01-03 14:51:14 UTC ydbd size 2.1 GiB changed* by +53.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 77b7c35 merge: c58be4f diff diff %
ydbd size 2 243 476 656 Bytes 2 243 531 248 Bytes +53.3 KiB +0.002%
ydbd stripped size 472 241 552 Bytes 472 241 680 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 13:30:10 UTC Pre-commit check linux-x86_64-release-asan for c58be4f has started.
⚪ 2025-01-03 13:30:23 UTC Artifacts will be uploaded here
⚪ 2025-01-03 13:33:53 UTC ya make is running...
🟡 2025-01-03 14:35:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13453 13341 0 79 4 29

⚪ 2025-01-03 14:36:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-03 14:50:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 117 0 48 1 25

⚪ 2025-01-03 14:50:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-03 15:03:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 62 0 41 0 26

🟢 2025-01-03 15:03:21 UTC Build successful.
🟢 2025-01-03 15:03:51 UTC ydbd size 3.6 GiB changed* by +68.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 77b7c35 merge: c58be4f diff diff %
ydbd size 3 872 511 544 Bytes 3 872 582 008 Bytes +68.8 KiB +0.002%
ydbd stripped size 1 350 376 080 Bytes 1 350 393 328 Bytes +16.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025 •
edited
Loading

⚪ 2025-01-04 07:14:38 UTC Pre-commit check linux-x86_64-release-asan for 9dc1b2e has started.
⚪ 2025-01-04 07:15:03 UTC Artifacts will be uploaded here
⚫ 2025-01-04 07:18:16 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 force-pushed the unify_portion_change_operations branch from 45c7211 to 6d90562 Compare January 4, 2025 07:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025 •
edited
Loading

⚪ 2025-01-04 07:22:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for aaa1ad8 has started.
⚪ 2025-01-04 07:22:14 UTC Artifacts will be uploaded here
⚪ 2025-01-04 07:25:38 UTC ya make is running...
🟡 2025-01-04 08:23:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
23845 22353 0 3 1362 127

⚪ 2025-01-04 08:25:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-04 08:37:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 84 0 0 0 121

🟢 2025-01-04 08:37:22 UTC Build successful.
🟢 2025-01-04 08:37:41 UTC ydbd size 2.1 GiB changed* by +53.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5e5216a merge: aaa1ad8 diff diff %
ydbd size 2 243 630 208 Bytes 2 243 684 848 Bytes +53.4 KiB +0.002%
ydbd stripped size 472 256 784 Bytes 472 256 976 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2025 •
edited
Loading

⚪ 2025-01-04 07:22:17 UTC Pre-commit check linux-x86_64-release-asan for aaa1ad8 has started.
⚪ 2025-01-04 07:22:29 UTC Artifacts will be uploaded here
⚪ 2025-01-04 07:25:53 UTC ya make is running...
🟡 2025-01-04 08:32:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13446 13375 0 38 5 28

⚪ 2025-01-04 08:33:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-04 08:45:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 78 0 4 1 26

⚪ 2025-01-04 08:45:55 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-04 08:57:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
56 (only retried tests) 26 0 3 2 25

🟢 2025-01-04 08:57:31 UTC Build successful.
🟢 2025-01-04 08:57:58 UTC ydbd size 3.6 GiB changed* by +64.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5e5216a merge: aaa1ad8 diff diff %
ydbd size 3 872 762 856 Bytes 3 872 829 240 Bytes +64.8 KiB +0.002%
ydbd stripped size 1 350 424 528 Bytes 1 350 437 680 Bytes +12.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review January 4, 2025 08:47
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner January 4, 2025 08:47
@ivanmorozov333 ivanmorozov333 enabled auto-merge (squash) January 4, 2025 08:47
@ivanmorozov333 ivanmorozov333 merged commit d9cdc77 into ydb-platform:main Jan 4, 2025
12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the unify_portion_change_operations branch January 4, 2025 11:14
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 5, 2025
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 21, 2025
@ivanmorozov333 @zverevgeny
unify portion change operations (ydb-platform#13157)
671973c 
Conflicts:
	ydb/core/tx/columnshard/hooks/testing/controller.h
@zverevgeny zverevgeny mentioned this pull request Jan 21, 2025
Closed
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@ivanmorozov333 @azevaykin
unify portion change operations (ydb-platform#13157)
7270e45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @zverevgeny