Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added information on the Prometheus configuration file #13121

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added information on the Prometheus configuration file #13121

wants to merge 5 commits into from

Conversation

anton-bobkov
Copy link
Collaborator

Changelog category

  • Documentation

Additional information

Added information on how to edit the Prometheus configuration file when setting up YDB monitoring

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 28, 2024 •
edited
Loading

⚪ 2024-12-28 13:37:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for ed33a82 has started.
⚪ 2024-12-28 13:37:35 UTC Artifacts will be uploaded here
⚪ 2024-12-28 13:40:37 UTC ya make is running...
🟢 2024-12-28 13:42:19 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-28 13:42:24 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 28, 2024 •
edited
Loading

⚪ 2024-12-28 13:39:53 UTC Pre-commit check linux-x86_64-release-asan for ed33a82 has started.
⚪ 2024-12-28 13:40:06 UTC Artifacts will be uploaded here
⚪ 2024-12-28 13:42:26 UTC ya make is running...
🟢 2024-12-28 13:42:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-28 13:42:37 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

⚪ 2025-01-09 06:25:14 UTC Pre-commit check linux-x86_64-release-asan for f7a8bf2 has started.
⚪ 2025-01-09 06:25:44 UTC Artifacts will be uploaded here
⚪ 2025-01-09 06:28:15 UTC ya make is running...
🟢 2025-01-09 06:29:52 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-09 06:29:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

⚪ 2025-01-09 06:25:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for f7a8bf2 has started.
⚪ 2025-01-09 06:26:24 UTC Artifacts will be uploaded here
⚪ 2025-01-09 06:29:12 UTC ya make is running...
🟢 2025-01-09 06:30:27 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-09 06:30:33 UTC Build successful.

@anton-bobkov anton-bobkov marked this pull request as ready for review January 9, 2025 06:27
@anton-bobkov anton-bobkov requested a review from a team as a code owner January 9, 2025 06:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

⚪ 2025-01-09 09:22:44 UTC Pre-commit check linux-x86_64-release-asan for a04de6f has started.
⚪ 2025-01-09 09:22:56 UTC Artifacts will be uploaded here
⚪ 2025-01-09 09:25:17 UTC ya make is running...
🟢 2025-01-09 09:26:40 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-09 09:26:45 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

⚪ 2025-01-09 09:23:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for a04de6f has started.
⚪ 2025-01-09 09:23:28 UTC Artifacts will be uploaded here
⚪ 2025-01-09 09:25:50 UTC ya make is running...
🟢 2025-01-09 09:26:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-09 09:27:01 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

⚪ 2025-01-09 09:28:35 UTC Pre-commit check linux-x86_64-release-asan for 3be2c6d has started.
⚪ 2025-01-09 09:28:47 UTC Artifacts will be uploaded here
⚪ 2025-01-09 09:31:08 UTC ya make is running...
🟢 2025-01-09 09:32:29 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-09 09:32:35 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

⚪ 2025-01-09 09:29:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3be2c6d has started.
⚪ 2025-01-09 09:29:47 UTC Artifacts will be uploaded here
⚪ 2025-01-09 09:32:10 UTC ya make is running...
🟢 2025-01-09 09:33:16 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-09 09:33:21 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

✅ Documentation build

Revision built successfully
Revision preview link

sourcecd
sourcecd previously approved these changes Jan 10, 2025
View reviewed changes
blinkov
blinkov requested changes Jan 10, 2025
View reviewed changes
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
ydb/docs/en/core/devops/manual/monitoring.md Outdated Show resolved Hide resolved
@anton-bobkov @blinkov
Apply suggestions from code review
e17aff8 
Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

⚪ 2025-01-10 11:29:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 365861e has started.
⚪ 2025-01-10 11:29:26 UTC Artifacts will be uploaded here
⚪ 2025-01-10 11:31:47 UTC ya make is running...
🟢 2025-01-10 11:33:11 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 11:33:16 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

⚪ 2025-01-10 11:30:05 UTC Pre-commit check linux-x86_64-release-asan for 365861e has started.
⚪ 2025-01-10 11:30:16 UTC Artifacts will be uploaded here
⚪ 2025-01-10 11:32:43 UTC ya make is running...
🟢 2025-01-10 11:33:49 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 11:33:54 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

⚪ 2025-01-10 18:06:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for e7bdecd has started.
⚪ 2025-01-10 18:06:42 UTC Artifacts will be uploaded here
⚪ 2025-01-10 18:09:13 UTC ya make is running...
🟢 2025-01-10 18:10:45 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 18:10:51 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

⚪ 2025-01-10 18:08:10 UTC Pre-commit check linux-x86_64-release-asan for e7bdecd has started.
⚪ 2025-01-10 18:08:21 UTC Artifacts will be uploaded here
⚪ 2025-01-10 18:10:41 UTC ya make is running...
🟢 2025-01-10 18:10:47 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-10 18:10:53 UTC Build successful.

@github-actions GitHub Actions
Copy link

❌ Documentation build

Revision build failed

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov enabled auto-merge (squash) January 31, 2025 08:17
@github-actions GitHub Actions
Copy link

⚪ 2025-01-31 08:19:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 49e6d1f has started.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

⚪ 2025-01-31 08:24:56 UTC Pre-commit check linux-x86_64-release-asan for 49e6d1f has started.
⚪ 2025-01-31 08:27:15 UTC Artifacts will be uploaded here
⚪ 2025-01-31 08:29:48 UTC ya make is running...
🟢 2025-01-31 08:31:26 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

fomichev3000
fomichev3000 requested changes Feb 2, 2025
View reviewed changes
Copy link
Member

@fomichev3000 fomichev3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом ок. Однако я прочитал документ (https://ydb-platform--ydb.viewer.diplodoc.com/ru/devops/manual/monitoring?revision=pr-13121-5accb60017c0561247bfd3ecd4e5d2a70eb5a98e) от начала до конца. Меня смутило, что в документе чередуются слова "сенсор" и "метрика". Просьба привести к одной терминологии. При этом правильным термином является слово "метрика" (лучше мне не верить и уточнить у Прометеуса)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

⚪ 2025-02-03 15:16:49 UTC Pre-commit check linux-x86_64-release-asan for bff5ca5 has started.
⚪ 2025-02-03 15:17:21 UTC Artifacts will be uploaded here
⚪ 2025-02-03 15:20:09 UTC ya make is running...
🟢 2025-02-03 15:21:47 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-02-03 15:21:55 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

⚪ 2025-02-03 15:18:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for bff5ca5 has started.
⚪ 2025-02-03 15:19:04 UTC Artifacts will be uploaded here
⚪ 2025-02-03 15:21:26 UTC ya make is running...
🟢 2025-02-03 15:22:28 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-02-03 15:22:34 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

✅ Documentation build

Revision built successfully
Revision preview link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blinkov blinkov blinkov requested changes

@fomichev3000 fomichev3000 fomichev3000 requested changes

@elabpro elabpro elabpro approved these changes

@sourcecd sourcecd sourcecd left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anton-bobkov @blinkov @fomichev3000 @sourcecd @elabpro