Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up bloom construction #13073

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

ivanmorozov333
Copy link
Collaborator

  • Performance improvement

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 09:30:02 UTC Pre-commit check linux-x86_64-release-asan for d596389 has started.
2024-12-27 09:30:39 UTC Artifacts will be uploaded here
2024-12-27 09:34:08 UTC ya make is running...
🟡 2024-12-27 10:32:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11451 11391 0 22 10 28

2024-12-27 10:33:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 10:45:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 68 0 2 0 26

2024-12-27 10:45:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 10:50:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 28 0 1 0 25

🟢 2024-12-27 10:50:26 UTC Build successful.
🟡 2024-12-27 10:50:55 UTC ydbd size 3.6 GiB changed* by +866.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: df406e3 merge: d596389 diff diff %
ydbd size 3 869 466 664 Bytes 3 870 353 760 Bytes +866.3 KiB +0.023%
ydbd stripped size 1 349 124 720 Bytes 1 349 452 400 Bytes +320.0 KiB +0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 09:33:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for d596389 has started.
2024-12-27 09:33:16 UTC Artifacts will be uploaded here
2024-12-27 09:36:09 UTC ya make is running...
🟡 2024-12-27 10:19:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19329 17778 0 10 1417 124

2024-12-27 10:21:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 10:33:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
201 (only retried tests) 80 0 2 0 119

2024-12-27 10:33:55 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-27 10:45:16 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 56 0 1 0 119

🟢 2024-12-27 10:45:24 UTC Build successful.
🟡 2024-12-27 10:45:47 UTC ydbd size 2.1 GiB changed* by +537.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: df406e3 merge: d596389 diff diff %
ydbd size 2 241 665 856 Bytes 2 242 216 040 Bytes +537.3 KiB +0.025%
ydbd stripped size 471 947 344 Bytes 472 098 896 Bytes +148.0 KiB +0.032%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Dec 27, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 27, 2024
Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 12:21:21 UTC Pre-commit check linux-x86_64-release-asan for 9f9b48e has started.
2024-12-27 12:21:50 UTC Artifacts will be uploaded here
2024-12-27 12:25:21 UTC ya make is running...
🟡 2024-12-27 13:23:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11451 11375 0 41 4 31

2024-12-27 13:24:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 13:36:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 94 0 9 2 26

2024-12-27 13:37:03 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 13:41:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 40 0 2 0 24

🟢 2024-12-27 13:41:47 UTC Build successful.
🟡 2024-12-27 13:42:17 UTC ydbd size 3.6 GiB changed* by +866.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a61cedc merge: 9f9b48e diff diff %
ydbd size 3 869 477 968 Bytes 3 870 365 064 Bytes +866.3 KiB +0.023%
ydbd stripped size 1 349 128 112 Bytes 1 349 455 792 Bytes +320.0 KiB +0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 12:22:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9f9b48e has started.
2024-12-27 12:22:23 UTC Artifacts will be uploaded here
2024-12-27 12:25:12 UTC ya make is running...
🟡 2024-12-27 13:11:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19331 17770 0 8 1424 129

2024-12-27 13:13:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-27 13:25:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
206 (only retried tests) 84 0 0 0 122

🟢 2024-12-27 13:26:05 UTC Build successful.
🟡 2024-12-27 13:26:25 UTC ydbd size 2.1 GiB changed* by +537.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a61cedc merge: 9f9b48e diff diff %
ydbd size 2 241 674 192 Bytes 2 242 224 368 Bytes +537.3 KiB +0.025%
ydbd stripped size 471 948 624 Bytes 472 100 176 Bytes +148.0 KiB +0.032%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 28, 2024 05:40
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 28, 2024 05:40
@ivanmorozov333 ivanmorozov333 merged commit 7155bd1 into ydb-platform:main Dec 28, 2024
18 of 19 checks passed
@ivanmorozov333 ivanmorozov333 deleted the speed_up_bloom branch December 28, 2024 05:40
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 4, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants