check colunm tables creation with nullables columns #13061

zverevgeny · 2024-12-26T19:25:56Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-12-26T19:29:43Z

⚪ 2024-12-26 19:29:42 UTC Pre-commit check linux-x86_64-release-asan for 90af373 has started.
⚪ 2024-12-26 19:29:55 UTC Artifacts will be uploaded here
⚫ 2024-12-26 19:30:23 UTC Check cancelled

github-actions · 2024-12-26T19:29:43Z

⚪ 2024-12-26 19:29:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 90af373 has started.
⚪ 2024-12-26 19:29:55 UTC Artifacts will be uploaded here
⚫ 2024-12-26 19:30:23 UTC Check cancelled

github-actions · 2024-12-26T19:33:57Z

⚪ 2024-12-26 19:33:57 UTC Pre-commit check linux-x86_64-release-asan for 752638f has started.
⚪ 2024-12-26 19:34:26 UTC Artifacts will be uploaded here
⚪ 2024-12-26 19:37:35 UTC ya make is running...
🟡 2024-12-26 20:00:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1932	1906	0	14	5	7

⚪ 2024-12-26 20:00:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 20:07:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
33 (only retried tests)	26	0	1	1	5

⚪ 2024-12-26 20:07:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-26 20:10:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12 (only retried tests)	7	0	0	0	5

🟢 2024-12-26 20:10:28 UTC Build successful.
🟢 2024-12-26 20:10:45 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `aa12ad5`	merge: `752638f`	diff	diff %
ydbd size	3 868 052 712 Bytes	3 868 052 616 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 348 730 544 Bytes	1 348 730 480 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-26T19:34:05Z

⚪ 2024-12-26 19:34:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 752638f has started.
⚪ 2024-12-26 19:34:24 UTC Artifacts will be uploaded here
⚪ 2024-12-26 19:36:52 UTC ya make is running...
🟢 2024-12-26 19:56:04 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4731	4615	0	0	36	80

🟢 2024-12-26 19:56:30 UTC Build successful.
🟢 2024-12-26 19:56:40 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `aa12ad5`	merge: `752638f`	diff	diff %
ydbd size	2 240 804 032 Bytes	2 240 804 032 Bytes	0 Bytes	0.000%
ydbd stripped size	471 822 736 Bytes	471 822 736 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/tests/library/harness/kikimr_config.py

ydb/tests/workloads/olap_workload/tests/test_workload.py

maximyurchuk · 2024-12-27T12:51:59Z

ydb/tests/workloads/olap_workload/__main__.py

@@ -273,11 +284,12 @@ def get_workload_thread_funcs(self):


 class WorkloadRunner:
-    def __init__(self, client, name, duration):
+    def __init__(self, client, args):


Ну вот честно: я всегда против такого (засовывать args в конструктор):

ты подменяешь сложность класса тем что засовываешь "все на свете" в одну переменную

это сложнее понимать

класс нельзя создать например в тесте
Я бы предложил вернуть как было

А дальше этот класс начнет сувать args в другие классы и потом будет вообще абсолютно непонятно

поправил

maximyurchuk

Мне кажется можно заливать, но предлагаю посмотреть/поправить комментарии

github-actions · 2024-12-27T13:52:10Z

⚪ 2024-12-27 13:52:09 UTC Pre-commit check linux-x86_64-release-asan for b09cb1b has started.
⚪ 2024-12-27 13:52:21 UTC Artifacts will be uploaded here
⚪ 2024-12-27 13:54:46 UTC ya make is running...
🟡 2024-12-27 14:20:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1932	1902	0	20	5	5

⚪ 2024-12-27 14:21:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 14:28:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
47 (only retried tests)	36	0	5	1	5

⚪ 2024-12-27 14:28:35 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 14:32:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
20 (only retried tests)	13	0	2	0	5

🟢 2024-12-27 14:32:26 UTC Build successful.
🟡 2024-12-27 14:32:44 UTC ydbd size 3.6 GiB changed* by +313.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `a61cedc`	merge: `b09cb1b`	diff	diff %
ydbd size	3 869 477 968 Bytes	3 869 798 696 Bytes	+313.2 KiB	+0.008%
ydbd stripped size	1 349 128 112 Bytes	1 349 237 552 Bytes	+106.9 KiB	+0.008%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-27T13:52:10Z

⚪ 2024-12-27 13:52:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for b09cb1b has started.
⚪ 2024-12-27 13:52:20 UTC Artifacts will be uploaded here
⚪ 2024-12-27 13:54:48 UTC ya make is running...
🟡 2024-12-27 14:23:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4731	4612	0	3	36	80

⚪ 2024-12-27 14:24:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-27 14:28:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
98 (only retried tests)	23	0	0	0	75

🟢 2024-12-27 14:28:54 UTC Build successful.
🟡 2024-12-27 14:29:07 UTC ydbd size 2.1 GiB changed* by +131.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `a61cedc`	merge: `b09cb1b`	diff	diff %
ydbd size	2 241 674 192 Bytes	2 241 808 976 Bytes	+131.6 KiB	+0.006%
ydbd stripped size	471 948 624 Bytes	471 969 552 Bytes	+20.4 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Conflicts: ydb/tests/library/harness/kikimr_config.py

github-actions bot added the not-for-changelog label Dec 26, 2024

check colunm tables creation with nullables columns

26d5e79

zverevgeny force-pushed the create_nullable_pk branch from 7656fea to 26d5e79 Compare December 26, 2024 19:27

remove extra empty lines

818fb81

zverevgeny requested a review from maximyurchuk December 26, 2024 19:30

move lines

24e9cec

maximyurchuk reviewed Dec 27, 2024

View reviewed changes

ydb/tests/library/harness/kikimr_config.py Show resolved Hide resolved

maximyurchuk reviewed Dec 27, 2024

View reviewed changes

ydb/tests/workloads/olap_workload/tests/test_workload.py Show resolved Hide resolved

maximyurchuk reviewed Dec 27, 2024

View reviewed changes

maximyurchuk previously approved these changes Dec 27, 2024

View reviewed changes

fixes

6670f58

zverevgeny dismissed maximyurchuk’s stale review via 6670f58 December 27, 2024 13:50

zverevgeny requested a review from maximyurchuk December 27, 2024 13:53

maximyurchuk approved these changes Dec 27, 2024

View reviewed changes

zverevgeny merged commit 916503a into ydb-platform:main Dec 27, 2024
12 checks passed

zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025

check colunm tables creation with nullables columns (ydb-platform#13061)

c56a599

Conflicts: ydb/tests/library/harness/kikimr_config.py

GrigoriyPA mentioned this pull request Jan 5, 2025

KqpRun improved multi query mode and storage settings #13177

Merged

zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025

check colunm tables creation with nullables columns (ydb-platform#13061)

7b8ab48

Conflicts: ydb/tests/library/harness/kikimr_config.py

zverevgeny mentioned this pull request Jan 9, 2025

Integrate changes from main #13202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

check colunm tables creation with nullables columns #13061

check colunm tables creation with nullables columns #13061

zverevgeny commented Dec 26, 2024

github-actions bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

maximyurchuk Dec 27, 2024

maximyurchuk Dec 27, 2024

zverevgeny Dec 27, 2024

maximyurchuk left a comment

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

check colunm tables creation with nullables columns #13061

check colunm tables creation with nullables columns #13061

Conversation

zverevgeny commented Dec 26, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Dec 26, 2024 • edited Loading

github-actions bot commented Dec 26, 2024 • edited Loading

github-actions bot commented Dec 26, 2024 • edited Loading

github-actions bot commented Dec 26, 2024 • edited Loading

maximyurchuk Dec 27, 2024

Choose a reason for hiding this comment

maximyurchuk Dec 27, 2024

Choose a reason for hiding this comment

zverevgeny Dec 27, 2024

Choose a reason for hiding this comment

maximyurchuk left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2024 • edited Loading

github-actions bot commented Dec 27, 2024 • edited Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading