Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug in S3 Physical Optimizer #12985

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed bug in S3 Physical Optimizer #12985

wants to merge 4 commits into from
+91 −1

Conversation

evanevanevanevannnn
Copy link
Collaborator

Changelog entry

Fix for YQ-3956

Changelog category

  • Bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 12:00:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for b5bdb64 has started.
⚪ 2024-12-25 12:00:52 UTC Artifacts will be uploaded here
⚪ 2024-12-25 12:03:14 UTC ya make is running...
🟡 2024-12-25 12:07:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 42 0 1 0 0

⚪ 2024-12-25 12:07:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 12:08:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

⚪ 2024-12-25 12:08:31 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-25 12:09:09 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

🟢 2024-12-25 12:09:15 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 12:00:43 UTC Pre-commit check linux-x86_64-release-asan for b5bdb64 has started.
⚪ 2024-12-25 12:00:55 UTC Artifacts will be uploaded here
⚪ 2024-12-25 12:03:16 UTC ya make is running...
⚫ 2024-12-25 12:11:59 UTC Check cancelled

@evanevanevanevannnn evanevanevanevannnn requested a review from a team as a code owner December 25, 2024 12:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 12:12:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0319936 has started.
⚪ 2024-12-25 12:12:38 UTC Artifacts will be uploaded here
⚪ 2024-12-25 12:15:41 UTC ya make is running...
🟡 2024-12-25 13:14:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28685 25624 0 104 2835 122

⚪ 2024-12-25 13:16:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 13:29:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
290 (only retried tests) 67 0 102 1 120

⚪ 2024-12-25 13:29:31 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-25 13:41:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
282 (only retried tests) 60 0 102 0 120

🟢 2024-12-25 13:41:16 UTC Build successful.
🟢 2024-12-25 13:41:38 UTC ydbd size 2.1 GiB changed* by -100.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 65567d3 merge: 0319936 diff diff %
ydbd size 2 225 951 840 Bytes 2 225 849 368 Bytes -100.1 KiB -0.005%
ydbd stripped size 467 346 384 Bytes 467 323 216 Bytes -22.6 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 12:16:09 UTC Pre-commit check linux-x86_64-release-asan for 0319936 has started.
⚪ 2024-12-25 12:16:20 UTC Artifacts will be uploaded here
⚪ 2024-12-25 12:19:10 UTC ya make is running...
🟡 2024-12-25 13:32:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11994 11906 0 21 14 53

⚪ 2024-12-25 13:33:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 13:46:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
150 (only retried tests) 98 0 3 1 48

⚪ 2024-12-25 13:46:28 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-25 13:49:04 UTC ydbd size 3.6 GiB changed* by -206.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 65567d3 merge: 0319936 diff diff %
ydbd size 3 864 403 440 Bytes 3 864 192 168 Bytes -206.3 KiB -0.005%
ydbd stripped size 1 347 300 880 Bytes 1 347 170 192 Bytes -127.6 KiB -0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-12-25 13:49:06 UTC Check cancelled

GrigoriyPA
GrigoriyPA previously approved these changes Dec 25, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 13:53:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 97fd5c3 has started.
⚪ 2024-12-25 13:53:19 UTC Artifacts will be uploaded here
⚪ 2024-12-25 13:56:10 UTC ya make is running...
🟡 2024-12-25 15:32:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28693 25633 0 103 2835 122

⚪ 2024-12-25 15:35:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 15:47:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
286 (only retried tests) 64 0 102 0 120

⚪ 2024-12-25 15:48:07 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-25 15:59:34 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
282 (only retried tests) 60 0 102 0 120

🟢 2024-12-25 15:59:45 UTC Build successful.
🟢 2024-12-25 16:00:10 UTC ydbd size 2.1 GiB changed* by -96.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2edc9b5 merge: 97fd5c3 diff diff %
ydbd size 2 226 100 904 Bytes 2 226 002 504 Bytes -96.1 KiB -0.004%
ydbd stripped size 467 364 304 Bytes 467 345 232 Bytes -18.6 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 13:53:14 UTC Pre-commit check linux-x86_64-release-asan for 97fd5c3 has started.
⚪ 2024-12-25 13:53:25 UTC Artifacts will be uploaded here
⚪ 2024-12-25 13:56:22 UTC ya make is running...
🟡 2024-12-25 15:10:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12000 11913 0 22 11 54

⚪ 2024-12-25 15:11:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 15:23:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 90 0 2 1 49

⚪ 2024-12-25 15:24:05 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-25 15:35:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 50 0 2 0 48

🟢 2024-12-25 15:35:59 UTC Build successful.
🟢 2024-12-25 15:36:28 UTC ydbd size 3.6 GiB changed* by -31.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 46419b6 merge: 97fd5c3 diff diff %
ydbd size 3 864 473 640 Bytes 3 864 441 080 Bytes -31.8 KiB -0.001%
ydbd stripped size 1 347 318 064 Bytes 1 347 249 136 Bytes -67.3 KiB -0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

⚪ 2024-12-26 09:39:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5ff8a59 has started.
⚪ 2024-12-26 09:39:18 UTC Artifacts will be uploaded here
⚪ 2024-12-26 09:42:08 UTC ya make is running...
🟡 2024-12-26 10:38:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28707 25748 0 4 2836 119

⚪ 2024-12-26 10:40:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-26 10:52:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 59 0 0 0 117

🟢 2024-12-26 10:52:42 UTC Build successful.
🟢 2024-12-26 10:53:12 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d543026 merge: 5ff8a59 diff diff %
ydbd size 2 239 329 432 Bytes 2 239 329 432 Bytes 0 Bytes 0.000%
ydbd stripped size 471 460 784 Bytes 471 460 784 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

⚪ 2024-12-26 09:39:08 UTC Pre-commit check linux-x86_64-release-asan for 5ff8a59 has started.
⚪ 2024-12-26 09:39:20 UTC Artifacts will be uploaded here
⚪ 2024-12-26 09:42:20 UTC ya make is running...
🟡 2024-12-26 10:43:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11116 11051 0 23 15 27

⚪ 2024-12-26 10:45:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-26 10:56:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 81 0 1 1 23

⚪ 2024-12-26 10:56:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-26 11:01:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 25 0 1 0 22

🟢 2024-12-26 11:01:21 UTC Build successful.
🟢 2024-12-26 11:01:48 UTC ydbd size 3.6 GiB changed* by +15.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fc48c46 merge: 5ff8a59 diff diff %
ydbd size 3 865 613 648 Bytes 3 865 629 536 Bytes +15.5 KiB +0.000%
ydbd stripped size 1 347 844 560 Bytes 1 347 847 440 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrigoriyPA GrigoriyPA GrigoriyPA left review comments

@dorooleg dorooleg Awaiting requested review from dorooleg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanevanevanevannnn @GrigoriyPA