Don't omit precomputes in presense of a returning statement #12965

ssmike · 2024-12-25T08:12:18Z

Changelog entry

Changelog category

Bugfix

ssmike · 2024-12-25T08:12:48Z

github-actions · 2024-12-25T08:16:10Z

⚪ 2024-12-25 08:16:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for cb97058 has started.
⚪ 2024-12-25 08:16:21 UTC Artifacts will be uploaded here
⚪ 2024-12-25 08:19:30 UTC ya make is running...
🟡 2024-12-25 09:10:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19084	17184	0	363	1416	121

⚪ 2024-12-25 09:12:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 09:24:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
618 (only retried tests)	140	0	361	0	117

⚪ 2024-12-25 09:24:16 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-25 09:35:56 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
609 (only retried tests)	131	0	361	0	117

🟢 2024-12-25 09:36:06 UTC Build successful.
🟢 2024-12-25 09:36:30 UTC ydbd size 2.1 GiB changed* by +5.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `0b4cab3`	merge: `cb97058`	diff	diff %
ydbd size	2 226 054 424 Bytes	2 226 060 280 Bytes	+5.7 KiB	+0.000%
ydbd stripped size	467 407 152 Bytes	467 408 880 Bytes	+1.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-25T08:16:17Z

⚪ 2024-12-25 08:16:16 UTC Pre-commit check linux-x86_64-release-asan for cb97058 has started.
⚪ 2024-12-25 08:16:28 UTC Artifacts will be uploaded here
⚪ 2024-12-25 08:19:17 UTC ya make is running...
🟡 2024-12-25 09:45:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
12102	11652	0	150	246	54

🟢 2024-12-25 09:46:32 UTC Build successful.
🟢 2024-12-25 09:46:58 UTC ydbd size 3.6 GiB changed* by +23.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `0b4cab3`	merge: `cb97058`	diff	diff %
ydbd size	3 864 669 976 Bytes	3 864 693 824 Bytes	+23.3 KiB	+0.001%
ydbd stripped size	1 347 522 592 Bytes	1 347 540 288 Bytes	+17.3 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

spuchin · 2024-12-26T09:47:16Z

ydb/core/kqp/opt/kqp_opt_phy_finalize.cpp

+        if (auto effect = node.Maybe<TKqlDeleteRows>()) {
+            return !effect.ReturningColumns().Cast().Empty();
+        }
+        if (auto effect = node.Maybe<TExprList>()) {


А в каком случае эта ветка работает? У нас кажется не может быть список в этом месте?

Может, это записи в таблицы со вторичными индексами. В returning правилах тоже бранч есть про это

Для меня похоже на dead code, давай потом посмотрим по coverage, мы вообще в этом бранче бываем?

https://github.com/ydb-platform/ydb/blob/main/ydb/core/kqp/opt/physical/effects/kqp_opt_phy_upsert_index.cpp#L921

https://github.com/ydb-platform/ydb/blob/main/ydb/core/kqp/opt/kqp_opt_effects.cpp#L691

Теста кстати в kqp_returning_ut не нашел с индексами. надо б добавить

ydb/core/kqp/opt/kqp_opt_phy_finalize.cpp

github-actions · 2024-12-27T11:08:15Z

⚪ 2024-12-27 11:08:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for a70c052 has started.
⚪ 2024-12-27 11:08:26 UTC Artifacts will be uploaded here
⚪ 2024-12-27 11:11:41 UTC ya make is running...
🟡 2024-12-27 12:02:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
19356	17443	0	368	1417	128

⚪ 2024-12-27 12:04:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 12:17:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
642 (only retried tests)	161	0	361	0	120

⚪ 2024-12-27 12:17:25 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-27 12:30:26 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
615 (only retried tests)	136	0	360	0	119

🟢 2024-12-27 12:30:39 UTC Build successful.
🟢 2024-12-27 12:31:10 UTC ydbd size 2.1 GiB changed* by +5.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d61c12b`	merge: `a70c052`	diff	diff %
ydbd size	2 241 676 072 Bytes	2 241 681 928 Bytes	+5.7 KiB	+0.000%
ydbd stripped size	471 948 880 Bytes	471 950 608 Bytes	+1.7 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-27T11:08:18Z

⚪ 2024-12-27 11:08:18 UTC Pre-commit check linux-x86_64-release-asan for a70c052 has started.
⚪ 2024-12-27 11:08:29 UTC Artifacts will be uploaded here
⚪ 2024-12-27 11:11:30 UTC ya make is running...
🟡 2024-12-27 12:11:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11476	11049	0	159	241	27

⚪ 2024-12-27 12:12:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 12:26:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
541 (only retried tests)	146	0	152	216	27

⚪ 2024-12-27 12:26:28 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 12:39:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
490 (only retried tests)	99	0	162	203	26

🟢 2024-12-27 12:39:21 UTC Build successful.
🟢 2024-12-27 12:40:06 UTC ydbd size 3.6 GiB changed* by +23.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `d61c12b`	merge: `a70c052`	diff	diff %
ydbd size	3 869 477 968 Bytes	3 869 501 880 Bytes	+23.4 KiB	+0.001%
ydbd stripped size	1 349 128 112 Bytes	1 349 145 872 Bytes	+17.3 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-27T19:21:49Z

⚪ 2024-12-27 19:21:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for f26c5b2 has started.
⚪ 2024-12-27 19:23:49 UTC Artifacts will be uploaded here
⚪ 2024-12-27 19:26:42 UTC ya make is running...
🟡 2024-12-27 20:16:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
17198	16698	0	8	363	129

⚪ 2024-12-27 20:18:01 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-27 20:30:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
288 (only retried tests)	163	0	0	0	125

🟢 2024-12-27 20:30:24 UTC Build successful.
🟢 2024-12-27 20:30:45 UTC ydbd size 2.1 GiB changed* by +7.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `8e01871`	merge: `f26c5b2`	diff	diff %
ydbd size	2 241 982 496 Bytes	2 241 990 224 Bytes	+7.5 KiB	+0.000%
ydbd stripped size	472 001 488 Bytes	472 003 792 Bytes	+2.2 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-27T19:22:05Z

⚪ 2024-12-27 19:22:05 UTC Pre-commit check linux-x86_64-release-asan for f26c5b2 has started.
⚪ 2024-12-27 19:22:17 UTC Artifacts will be uploaded here
⚪ 2024-12-27 19:25:17 UTC ya make is running...
🟡 2024-12-27 20:23:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11480	11400	0	42	8	30

⚪ 2024-12-27 20:24:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-27 20:36:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
133 (only retried tests)	101	0	6	0	26

⚪ 2024-12-27 20:37:08 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-27 20:48:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
61 (only retried tests)	33	0	2	0	26

🟢 2024-12-27 20:48:52 UTC Build successful.
🟢 2024-12-27 20:49:23 UTC ydbd size 3.6 GiB changed* by +23.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `8e01871`	merge: `f26c5b2`	diff	diff %
ydbd size	3 869 789 024 Bytes	3 869 812 752 Bytes	+23.2 KiB	+0.001%
ydbd stripped size	1 349 309 840 Bytes	1 349 324 784 Bytes	+14.6 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…form#12965)

…13117)

…13116)

…form#12965) (ydb-platform#13117)

github-actions bot added the bugfix label Dec 25, 2024

Don't omit precomputes in presense of a returning statement

3feb102

ssmike force-pushed the fix-returning branch from 793caa3 to 3feb102 Compare December 25, 2024 08:13

ssmike enabled auto-merge (squash) December 26, 2024 09:34

spuchin reviewed Dec 26, 2024

View reviewed changes

ydb/core/kqp/opt/kqp_opt_phy_finalize.cpp Show resolved Hide resolved

add an explanatory comment

b1afcf4

spuchin previously approved these changes Dec 27, 2024

View reviewed changes

ssmike dismissed spuchin’s stale review via f40cae8 December 27, 2024 19:17

ssmike force-pushed the fix-returning branch from f40cae8 to 9ccd39b Compare December 27, 2024 19:18

clean diff

4275618

ssmike force-pushed the fix-returning branch from 9ccd39b to 4275618 Compare December 27, 2024 19:19

spuchin approved these changes Dec 28, 2024

View reviewed changes

ssmike merged commit 2e9a579 into ydb-platform:main Dec 28, 2024
12 checks passed

ssmike deleted the fix-returning branch December 28, 2024 11:47

ssmike added a commit to ssmike/ydb that referenced this pull request Dec 28, 2024

Don't omit precomputes in presense of a returning statement (ydb-plat…

5ceae90

…form#12965)

ssmike added a commit to ssmike/ydb that referenced this pull request Dec 28, 2024

Don't omit precomputes in presense of a returning statement (ydb-plat…

a7315f3

…form#12965)

ssmike added a commit that referenced this pull request Dec 28, 2024

Don't omit precomputes in presense of a returning statement (#12965) (#…

43a1fb0

…13117)

ssmike added a commit that referenced this pull request Dec 28, 2024

Don't omit precomputes in presense of a returning statement (#12965) (#…

04f425f

…13116)

GrigoriyPA mentioned this pull request Jan 5, 2025

KqpRun improved multi query mode and storage settings #13177

Merged

zinal pushed a commit to zinal/ydb that referenced this pull request Jan 12, 2025

Don't omit precomputes in presense of a returning statement (ydb-plat…

c34b487

…form#12965) (ydb-platform#13117)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't omit precomputes in presense of a returning statement #12965

Don't omit precomputes in presense of a returning statement #12965

ssmike commented Dec 25, 2024

ssmike commented Dec 25, 2024

github-actions bot commented Dec 25, 2024 •

edited

Loading

github-actions bot commented Dec 25, 2024 •

edited

Loading

spuchin Dec 26, 2024

ssmike Dec 26, 2024

spuchin Dec 27, 2024

ssmike Dec 27, 2024

ssmike Dec 27, 2024

ssmike Dec 27, 2024

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

Don't omit precomputes in presense of a returning statement #12965

Don't omit precomputes in presense of a returning statement #12965

Conversation

ssmike commented Dec 25, 2024

Changelog entry

Changelog category

ssmike commented Dec 25, 2024

github-actions bot commented Dec 25, 2024 • edited Loading

github-actions bot commented Dec 25, 2024 • edited Loading

spuchin Dec 26, 2024

Choose a reason for hiding this comment

ssmike Dec 26, 2024

Choose a reason for hiding this comment

spuchin Dec 27, 2024

Choose a reason for hiding this comment

ssmike Dec 27, 2024

Choose a reason for hiding this comment

ssmike Dec 27, 2024

Choose a reason for hiding this comment

ssmike Dec 27, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2024 • edited Loading

github-actions bot commented Dec 27, 2024 • edited Loading

github-actions bot commented Dec 27, 2024 • edited Loading

github-actions bot commented Dec 27, 2024 • edited Loading

github-actions bot commented Dec 25, 2024 •

edited

Loading

github-actions bot commented Dec 25, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading

github-actions bot commented Dec 27, 2024 •

edited

Loading