Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment YDB CLI version to 2.18.0 #12688

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Increment YDB CLI version to 2.18.0 #12688

merged 3 commits into from
Dec 17, 2024

Conversation

asmyasnikov
Copy link
Member

Changelog entry

YDB CLI 2.18

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@asmyasnikov asmyasnikov changed the title YDB CLI 2.18 Increment YDB CLI version to 2.18.0 Dec 17, 2024
@asmyasnikov asmyasnikov marked this pull request as ready for review December 17, 2024 15:09
@asmyasnikov asmyasnikov requested a review from a team as a code owner December 17, 2024 15:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

⚪ 2024-12-17 15:11:30 UTC Pre-commit check linux-x86_64-release-asan for c64faa1 has started.
⚪ 2024-12-17 15:11:41 UTC Artifacts will be uploaded here
⚫ 2024-12-17 15:12:07 UTC Check cancelled

@asmyasnikov asmyasnikov added area/cli CLI related issues ok-to-test Special label used to approve a PR for testing on our infrastructure labels Dec 17, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Dec 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

⚪ 2024-12-17 15:13:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for c64faa1 has started.
⚪ 2024-12-17 15:13:59 UTC Artifacts will be uploaded here
⚪ 2024-12-17 15:16:23 UTC ya make is running...
🟢 2024-12-17 15:38:22 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
471 469 0 0 2 0

🟢 2024-12-17 15:38:30 UTC Build successful.
🟢 2024-12-17 15:38:39 UTC ydbd size 2.1 GiB changed* by -228.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 426ac15 merge: c64faa1 diff diff %
ydbd size 2 256 450 504 Bytes 2 256 216 664 Bytes -228.4 KiB -0.010%
ydbd stripped size 483 275 504 Bytes 483 269 232 Bytes -6.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

⚪ 2024-12-17 15:16:50 UTC Pre-commit check linux-x86_64-release-asan for c64faa1 has started.
⚪ 2024-12-17 15:17:02 UTC Artifacts will be uploaded here
⚪ 2024-12-17 15:19:26 UTC ya make is running...
🟢 2024-12-17 15:37:59 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9 9 0 0 0 0

🟢 2024-12-17 15:38:05 UTC Build successful.
🟢 2024-12-17 15:38:18 UTC ydbd size 3.6 GiB changed* by -325.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 426ac15 merge: c64faa1 diff diff %
ydbd size 3 898 623 600 Bytes 3 898 290 496 Bytes -325.3 KiB -0.009%
ydbd stripped size 1 364 399 248 Bytes 1 364 374 576 Bytes -24.1 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@asmyasnikov asmyasnikov merged commit 2d03a86 into ydb-platform:main Dec 17, 2024
12 of 14 checks passed
@asmyasnikov asmyasnikov deleted the ydb-cli-2-18 branch December 17, 2024 16:13
galnat
galnat reviewed Dec 17, 2024
View reviewed changes
ydb/apps/ydb/CHANGELOG.md
@@ -1,3 +1,6 @@

## 2.18.0 ##

* `ydb import file csv` command now saves import progress. Relaunching import command will continue from the line it was interrupted on
* Use QueryService by default (`--executer generic`) in `ydb workload kv` and `ydb workload stock` commands
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мы меняем дефолт для пользователя? Это обратно совместимое изменение?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это НЕломающее изменение. То есть должно работать по прежнему, но через другую механику

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну и workload'ы - это не про пользовательские команды, а про встроенные средства тестирования

This was referenced Dec 18, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Dec 25, 2024
Draft
@GrigoriyPA GrigoriyPA mentioned this pull request Dec 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galnat galnat galnat left review comments

@pnv1 pnv1 pnv1 approved these changes

@alex268 alex268 alex268 approved these changes

Assignees
No one assigned
Labels
area/cli CLI related issues not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asmyasnikov @pnv1 @alex268 @galnat